react-notification - npm Package Compare versions

Comparing version 6.2.0 to 6.2.1

CONTRIBUTING.md

 # Contributing
 
-**Please make sure your PR includes both tests and documentation.**
+**Pull requests must include tests and documentation.**
 
-## Getting started
+## Getting Started
 
 1. Clone the repository
 2. Install dependencies: `npm install`
-3. You can now add any changes needed.
-4. Run unit test and linter: `npm test`
+3. Run tests: `npm test`
+4. Run example: `npm start`
 
-## File organization
+## Making a Contribution
 
-All code, including tests, is written in next-generation JavaScript and transpiled using Babel. Source files are located in `src` and transpiled to `dist`, which is gitignored.
+1. Check [the issues](https://github.com/pburtchaell/react-notification/issues) for "help wanted" labels.
+2. Check if there is a pull request already open for this issue. If there is, please do not duplicate efforts.
+3. Commit the changes required to resolve the issue. Git commit messages [should be written in the imperative](http://chris.beams.io/posts/git-commit/).
+4. If needed, add one or more unit test(s). **For new features and bug fixes, a unit test is required.** Follow the [red/green/refactor process](https://en.wikipedia.org/wiki/Test-driven_development#Development_style). 
+5. Run tests and linter: `npm test`. Code is linted using ES Lint. Rules are located in `.eslintrc`. You must maintain the existing code style. **Tests must pass before the PR is merged.**
+6. Document new features and/or API changes.
 
-Tests should be placed in a `test` directory. Note that running tests uses JSDom, which requires io.js.
+## File organization
 
-## Documentation
+All code, including tests, is written in next-generation JavaScript and transpiled using Babel. Source files are located in `src` and transpiled to `dist`, which is gitignored. Tests should be placed in a `test` directory.
 
-New features or API changes should be documented in the README.
+## Contributors
 
-## Code style
+- [Patrick Burtchaell](http://github.com/pburtchaell)
+- [Berkeley Martinez](https://github.com/BerkeleyTrue)
+- [Joey Figaro](https://github.com/joeyfigaro)
 
-Code is linted using ESLint and babel-eslint. Rules are located in `.eslintrc`. Please do your best to maintain the existing code style.

dist/stackedNotification.js

@@ -57,4 +57,4 @@ 'use strict';
     value: function componentWillUnmount() {
+      clearTimeout(this.activeTimeout);
       clearTimeout(this.dismissTimeout);
-      clearTimeout(this.dismissTimeout);
     }
@@ -61,0 +61,0 @@ }, {

package.json

 {
   "name": "react-notification",
-  "version": "6.2.0",
+  "version": "6.2.1",
   "description": "Snackbar style notification component for React.",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

365295

increased by0.19%

No dependency changes