react-three-renderer - npm Package Compare versions

Comparing version 3.2.0 to 3.2.1

CHANGELOG.md

 CHANGELOG
 ===========
 
-## Current Master ([see diff](https://github.com/toxicFork/react-three-renderer/compare/v3.2.0...master))
+## Current Master ([see diff](https://github.com/toxicFork/react-three-renderer/compare/v3.2.1...master))
 
+## 3.2.1 ([see diff](https://github.com/toxicFork/react-three-renderer/compare/v3.2.0...3.2.1))
+
+### Core
+- Use `raf` for `requestAnimationFrame` shimming #163 #164
+
+### Components
+- Fix GeometryDescriptorBase faceVertexUvs property #180
+
 ## 3.2.0 ([see diff](https://github.com/toxicFork/react-three-renderer/compare/v3.1.1...3.2.0))
@@ -7,0 +15,0 @@

CONTRIBUTORS.md

@@ -25,1 +25,2 @@ Thanks for the help:
 * [@AndrewRayCode](https://github.com/AndrewRayCode)
+* [@thierryc](https://github.com/thierryc)

lib/descriptors/Geometry/GeometryDescriptorBase.js

@@ -88,3 +88,3 @@ 'use strict';
     _this.hasProp('faceVertexUvs', {
-      type: _propTypes2.default.arrayOf(_propTypes2.default.arrayOf(_propTypes2.default.arrayOf(THREE.Vector2))),
+      type: _propTypes2.default.arrayOf(_propTypes2.default.arrayOf(_propTypes2.default.arrayOf((0, _propTypeInstanceOf2.default)(THREE.Vector2)))), // [materialIndex][faceIndex][vertexIndex]
       update: function update(threeObject, faceVertexUvs, hasProp) {
@@ -91,0 +91,0 @@ if (hasProp) {

lib/React3Instance.js

@@ -25,2 +25,6 @@ 'use strict';
 
+var _raf = require('raf');
+
+var _raf2 = _interopRequireDefault(_raf);
+
 var _Viewport = require('./Viewport');
@@ -112,3 +116,3 @@
       } else if (_this._renderRequest === null) {
-        _this._renderRequest = requestAnimationFrame(_this._render);
+        _this._renderRequest = (0, _raf2.default)(_this._render);
       }
@@ -264,3 +268,3 @@ };
       } else {
-        this._renderRequest = requestAnimationFrame(this._render);
+        this._renderRequest = (0, _raf2.default)(this._render);
       }
@@ -484,3 +488,3 @@
         // was just set to be forced
-        cancelAnimationFrame(this._renderRequest);
+        _raf2.default.cancel(this._renderRequest);
         this._renderRequest = null;
@@ -490,3 +494,3 @@ } else {
 
-        this._renderRequest = requestAnimationFrame(this._render);
+        this._renderRequest = (0, _raf2.default)(this._render);
       }
@@ -787,3 +791,3 @@ }
       if (this._renderRequest !== null) {
-        cancelAnimationFrame(this._renderRequest);
+        _raf2.default.cancel(this._renderRequest);
         this._renderRequest = null;
@@ -832,3 +836,3 @@ }
       if (this._renderRequest !== null) {
-        cancelAnimationFrame(this._renderRequest);
+        _raf2.default.cancel(this._renderRequest);
         this._renderRequest = null;
@@ -1009,3 +1013,3 @@ }
     } else {
-      _this2._renderRequest = requestAnimationFrame(_this2._render);
+      _this2._renderRequest = (0, _raf2.default)(_this2._render);
     }
@@ -1012,0 +1016,0 @@

package.json

 {
   "name": "react-three-renderer",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "Render into a three.js canvas using React.",
@@ -19,3 +19,4 @@ "main": "./lib/React3.js",
     "fbjs": "0.8.14",
-    "prop-types": "15.5.10"
+    "prop-types": "15.5.10",
+    "raf": "^3.3.2"
   },
@@ -22,0 +23,0 @@ "peerDependencies": {

src/lib/descriptors/Geometry/GeometryDescriptorBase.js

@@ -48,3 +48,6 @@ import * as THREE from 'three';
     this.hasProp('faceVertexUvs', {
-      type: PropTypes.arrayOf(PropTypes.arrayOf(PropTypes.arrayOf(THREE.Vector2))),
+      type: PropTypes.arrayOf(
+        PropTypes.arrayOf(
+          PropTypes.arrayOf(
+            propTypeInstanceOf(THREE.Vector2)))), // [materialIndex][faceIndex][vertexIndex]
       update(threeObject, faceVertexUvs, hasProp) {
@@ -51,0 +54,0 @@ if (hasProp) {

src/lib/React3Instance.js

@@ -7,2 +7,4 @@ import * as THREE from 'three';
 
+import raf from 'raf';
+
 import Viewport from './Viewport';
@@ -69,3 +71,3 @@ import React3Module from './Module';
       } else if (this._renderRequest === null) {
-        this._renderRequest = requestAnimationFrame(this._render);
+        this._renderRequest = raf(this._render);
       }
@@ -220,3 +222,3 @@ };
     } else {
-      this._renderRequest = requestAnimationFrame(this._render);
+      this._renderRequest = raf(this._render);
     }
@@ -313,3 +315,3 @@
     } else {
-      this._renderRequest = requestAnimationFrame(this._render);
+      this._renderRequest = raf(this._render);
     }
@@ -525,3 +527,3 @@
       // was just set to be forced
-      cancelAnimationFrame(this._renderRequest);
+      raf.cancel(this._renderRequest);
       this._renderRequest = null;
@@ -531,3 +533,3 @@ } else {
 
-      this._renderRequest = requestAnimationFrame(this._render);
+      this._renderRequest = raf(this._render);
     }
@@ -804,3 +806,3 @@ }
     if (this._renderRequest !== null) {
-      cancelAnimationFrame(this._renderRequest);
+      raf.cancel(this._renderRequest);
       this._renderRequest = null;
@@ -846,3 +848,3 @@ }
     if (this._renderRequest !== null) {
-      cancelAnimationFrame(this._renderRequest);
+      raf.cancel(this._renderRequest);
       this._renderRequest = null;
@@ -849,0 +851,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

963098

increased by0.05%

Lines of code

19709

increased by0.03%

Worsened metrics

Dependency count

6

increased by20%

Dependency changes

• + Addedraf@^3.3.2

• + Addedperformance-now@2.1.0(transitive)

• + Addedraf@3.4.1(transitive)