react-tooltip - npm Package Compare versions

Comparing version 0.2.4 to 0.2.5

dist/react-tooltip.js

@@ -24,3 +24,4 @@ 'use strict';
     type: _react2['default'].PropTypes.string,
-    effect: _react2['default'].PropTypes.string },
+    effect: _react2['default'].PropTypes.string
+  },
 
@@ -35,3 +36,4 @@ getInitialState: function getInitialState() {
       type: '',
-      effect: '' };
+      effect: ''
+    };
   },
@@ -44,3 +46,4 @@
       type: e.target.getAttribute('data-type') ? e.target.getAttribute('data-type') : this.props.type ? this.props.type : 'dark',
-      effect: e.target.getAttribute('data-effect') ? e.target.getAttribute('data-effect') : this.props.effect ? this.props.effect : 'float' });
+      effect: e.target.getAttribute('data-effect') ? e.target.getAttribute('data-effect') : this.props.effect ? this.props.effect : 'float'
+    });
     this.updateTooltip(e);
@@ -92,7 +95,10 @@ },
       x: 'NONE',
-      y: 'NONE' });
+      y: 'NONE'
+    });
   },
 
   componentDidMount: function componentDidMount() {
-    var targetArray = document.querySelectorAll('[data-tip]');
+    var targetArray = Array.prototype.slice.apply(document.querySelectorAll('[data-tip]')).filter(function (target, index) {
+      return target.getAttribute('data-tip').length > 0;
+    });
     for (var i = 0; i < targetArray.length; i++) {
@@ -106,3 +112,5 @@ targetArray[i].addEventListener('mouseenter', this.showTooltip, false);
   componentWillUnmount: function componentWillUnmount() {
-    var targetArray = document.querySelectorAll('[data-tip]');
+    var targetArray = Array.prototype.slice.apply(document.querySelectorAll('[data-tip]')).filter(function (target, index) {
+      return target.getAttribute('data-tip').length > 0;
+    });
     for (var i = 0; i < targetArray.length; i++) {
@@ -109,0 +117,0 @@ targetArray[i].removeEventListener('mouseenter', this.showTooltip);

package.json

 {
   "name": "react-tooltip",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "react tooltip component",
@@ -5,0 +5,0 @@ "main": "dist/react-tooltip.js",

src/js/index.jsx

@@ -88,4 +88,7 @@ 'use strict';
   componentDidMount() {
-    var targetArray = document.querySelectorAll("[data-tip]");
-    for(var i = 0; i < targetArray.length; i++) {
+    let targetArray = Array.prototype.slice.apply(document.querySelectorAll("[data-tip]"))
+      .filter((target, index) => {
+        return target.getAttribute("data-tip").length > 0;
+      });
+    for(let i = 0; i < targetArray.length; i++) {
       targetArray[i].addEventListener("mouseenter", this.showTooltip, false);
@@ -98,4 +101,7 @@ targetArray[i].addEventListener("mousemove", this.updateTooltip, false);
   componentWillUnmount() {
-    var targetArray = document.querySelectorAll("[data-tip]");
-    for(var i = 0; i < targetArray.length; i++) {
+    let targetArray = Array.prototype.slice.apply(document.querySelectorAll("[data-tip]"))
+      .filter((target, index) => {
+        return target.getAttribute("data-tip").length > 0;
+      });
+    for(let i = 0; i < targetArray.length; i++) {
       targetArray[i].removeEventListener("mouseenter", this.showTooltip);
@@ -102,0 +108,0 @@ targetArray[i].removeEventListener("mousemove", this.updateTooltip);

No alert changes

Improved metrics

Total package byte prevSize

22760

increased by2.39%

Lines of code

294

increased by5%

No dependency changes