react-virtualized - npm Package Compare versions

Comparing version 5.1.0 to 5.1.1

CHANGELOG.md

 Changelog
 ------------
 
+##### 5.1.1
+Marked `FlexColumn` `width` property as required since ommitting this property can lead to uneven column layouts.
+
 ### 5.1.0
@@ -5,0 +8,0 @@ Added `ColumnSizer` high-order component for auto-calculating column widths for `Grid` cells.

es/FlexTable/FlexColumn.js

@@ -99,3 +99,3 @@ 'use strict';
       /** Optional fixed width for this column */
-      width: _react.PropTypes.number
+      width: _react.PropTypes.number.isRequired
     },
@@ -102,0 +102,0 @@ enumerable: true

es/FlexTable/FlexTable.js

@@ -478,9 +478,4 @@ 'use strict';
     value: function _getFlexStyleForColumn(column) {
-      var flex = [];
-      flex.push(column.props.flexGrow);
-      flex.push(column.props.flexShrink);
-      flex.push(column.props.width ? column.props.width + 'px' : 'auto');
+      var flexValue = column.props.flexGrow + ' ' + column.props.flexShrink + ' ' + column.props.width + 'px';
 
-      var flexValue = flex.join(' ');
-
       return {
@@ -487,0 +482,0 @@ flex: flexValue,

package.json

@@ -6,3 +6,3 @@ {
   "user": "bvaughn",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "homepage": "https://github.com/bvaughn/react-virtualized",
@@ -9,0 +9,0 @@ "main": "dist/react-virtualized.js",

source/FlexTable/FlexColumn.js

@@ -79,4 +79,4 @@ /** @flow */
     /** Optional fixed width for this column */
-    width: PropTypes.number
+    width: PropTypes.number.isRequired
   }
 }

source/FlexTable/FlexTable.js

@@ -390,13 +390,4 @@ /** @flow */
   _getFlexStyleForColumn (column) {
-    const flex = []
-    flex.push(column.props.flexGrow)
-    flex.push(column.props.flexShrink)
-    flex.push(
-      column.props.width
-        ? `${column.props.width}px`
-        : 'auto'
-    )
+    const flexValue = `${column.props.flexGrow} ${column.props.flexShrink} ${column.props.width}px`
 
-    const flexValue = flex.join(' ')
-
     return {
@@ -403,0 +394,0 @@ flex: flexValue,

No alert changes

Improved metrics

Total package byte prevSize

827703

increased by0.05%

Worsened metrics

Lines of code

11754

decreased by-0.06%

No dependency changes