ref - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

History.md

 
+1.1.2 / 2015-09-19
+==================
+
+  * CString: allow a Buffer to be used as backing store in `set()` (https://github.com/node-ffi/node-ffi/issues/169)
+  * travis, appveyor: test Node.js v4
+
 1.1.1 / 2015-09-14
@@ -3,0 +9,0 @@ ==================

lib/ref.js

@@ -1030,11 +1030,17 @@
   , get: function get (buf, offset) {
-      var _buf = buf.readPointer(offset)
-      if (_buf.isNull()) {
+      var _buf = exports.readPointer(buf, offset)
+      if (exports.isNull(_buf)) {
         return null
       }
-      return _buf.readCString(0)
+      return exports.readCString(_buf, 0)
     }
   , set: function set (buf, offset, val) {
-      var _buf = exports.allocCString(val)
-      return buf.writePointer(_buf, offset)
+      var _buf
+      if (Buffer.isBuffer(val)) {
+        _buf = val
+      } else {
+        // assume string
+        _buf = exports.allocCString(val)
+      }
+      return exports.writePointer(buf, offset, _buf)
     }
@@ -1041,0 +1047,0 @@ }

package.json

@@ -20,3 +20,3 @@ {
   ],
-  "version": "1.1.1",
+  "version": "1.1.2",
   "license": "MIT",
@@ -23,0 +23,0 @@ "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)",

test/string.js

@@ -75,2 +75,3 @@
 
+      // another version of the same test
       assert.strictEqual(null, ref.get(ref.NULL_POINTER, 0, ref.types.CString))
@@ -82,8 +83,18 @@ })
       var buf = ref.alloc(ref.types.CString)
-      buf.writePointer(Buffer(str + '\0'))
+      buf.writePointer(new Buffer(str + '\0'))
       assert.strictEqual(str, buf.deref())
     })
 
+    // https://github.com/node-ffi/node-ffi/issues/169
+    it('should set a Buffer as backing store', function () {
+      var str = 'hey!'
+      var store = new Buffer(str + '\0')
+      var buf = ref.alloc(ref.types.CString)
+      ref.set(buf, 0, store)
+
+      assert.equal(str, ref.get(buf, 0))
+    })
+
   })
 
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

428867

increased by0.17%

Lines of code

2930

increased by0.51%

No dependency changes