ref - npm Package Compare versions

Comparing version 1.3.3 to 1.3.4

CHANGELOG.md

@@ -0,1 +1,8 @@
+1.3.4 / 2017-01-27
+==================
+
+* [[`32637be7e4`](https://github.com/TooTallNate/ref/commit/32637be7e4)] - CI stuffs (Nathan Rajlich)
+* [[`55716fd9e3`](https://github.com/TooTallNate/ref/commit/55716fd9e3)] - always use `defineProperty()` for `name` (Nathan Rajlich)
+* [[`786b73941e`](https://github.com/TooTallNate/ref/commit/786b73941e)] - **refType**: force name to writable before updating it (Joel Martin) (#67)
+
 1.3.3 / 2016-11-03
@@ -2,0 +9,0 @@ ==================

lib/ref.js

@@ -309,3 +309,8 @@
   if (_type.name) {
-    rtn.name = _type.name + '*'
+    Object.defineProperty(rtn, 'name', {
+      value: _type.name + '*',
+      configurable: true,
+      enumerable: true,
+      writable: true
+    })
   }
@@ -312,0 +317,0 @@ return rtn

package.json

@@ -20,3 +20,3 @@ {
   ],
-  "version": "1.3.3",
+  "version": "1.3.4",
   "license": "MIT",
@@ -31,3 +31,3 @@ "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)",
     "docs": "node docs/compile",
-    "test": "mocha -gc --reporter spec"
+    "test": "mocha -gc --reporter spec --use_strict"
   },
@@ -34,0 +34,0 @@ "dependencies": {

test/types.js

@@ -22,2 +22,24 @@
 
+    it('should override and update a read-only name property', function () {
+      // a type similar to ref-struct's StructType
+      // used for types refType name property test
+      function StructType() {}
+      StructType.size = 0
+      StructType.indirection = 0
+
+      // read-only name property
+      assert.equal(StructType.name, 'StructType')
+      try {
+        StructType.name = 'foo'
+      } catch (err) {
+        // ignore
+      }
+      assert.equal(StructType.name, 'StructType')
+
+      // name property should be writable and updated
+      var newObj = ref.refType(StructType)
+      var newProp = Object.getOwnPropertyDescriptor(newObj, 'name')
+      assert.equal(newProp.writable, true)
+      assert.equal(newObj.name, 'StructType*')
+    })
   })
@@ -24,0 +46,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

434570

increased by0.16%

Lines of code

3028

increased by0.83%

No dependency changes