require-inject - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

index.js

@@ -5,10 +5,21 @@ "use strict";
 module.exports = function (toLoad, mocks) {
+  // Copy the existing cache
+  var originalCache = {}
+  Object.keys(require.cache).forEach(function(name) {
+    originalCache[name] = require.cache[name]
+  })
+
   // Inject all of our mocks
   Object.keys(mocks).forEach(function(name){
     var path = require.resolve(name)
-    require.cache[path] = {exports: mocks[name]}
+    if (mocks[name] == null) {
+      delete require.cache[path]
+    }
+    else {
+      require.cache[path] = {exports: mocks[name]}
+    }
   })
 
   if (/^[.][.]?\//.test(toLoad)) {
-      toLoad = path.resolve(path.dirname(module.parent.filename), toLoad)
+    toLoad = path.resolve(path.dirname(module.parent.filename), toLoad)
   }
@@ -19,12 +30,12 @@ var toLoadPath = require.resolve(toLoad)
   delete require.cache[toLoadPath]
+
   // load our new version using our mocks
   var mocked = module.parent.require(toLoadPath)
-  // remove our version from the cache so anyone else gets the real thing
-  delete require.cache[toLoadPath]
 
-  // Remove our injected mocks
-  Object.keys(mocks).forEach(function(name){
-      delete require.cache[require.resolve(name)]
-  })
+  // restore the cache, we can't just assign originalCache to require.cache as the require
+  // object is unique to each module, even though require.cache is shared
+  Object.keys(require.cache).forEach(function(name){ delete require.cache[name] })
+  Object.keys(originalCache).forEach(function(name){ require.cache[name] = originalCache[name] })
+
   return mocked
 }

package.json

 {
   "name": "require-inject",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "A simple mock injector compatible needing no instrumentation in the libraries being tested",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "tap test/*.js"
   },
@@ -21,3 +21,6 @@ "author": "Rebecca Turner <[e-mail]> (http://re-becca.org)",
   },
-  "license": "ISC"
+  "license": "ISC",
+  "devDependencies": {
+    "tap": "^0.4.13"
+  }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4159

increased by21.25%

Number of package files

9

increased by80%

Lines of code

79

increased by229.17%

Number of low quality alerts

1

decreased by-50%

Worsened metrics

Dev dependency count

1

increased byInfinity%

No dependency changes