rewire - npm Package Compare versions

Comparing version 2.1.1 to 2.1.2

CHANGELOG.md

 Changelog
 ---------
 
+### 2.1.2
+
+- Fixed missing `var` statement which lead to pollution of global namespace [#33](https://github.com/jhnns/rewire/pull/33)
+
 ### 2.1.1
@@ -5,0 +9,0 @@ - Made magic `__set__`, `__get__` and `__with__` not enumerable [#32](https://github.com/jhnns/rewire/pull/32)

lib/rewire.js

@@ -22,3 +22,4 @@ var Module = require("module"),
         prelude,
-        appendix;
+        appendix,
+        src;
 
@@ -25,0 +26,0 @@ // Checking params

package.json

 {
     "name" : "rewire",
-    "version" : "2.1.1",
+    "version" : "2.1.2",
     "description" : "Easy dependency injection for node.js unit testing",
@@ -5,0 +5,0 @@ "keywords" : [

test/rewire.test.js

@@ -19,2 +19,10 @@ // Don't run code in ES5 strict mode.
     });
+    it("should keep not leak globals", function () {
+        // This test should run first, as the global space may be already polluted if 
+        //   require("../") is run before this test.
+        var originalGlobalKeys = Object.keys(global),
+            rewire = require("../"),
+            emptyModule = rewire("./testModules/emptyModule.js");
+        expect(Object.keys(global)).to.eql(originalGlobalKeys);
+    });
     it("should pass all shared test cases", function () {
@@ -21,0 +29,0 @@ require("./testModules/sharedTestCases.js");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

60687

increased by0.9%

Lines of code

1191

increased by0.76%

No dependency changes