ripple-hbase-client - npm Package Compare versions

Comparing version 0.1.15 to 0.1.16

package.json

 {
   "name": "ripple-hbase-client",
-  "version": "0.1.15",
+  "version": "0.1.16",
   "description": "ripple hbase client",
@@ -9,3 +9,3 @@ "main": "src/index.js",
     "generic-pool": "3.4.2",
-    "moment": "2.18.1",
+    "moment": "2.22.2",
     "thrift": "0.11.0",
@@ -12,0 +12,0 @@ "winston": "2.3.1"

src/index.js

@@ -320,3 +320,3 @@ const Logger = require('./logger');
 
-  if (!rows.length) {
+  if (!rows.length && !options.removeEmptyColumns) {
     return Promise.resolve(0)
@@ -323,0 +323,0 @@ }

test/test.js

@@ -659,16 +659,19 @@ const mock = require('./mock.json')
   it('should save multiple rows while removing empty columns', function() {
-    mock.rows.removeEmptyColumns = true
-    mock.rows.rows['ROW|3'].column1 = ''
-    mock.rows.rows['ROW|4'].column6 = ''
-
-    return hbase.putRows(mock.rows)
+    return hbase.putRows({
+      table: mock.rows.table,
+      rows: {
+        'ROW|4' : { column5: '' },
+        'ROW|5' : { column6: '' }
+      },
+      removeEmptyColumns: true
+    })
     .then(count => {
-      assert.strictEqual(count, Object.keys(mock.rows.rows).length)
+      assert.strictEqual(count, 0);
       return hbase.getRows({
         table: mock.rows.table,
-        rowkeys: ['ROW|3', 'ROW|4']
+        rowkeys: ['ROW|4', 'ROW|5']
       })
       .then(rows => {
-        assert.strictEqual(rows[0].columns.column1, undefined)
-        assert.strictEqual(rows[0].columns.column2, 'two')
+        assert.strictEqual(rows[0].columns.column5, undefined)
+        assert.strictEqual(rows[0].columns.column6, '6')
         assert.strictEqual(rows[1].columns.column6, undefined)
@@ -675,0 +678,0 @@ assert.strictEqual(rows[1].columns.column5, '5')

No alert changes

Improved metrics

Total package byte prevSize

426925

increased by0.01%

Lines of code

14705

increased by0.03%

Dependency changes

• + Addedmoment@2.22.2(transitive)

• - Removedmoment@2.18.1(transitive)

• Updatedmoment@2.22.2