roku-deploy - npm Package Compare versions

Comparing version 2.2.0 to 2.2.1

.nyc_output/processinfo/index.json

@@ -1,1 +0,1 @@
-{"processes":{"2acafc99-dea9-4be5-ae4f-ddbd54cd7cea":{"parent":"fac3823e-3c58-465d-b329-fe1f925e17ff","children":[]},"968e8a31-d43d-41cf-a3a0-7ef4c13d4fb1":{"parent":null,"children":["fac3823e-3c58-465d-b329-fe1f925e17ff"]},"fac3823e-3c58-465d-b329-fe1f925e17ff":{"parent":"968e8a31-d43d-41cf-a3a0-7ef4c13d4fb1","children":["2acafc99-dea9-4be5-ae4f-ddbd54cd7cea"]}},"files":{"/home/travis/build/TwitchBronBron/roku-deploy/src/RokuDeploy.ts":["fac3823e-3c58-465d-b329-fe1f925e17ff"]},"externalIds":{}}
+{"processes":{"18ef0e8e-6ba0-4e0c-a8e3-730352493ae4":{"parent":"4fa9a821-23ae-49d1-8bfb-555eb92f6f6c","children":[]},"1d403c19-a8ee-4f18-8e6f-b8d16b9bff23":{"parent":null,"children":["4fa9a821-23ae-49d1-8bfb-555eb92f6f6c"]},"4fa9a821-23ae-49d1-8bfb-555eb92f6f6c":{"parent":"1d403c19-a8ee-4f18-8e6f-b8d16b9bff23","children":["18ef0e8e-6ba0-4e0c-a8e3-730352493ae4"]}},"files":{"/home/travis/build/TwitchBronBron/roku-deploy/src/RokuDeploy.ts":["4fa9a821-23ae-49d1-8bfb-555eb92f6f6c"]},"externalIds":{}}

CHANGELOG.md

@@ -9,6 +9,12 @@ # Changelog
 
+## [2.2.1] - 2019-08-07
+### Fixed
+ - colors starting with # symbol in manifest file that were being treated as comments. This removes the dependency on `ini` in favor of a local function.
+
+
+
 ## [2.2.0] - 2019-07-05
-# Added
+### Added
  - support for converting to squashfs
-# Fixed
+### Fixed
  - issue where manifest files with `bs_const` weren't being handled correctly
@@ -18,4 +24,4 @@
 
-# [2.1.0] - 2019-05-14
-# Added
+## [2.1.0] - 2019-05-14
+### Added
  - rekeying capability
@@ -25,8 +31,8 @@
 
-# [2.1.0-beta1] - 2019-02-15
-# Added
+## [2.1.0-beta1] - 2019-02-15
+### Added
  - Support for signed package creation
  - ability to register a callback function before the package is zipped. 
  - `incrementBuildNumber` option
-# Changed
+### Changed
  - Stop calling home button on deploy
@@ -37,4 +43,4 @@ - `outFile` to be `baseName` so it can be used for both zip and pkg file names
 
-# [2.0.0] - 2019-01-07
-#Added
+## [2.0.0] - 2019-01-07
+### Added
  - support for absolute file paths in the `files` property
@@ -45,4 +51,4 @@ - dereference symlinks on file copy
 
-# [2.0.0-beta5] - 2019-01-18
-# Changed
+## [2.0.0-beta5] - 2019-01-18
+### Changed
  - Changed `normalizeFilesOption` to be sync instead of async, since it didn't need to be async.
@@ -52,4 +58,4 @@
 
-# [2.0.0-beta4] - 2019-01-17
-# Fixed
+## [2.0.0-beta4] - 2019-01-17
+### Fixed
  - bug that wasn't using rootDir for glob matching
@@ -59,4 +65,4 @@
 
-# [2.0.0-beta3] - 2019-01-17
-# Changed
+## [2.0.0-beta3] - 2019-01-17
+### Changed
  - export the `getFilepaths` for use in external libraries
@@ -66,6 +72,6 @@
 
-# [2.0.0-beta2] - 2019-01-15
-# Changed
+## [2.0.0-beta2] - 2019-01-15
+### Changed
  - prevent empty directories from being created
-# Fixed
+### Fixed
  - bug in `src`/`dest` globs.
@@ -76,6 +82,6 @@ - bug that wasn't copying folders properly
 
-# [2.0.0-beta1] - 2019-01-07
-# Changed
+## [2.0.0-beta1] - 2019-01-07
+### Changed
  - removed the requirement for manifest to be located at the top of `rootDir`. Instead, it is simply assumed to exist.
-#Fixed
+### Fixed
  - regression issue that prevented folder names from being used without globs
@@ -85,8 +91,8 @@
 
-# [1.0.0] - 2018-12-18
-# Added
+## [1.0.0] - 2018-12-18
+### Added
  - support for negated globs
 
 
-
+[2.2.1]:  https://github.com/TwitchBronBron/roku-deploy/compare/v2.2.0...v2.2.1
 [2.2.0]:  https://github.com/TwitchBronBron/roku-deploy/compare/v2.1.0...v2.2.0
@@ -93,0 +99,0 @@ [2.1.0]:  https://github.com/TwitchBronBron/roku-deploy/compare/v2.1.0-beta1...v2.1.0

dist/RokuDeploy.d.ts

@@ -153,3 +153,4 @@ import * as fsExtra1 from 'fs-extra';
     parseManifest(manifestPath: string): Promise<ManifestData>;
-    stringifyManifest(manifestData: ManifestData): Promise<string>;
+    parseManifestFromString(manifestContents: string): ManifestData;
+    stringifyManifest(manifestData: ManifestData): string;
     /**
@@ -165,3 +166,3 @@ * Given a path to a folder, zip up that folder and all of its contents
      * A full path to the folder where the zip/pkg package should be placed
-     * @default "./out"
+     * @default './out'
      */
@@ -171,3 +172,3 @@ outDir?: string;
      * The base filename the zip/pkg file should be given (excluding the extension)
-     * @default "roku-deploy"
+     * @default 'roku-deploy'
      */
@@ -185,6 +186,6 @@ outFile?: string;
      * @default [
-            "source/**\/*.*",
-            "components/**\/*.*",
-            "images/**\/*.*",
-            "manifest"
+            'source/**\/*.*',
+            'components/**\/*.*',
+            'images/**\/*.*',
+            'manifest'
         ],
@@ -201,3 +202,3 @@ */
      * @required
-     * @example "192.168.1.21"
+     * @example '192.168.1.21'
      *
@@ -209,3 +210,3 @@ */
      * just in case roku adds support for custom usernames in the future
-     * @default "rokudev"
+     * @default 'rokudev'
      */
@@ -246,3 +247,7 @@ username?: string;
 export interface ManifestData {
-    [key: string]: string;
+    [key: string]: any;
+    keyIndexes?: {
+        [id: string]: number;
+    };
+    lineCount?: number;
 }
@@ -249,0 +254,0 @@ export interface BeforeZipCallbackInfo {

dist/RokuDeploy.js

@@ -44,3 +44,2 @@ "use strict";
 var archiver = require("archiver");
-var ini = require("ini");
 var dateformat = require("dateformat");
@@ -963,3 +962,3 @@ var errors = require("./Errors");
         return __awaiter(this, void 0, void 0, function () {
-            var manifestContents, parsedManifest;
+            var manifestContents;
             return __generator(this, function (_a) {
@@ -975,4 +974,3 @@ switch (_a.label) {
                         manifestContents = _a.sent();
-                        parsedManifest = ini.parse(manifestContents);
-                        return [2 /*return*/, parsedManifest];
+                        return [2 /*return*/, this.parseManifestFromString(manifestContents)];
                 }
@@ -982,17 +980,36 @@ });
     };
+    RokuDeploy.prototype.parseManifestFromString = function (manifestContents) {
+        var manifestLines = manifestContents.split('\n');
+        var manifestData = {};
+        manifestData.keyIndexes = {};
+        manifestData.lineCount = manifestLines.length;
+        manifestLines.map(function (line, index) {
+            var match = /(\w+)=(.+)/.exec(line);
+            if (match) {
+                var key = match[1];
+                manifestData[key] = match[2];
+                manifestData.keyIndexes[key] = index;
+            }
+        });
+        return manifestData;
+    };
     RokuDeploy.prototype.stringifyManifest = function (manifestData) {
-        var bsConst;
-        // bs_const uses equal signs in the right hand side which ini then adds quotes around the whole thing.
-        // It doesn't seem like a fix will be available soon (https://github.com/npm/ini/issues/57)
-        // so we remove it before stringifying and add it back in afterwards to get around this.
-        if (manifestData.bs_const) {
-            bsConst = manifestData.bs_const;
-            manifestData = Object.assign({}, manifestData);
-            delete manifestData.bs_const;
+        var output = [];
+        if (manifestData.keyIndexes && manifestData.lineCount) {
+            output.fill('', 0, manifestData.lineCount);
+            var key = void 0;
+            for (key in manifestData) {
+                if (key === 'lineCount' || key === 'keyIndexes') {
+                    continue;
+                }
+                var index = manifestData.keyIndexes[key];
+                output[index] = key + "=" + manifestData[key];
+            }
         }
-        var result = ini.stringify(manifestData);
-        if (bsConst) {
-            result += 'bs_const=' + bsConst;
+        else {
+            output = Object.keys(manifestData).map(function (key) {
+                return key + "=" + manifestData[key];
+            });
         }
-        return result;
+        return output.join('\n');
     };
@@ -999,0 +1016,0 @@ /**

package.json

 {
   "name": "roku-deploy",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "description": "Package and publish a Roku application using Node.js",
@@ -78,3 +78,2 @@ "main": "dist/index.js",
     "glob-all": "^3.1.0",
-    "ini": "^1.3.5",
     "path": "^0.12.7",
@@ -81,0 +80,0 @@ "q": "^1.5.1",

readme.md

@@ -181,2 +181,2 @@ # roku-deploy
 ## Changelog
-Click [here](readme.md) to view the changelog
+Click [here](CHANGELOG.md) to view the changelog

No alert changes

Improved metrics

Total package byte prevSize

361878

increased by1.65%

Dependency count

7

decreased by-12.5%

Lines of code

2101

increased by1.06%

Dependency changes

• - Removedini@^1.3.5

• - Removedini@1.3.8(transitive)