seneca - npm Package Compare versions

Comparing version 3.22.0 to 3.23.0

lib/api.js

@@ -39,2 +39,4 @@ /* Copyright © 2010-2018 Richard Rodger and other contributors, MIT License. */
 
+  // TODO: attach msgargs and custom to delegate.private$ in some way for debugging
+
   fix_delegate.add = function fix_add() {
@@ -173,3 +175,3 @@ return self.add.apply(
 exports.fail = function (...args) {
-  if (args.length === 2) {
+  if (args.length <= 2) {
     return failIf(this, true, ...args)
@@ -176,0 +178,0 @@ }

lib/plugin.js

@@ -199,2 +199,3 @@ /* Copyright © 2020 Richard Rodger and other contributors, MIT License. */
         },
+        // Handle plugin meta data returned by plugin define function
         meta: (spec) => {
@@ -211,3 +212,7 @@ let seneca = spec.ctx.seneca;
                 if (void 0 !== v) {
-                    let exportname = plugin.fullname + '/' + k;
+                    let exportfullname = plugin.fullname + '/' + k;
+                    exports[exportfullname] = v;
+                    // Also provide exports on untagged plugin name. This is the
+                    // standard name that other plugins use
+                    let exportname = plugin.name + '/' + k;
                     exports[exportname] = v;
@@ -220,9 +225,3 @@ }
                         [meta.order.plugin];
-                    //console.log('AAA', spec.task.name, tasks)
-                    //try {
                     seneca.order.plugin.add(tasks);
-                    //}
-                    //catch (e) {
-                    //  console.log(e)
-                    //}
                     delete meta.order.plugin;
@@ -562,2 +561,7 @@ }
             seneca_export: (tr, ctx, data) => {
+                // NOTE/plugin/774a: when loading multiple tagged plugins,
+                // last plugin wins the plugin name on the exports. This is
+                // consistent with general Seneca principal that plugin load
+                // order is significant, as later plugins override earlier
+                // action patterns. Thus later plugins override exports too.
                 Object.assign(data.exports, tr.out.exports);
@@ -564,0 +568,0 @@ Object.assign(ctx.seneca.private$.exports, tr.out.exports);

lib/plugin.ts

@@ -275,2 +275,3 @@ /* Copyright © 2020 Richard Rodger and other contributors, MIT License. */
 
+    // Handle plugin meta data returned by plugin define function
     meta: (spec: TaskSpec) => {
@@ -290,3 +291,8 @@ let seneca: any = spec.ctx.seneca
         if (void 0 !== v) {
-          let exportname = plugin.fullname + '/' + k
+          let exportfullname = plugin.fullname + '/' + k
+          exports[exportfullname] = v
+
+          // Also provide exports on untagged plugin name. This is the
+          // standard name that other plugins use
+          let exportname = plugin.name + '/' + k
           exports[exportname] = v
@@ -303,9 +309,3 @@ }
 
-          //console.log('AAA', spec.task.name, tasks)
-          //try {
           seneca.order.plugin.add(tasks)
-          //}
-          //catch (e) {
-          //  console.log(e)
-          //}
           delete meta.order.plugin
@@ -777,2 +777,7 @@ }
       seneca_export: (tr: any, ctx: any, data: any): any => {
+        // NOTE/plugin/774a: when loading multiple tagged plugins,
+        // last plugin wins the plugin name on the exports. This is
+        // consistent with general Seneca principal that plugin load
+        // order is significant, as later plugins override earlier
+        // action patterns. Thus later plugins override exports too.
         Object.assign(data.exports, tr.out.exports)
@@ -779,0 +784,0 @@ Object.assign(ctx.seneca.private$.exports, tr.out.exports)

package.json

 {
   "name": "seneca",
   "description": "A Microservices Framework for Node.js",
-  "version": "3.22.0",
+  "version": "3.23.0",
   "license": "MIT",
@@ -75,2 +75,3 @@ "homepage": "http://senecajs.org",
     "test": "lab -v -P test -L -t 90 --sourcemaps --transform node_modules/lab-transform-typescript  -r console -o stdout -r html -o test/coverage.html",
+    "test-some": "lab -v -P test --sourcemaps --transform node_modules/lab-transform-typescript -g",
     "coveralls": "lab -s -P test -r lcov | coveralls",
@@ -90,5 +91,4 @@ "coverage": "lab -v -P test -L -t 90 -r html > docs/coverage.html",
     "fast-safe-stringify": "^2.0.7",
-    "gate-executor": "^2.1.0",
-    "gex": "^1.0.0",
-    "jsonic": "^0.3.1",
+    "gate-executor": "^3.0.0",
+    "jsonic": "^1.0.1",
     "lodash.defaultsdeep": "^4.6.1",
@@ -98,7 +98,7 @@ "lodash.flatten": "^4.4.0",
     "minimist": "^1.2.5",
-    "nid": "^1.1.0",
+    "nid": "^1.3.3",
     "norma": "^2.0.2",
     "optioner": "^5.0.1",
-    "ordu": "^1.7.1",
-    "patrun": "^4.0.0",
+    "ordu": "^2.0.0",
+    "patrun": "^7.0.0",
     "qs": "^6.9.4",
@@ -110,5 +110,5 @@ "rolling-stats": "^0.1.1",
   "devDependencies": {
-    "@hapi/code": "^8.0.1",
-    "@hapi/hoek": "^9.0.4",
-    "@hapi/lab": "^22.0.4",
+    "@hapi/code": "^8.0.2",
+    "@hapi/hoek": "^9.1.0",
+    "@hapi/lab": "^24.1.0",
     "@seneca/test-plugin": "0.0.1",
@@ -121,10 +121,11 @@ "async": "^3.2.0",
     "lolex": "^6.0.0",
-    "prettier": "^2.0.5",
-    "seneca-entity": "^10.0.2",
+    "prettier": "^2.1.2",
+    "seneca-entity": "^10.1.0",
     "seneca-error-test": "^0.2.2",
     "seneca-joi": "^7.0.2",
     "seneca-promisify": "^2.0.0",
-    "typescript": "^3.9.6",
-    "@types/node": "^14.0.14"
+    "gex": "^3.0.1",
+    "typescript": "^4.0.5",
+    "@types/node": "^14.14.8"
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

254521

increased by0.51%

Dependency count

19

decreased by-5%

Lines of code

6036

increased by0.15%

Worsened metrics

Dev dependency count

18

increased by5.88%

Dependency changes

• + Addedgate-executor@3.1.1(transitive)

• + Addedgex@4.0.1(transitive)

• + Addedjsonic@1.0.1(transitive)

• + Addednua@2.0.1(transitive)

• + Addedordu@2.2.0(transitive)

• + Addedpatrun@7.2.7(transitive)

• - Removedgex@^1.0.0

• - Removedgate-executor@2.1.0(transitive)

• - Removednua@1.0.2(transitive)

• - Removedordu@1.7.1(transitive)

• - Removedpatrun@4.0.0(transitive)

• Updatedgate-executor@^3.0.0

• Updatedjsonic@^1.0.1

• Updatednid@^1.3.3

• Updatedordu@^2.0.0

• Updatedpatrun@^7.0.0