sequelize - npm Package Compare versions

Comparing version 1.6.0-beta-3 to 1.6.0-beta4

lib/dialects/sqlite/query-generator.js

@@ -185,3 +185,3 @@ var Utils = require("../../utils")
 
-      return hashToWhereConditions(hash)
+      return hashToWhereConditions(hash).replace(/\\'/g, "''");
     }
@@ -188,0 +188,0 @@ }

lib/sequelize.js

@@ -142,3 +142,3 @@ var Utils             = require("./utils")
     options = Utils._.extend(Utils._.clone(this.options.query), options)
-    options = Utils._.extend(options, {
+    options = Utils._.defaults(options, {
       logging: this.options.hasOwnProperty('logging') ? this.options.logging : console.log,
@@ -145,0 +145,0 @@ type: (sql.toLowerCase().indexOf('select') === 0) ? 'SELECT' : false

package.json

 {
   "name": "sequelize",
   "description": "Multi dialect ORM for Node.JS",
-  "version": "1.6.0-beta-3",
+  "version": "1.6.0-beta4",
   "author": "Sascha Depold <[e-mail]>",
@@ -6,0 +6,0 @@ "contributors": [

spec/dao.spec.js

@@ -101,2 +101,36 @@ if(typeof require === 'function') {
   })
+
+  describe('findAll', function findAll() {
+    it("escapes a single single quotes properly in where clauses", function(done) {
+      var self = this
+
+      this.User
+        .create({ username: "user'name" })
+        .success(function() {
+          self.User.findAll({
+            where: { username: "user'name" }
+          }).success(function(users) {
+            expect(users.length).toEqual(1)
+            expect(users[0].username).toEqual("user'name")
+            done()
+          })
+        })
+    })
+
+    it("escapes two single quotes properly in where clauses", function(done) {
+      var self = this
+
+      this.User
+        .create({ username: "user''name" })
+        .success(function() {
+          self.User.findAll({
+            where: { username: "user''name" }
+          }).success(function(users) {
+            expect(users.length).toEqual(1)
+            expect(users[0].username).toEqual("user''name")
+            done()
+          })
+        })
+    })
+  })
 })

No alert changes

Improved metrics

Total package byte prevSize

2541358

increased by0.04%

Lines of code

9530

increased by0.32%

No dependency changes