serum-vial - npm Package Compare versions

Comparing version 1.5.0 to 1.5.1

dist/data_mapper.js

@@ -232,4 +232,12 @@ "use strict";
                 if (message.type === 'fill' && message.maker === false) {
-                    // this is rather fragile way of finding matching fill, can it be done better?
-                    const matchingMakerFill = l3Diff.find((m) => m.type === 'fill' && m.maker === true && m.size === message.size);
+                    let matchingMakerFill;
+                    for (let j = i - 1; j >= 0; j--) {
+                        const potentialFillMessage = l3Diff[j];
+                        if (potentialFillMessage.type === 'fill' &&
+                            potentialFillMessage.maker === true &&
+                            potentialFillMessage.size === message.size) {
+                            matchingMakerFill = potentialFillMessage;
+                            break;
+                        }
+                    }
                     const makerFillOrderId = matchingMakerFill !== undefined ? matchingMakerFill.orderId : undefined;
@@ -236,0 +244,0 @@ const makerFillAccount = matchingMakerFill !== undefined ? matchingMakerFill.account : undefined;

package.json

 {
   "name": "serum-vial",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "engines": {
@@ -5,0 +5,0 @@ "node": ">=15"

src/data_mapper.ts

@@ -334,8 +334,17 @@ import { EVENT_QUEUE_LAYOUT, Market, Orderbook, getLayoutVersion } from '@project-serum/serum'
         if (message.type === 'fill' && message.maker === false) {
-          // this is rather fragile way of finding matching fill, can it be done better?
+          let matchingMakerFill
 
-          const matchingMakerFill = l3Diff.find(
-            (m) => m.type === 'fill' && m.maker === true && m.size === message.size
-          ) as Fill | undefined
+          for (let j = i - 1; j >= 0; j--) {
+            const potentialFillMessage = l3Diff[j]!
 
+            if (
+              potentialFillMessage.type === 'fill' &&
+              potentialFillMessage.maker === true &&
+              potentialFillMessage.size === message.size
+            ) {
+              matchingMakerFill = potentialFillMessage
+              break
+            }
+          }
+
           const makerFillOrderId = matchingMakerFill !== undefined ? matchingMakerFill.orderId : undefined
@@ -342,0 +351,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

306267

increased by0.2%

Lines of code

4520

increased by0.36%

No dependency changes