serverless-api-gateway-caching - npm Package Compare versions

Comparing version 1.8.0 to 1.8.1-rc1

.vscode/launch.json

@@ -0,0 +0,0 @@ {

package.json

 {
   "name": "serverless-api-gateway-caching",
-  "version": "1.8.0",
+  "version": "1.8.1-rc1",
   "description": "A plugin for the serverless framework which helps with configuring caching for API Gateway endpoints.",
@@ -5,0 +5,0 @@ "main": "src/apiGatewayCachingPlugin.js",

README.md

@@ -0,0 +0,0 @@ # serverless-api-gateway-caching

src/apiGatewayCachingPlugin.js

@@ -0,0 +0,0 @@ 'use strict';

src/ApiGatewayCachingSettings.js

@@ -0,0 +0,0 @@ const get = require('lodash.get');

src/pathParametersCache.js

@@ -33,8 +33,6 @@ const getResourcesByName = (name, serverless) => {
 
-        // in v1.8.0 "lambda" integration check was removed because setting cache key parameters seemed to work for both AWS_PROXY and AWS (lambda) integration
-        // reconsider if this becomes an issue
-
-        // if (method.Properties.Integration.Type !== 'AWS_PROXY') {
+        // without this check, endpoints 500 when using cache key parameters like "Authorization" or headers with the same characters in different casing (e.g. "origin" and "Origin")
+        if (method.Properties.Integration.Type !== 'AWS_PROXY') {
           method.Properties.Integration.RequestParameters[`integration.${cacheKeyParameter.name}`] = `method.${cacheKeyParameter.name}`;
-        // }
+        }
 
@@ -51,4 +49,8 @@ method.Properties.Integration.CacheKeyParameters.push(`method.${cacheKeyParameter.name}`);
         }
+
+        // in v1.8.0 "lambda" integration check was removed because setting cache key parameters seemed to work for both AWS_PROXY and AWS (lambda) integration
+        // reconsider if this becomes an issue
+
         // if (method.Properties.Integration.Type !== 'AWS_PROXY') {
-          method.Properties.Integration.RequestParameters[cacheKeyParameter.name] = cacheKeyParameter.mappedFrom;
+        method.Properties.Integration.RequestParameters[cacheKeyParameter.name] = cacheKeyParameter.mappedFrom;
         // }
@@ -55,0 +57,0 @@ method.Properties.Integration.CacheKeyParameters.push(cacheKeyParameter.name)

src/restApiId.js

@@ -0,0 +0,0 @@ 'use strict';

src/stageCache.js

@@ -0,0 +0,0 @@ const isEmpty = require('lodash.isempty');

src/UnauthorizedCacheControlHeaderStrategy.js

@@ -0,0 +0,0 @@ module.exports = {

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

42774

increased by3.53%

Lines of code

622

increased by0.16%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes