sheet-router - npm Package Compare versions

Comparing version 2.0.3 to 2.0.4

href.js

@@ -7,6 +7,8 @@ const window = require('global/window')
 // handle a click if is anchor tag with an href
-// and url lives on the same domain
+// and url lives on the same domain. Replaces
+// trailing '#' so empty links work as expected.
 // fn(str) -> null
 function history (cb) {
   assert.equal(typeof cb, 'function', 'cb must be a function')
+
   window.onclick = function (e) {
@@ -16,6 +18,7 @@ if (e.target.localName !== 'a') return
     if (window.location.host !== e.target.host) return
+    const href = e.target.href.replace(/#$/, '')
     e.preventDefault()
-    cb(e.target.href)
-    window.history.pushState({}, null, e.target.href)
+    cb(href)
+    window.history.pushState({}, null, href)
   }
 }

package.json

 {
   "name": "sheet-router",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "description": "Fast, modular client router",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -114,2 +114,4 @@ # sheet-router [![stability][0]][1]
 ```
+It is good practice to represent JS actions as `<a href="#">`, as a good
+number of components in the wild expect `<a>` tags to have an `href` value.
 
@@ -116,0 +118,0 @@ ### virtual-dom example

No alert changes

Improved metrics

Total package byte prevSize

16085

increased by1.51%

Lines of code

270

increased by0.75%

Number of lines in readme file

216

increased by0.93%

No dependency changes