single-spa - npm Package Compare versions

Comparing version 2.1.2 to 2.1.3

lib/single-spa.js

@@ -251,10 +251,6 @@ 'use strict';
 
-	var anchorElement = document.createElement('a');
-	anchorElement.setAttribute('href', url);
+	var href = window.location.href;
 
-	// MS Edge does not put an `origin` property on anchor elements :(
-	var anchorOrigin = anchorElement.origin || anchorElement.protocol + "//" + anchorElement.hostname + (anchorElement.port ? ':' + anchorElement.port : '');
-
-	if (window.location.origin + window.location.pathname === anchorOrigin + anchorElement.pathname) {
-		window.location.hash = anchorElement.hash;
+	if (url.indexOf('#') > -1 && href.substring(0, href.indexOf('#')) === url.substring(0, url.indexOf('#'))) {
+		window.location.hash = url.substring(url.indexOf('#'));
 	} else {
@@ -531,13 +527,13 @@ window.history.pushState(null, null, url);
 				} else if (!errored) {
-						(function () {
-							var numWarnings = shouldError;
-							var numMillis = numWarnings * warningPeriod;
-							console.warn(description + ' did not resolve or reject within ' + numMillis + ' milliseconds');
-							if (numMillis + warningPeriod < timeoutConfig.millis) {
-								setTimeout(function () {
-									return maybeTimingOut(numWarnings + 1);
-								}, warningPeriod);
-							}
-						})();
-					}
+					(function () {
+						var numWarnings = shouldError;
+						var numMillis = numWarnings * warningPeriod;
+						console.warn(description + ' did not resolve or reject within ' + numMillis + ' milliseconds');
+						if (numMillis + warningPeriod < timeoutConfig.millis) {
+							setTimeout(function () {
+								return maybeTimingOut(numWarnings + 1);
+							}, warningPeriod);
+						}
+					})();
+				}
 			}
@@ -544,0 +540,0 @@ }

package.json

 {
   "name": "single-spa",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "Multiple applications, one page",
@@ -5,0 +5,0 @@ "main": "lib/single-spa.js",

src/single-spa.js

@@ -207,10 +207,6 @@ import { handleChildAppError } from './single-spa-child-app-error.js';
 
-	const anchorElement= document.createElement('a');
-	anchorElement.setAttribute('href', url);
+	const href = window.location.href;
 
-	// MS Edge does not put an `origin` property on anchor elements :(
-	const anchorOrigin = anchorElement.origin || anchorElement.protocol + "//" + anchorElement.hostname + (anchorElement.port ? ':' + anchorElement.port : '');
-
-	if (window.location.origin + window.location.pathname === anchorOrigin + anchorElement.pathname) {
-		window.location.hash = anchorElement.hash;
+	if (url.indexOf('#') > -1 && href.substring(0, href.indexOf('#')) === url.substring(0, url.indexOf('#'))) {
+		window.location.hash = url.substring(url.indexOf('#'));
 	} else {
@@ -217,0 +213,0 @@ window.history.pushState(null, null, url);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

60685

decreased by-0.87%

Lines of code

1085

decreased by-0.55%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes