slickgrid - npm Package Compare versions

Comparing version 2.4.16 to 2.4.17

controls/slick.columnpicker.js

@@ -82,3 +82,3 @@ /***
       $(document.body).off("mousedown", handleBodyMouseDown);
-      $("div.slick-columnpicker").hide(_options.fadeSpeed);
+      $("div.slick-columnpicker").hide(_options && _options.columnPicker && _options.columnPicker.fadeSpeed);
       $menu.remove();
@@ -89,7 +89,7 @@ }
       if (($menu && $menu[0] != e.target && !$.contains($menu[0], e.target)) || e.target.className == "close") {
-        $menu.hide(_options.fadeSpeed);
+        $menu.hide(_options && _options.columnPicker && _options.columnPicker.fadeSpeed);
       }
     }
 
-    function handleHeaderContextMenu(e, args) {
+    function handleHeaderContextMenu(e) {
       e.preventDefault();
@@ -152,3 +152,3 @@ $list.empty();
         .css("max-height", $(window).height() - e.pageY - 10)
-        .fadeIn(_options.fadeSpeed);
+        .fadeIn(_options && _options.columnPicker && _options.columnPicker.fadeSpeed);
 
@@ -155,0 +155,0 @@ $list.appendTo($menu);

controls/slick.gridmenu.js

@@ -117,3 +117,2 @@ /***
     var _self = this;
-    var _visibleColumns = columns;
     var $customTitleElm;
@@ -224,3 +223,3 @@ var $columnTitleElm;
           "columns": columns,
-          "visibleColumns": _visibleColumns
+          "visibleColumns": getVisibleColumns()
         };
@@ -316,3 +315,3 @@
         "allColumns": columns,
-        "visibleColumns": _visibleColumns
+        "visibleColumns": getVisibleColumns()
       };
@@ -414,3 +413,3 @@
           "allColumns": columns,
-          "visibleColumns": _visibleColumns
+          "visibleColumns": getVisibleColumns()
         };
@@ -439,3 +438,3 @@ _self.onCommand.notify(callbackArgs, e, _self);
           "allColumns": columns,
-          "visibleColumns": _visibleColumns
+          "visibleColumns": getVisibleColumns()
         };
@@ -518,3 +517,2 @@ if (_self.onMenuClose.notify(callbackArgs, e, _self) == false) {
         };
-        _visibleColumns = visibleColumns;
         _grid.setColumns(visibleColumns);
@@ -531,4 +529,5 @@ _self.onColumnsChanged.notify(callbackArgs, e, _self);
 
+    /** visible columns, we can simply get them directly from the grid */
     function getVisibleColumns() {
-      return _visibleColumns;
+      return _grid.getColumns();
     }
@@ -535,0 +534,0 @@

lib/jquery.event.drag-2.3.0.js

@@ -115,5 +115,8 @@ /*!
                     return;
-                // check for suppressed selector
-                if ( $( event.target ).is( dd.not ) )
+                // check for suppressed selector and/or
+                // make sure the target css class starts with "slick" so that we know we are in a Slick Grid
+                var targetClass = $( event.target ).attr('class') || "";                
+                if ( $( event.target ).is( dd.not ) || (!targetClass || targetClass.toString().indexOf('slick') === -1))
                     return;
+                
                 // check for handle selector
@@ -120,0 +123,0 @@ if ( dd.handle && !$( event.target ).closest( dd.handle, event.currentTarget ).length )

package.json

 {
   "name": "slickgrid",
-  "version": "2.4.16",
+  "version": "2.4.17",
   "description": "A lightning fast JavaScript grid/spreadsheet",
@@ -5,0 +5,0 @@ "main": "slick.core.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4401863

increased by0.01%

Worsened metrics

Lines of code

97023

No dependency changes