specberus - npm Package Compare versions

Comparing version 3.4.3 to 3.5.0

lib/l10n-en_GB.js

@@ -79,3 +79,3 @@ exports.messages = {
 ,   "headers.copyright.not-found":          "Missing copyright paragraph."
-,   'headers.memsub-copyright.not-found': 'Missing link to the W3C document notice.'
+,   'headers.memsub-copyright.not-found': 'Missing link to the W3C document notice (https://www.w3.org/Consortium/Legal/copyright-documents).'
     // links/internal
@@ -124,4 +124,4 @@ ,   "links.internal.anchor":    "Link to missing anchor: '${id}'."
 ,   "sotd.pp.expected-pp":       "Expected text related to patent policy requirements: <blockquote>${expected}</blockquote>"
-,   "sotd.pp.deprecated":        "The patent policy (${policy}) you are using is no longer allowed."
-,   "sotd.pp.deprecatedAllowed": "The patent policy (${policy}) you are using is deprecated."
+,   "sotd.pp.deprecated":        "The patent policy link (${policy}) you are using is no longer allowed. Please use the undated link <code>https://www.w3.org/Consortium/Patent-Policy/</code>."
+,   "sotd.pp.deprecatedAllowed": "The patent policy (${policy}) you are using is deprecated. Please use the undated link <code>https://www.w3.org/Consortium/Patent-Policy/</code>."
     // sotd/charter-disclosure
@@ -142,2 +142,3 @@ ,   "sotd.charter-disclosure.not-found":    "No link to charter for disclosure obligations found."
 ,   "sotd.process-document.deprecated":        "The process document (${process}) you are using is no longer allowed."
+,   "sotd.process-document.deprecatedAllowed": "The process document (${process}) you are using is deprecated."
 ,   "sotd.process-document.multiple-times":    "The governing process statement has been found multiple times."
@@ -230,3 +231,3 @@ ,   "sotd.process-document.not-found":         "The document must mention the governing process: ${process}"
 ,   'metadata.informative':       false
-,   'metadata.process.not-found': 'Missing, or wrong, boilerplate text in the status section to identify the governing process.'
+,   'metadata.process':           false
 ,   'metadata.profile':           false
@@ -233,0 +234,0 @@ ,   'metadata.rectrack':          false

lib/rules/headers/memsub-copyright.js

@@ -13,3 +13,3 @@ const self = {
             var $a = sr.$(this);
-            if ($a.attr("href").indexOf("http://www.w3.org/Consortium/Legal/copyright-documents") === 0) {
+            if ($a.attr("href").indexOf("https://www.w3.org/Consortium/Legal/copyright-documents") === 0) {
                 seen = true;
@@ -19,2 +19,3 @@ return false;
         });
+        if (!seen) sr.error(self, "not-found");
     }
@@ -21,0 +22,0 @@ else sr.error(self, "not-found");

lib/rules/metadata/process.js

@@ -5,7 +5,7 @@ /**
 
-const self = {
-    name: 'metadata.process'
-,   section: 'document-status'
-,   rule: 'whichProcess'
-};
+// const self = {
+//     name: 'metadata.process'
+// ,   section: 'document-status'
+// ,   rule: 'whichProcess'
+// };
 
@@ -15,3 +15,2 @@ exports.check = function(sr, done) {
     if (!$processDocument || !$processDocument.attr('href')) {
-        sr.error(self, 'not-found');
         return done();
@@ -18,0 +17,0 @@ }

lib/rules/sotd/process-document.js

@@ -43,3 +43,3 @@ const self = {
                 if (deprecatedAllowed) {
-                    sr.warning(self, 'deprecated', { process: proc });
+                    sr.warning(self, 'deprecatedAllowed', { process: proc });
                     found = true;
@@ -46,0 +46,0 @@ }

lib/rules/sotd/submission.js

@@ -0,1 +1,7 @@
+const self = {
+    name: 'sotd.submission'
+,   section: 'document-status'
+,   rule: 'boilerplateSUBM'
+};
+
 function findSubmText ($candidates, sr) {
@@ -26,6 +32,2 @@ var $st = null;
 
-const self = {
-    name: 'sotd.submission'
-};
-
 exports.check = function (sr, done) {
@@ -41,23 +43,51 @@ var $sotd = sr.getSotDSection();
         // check the links
-        var links = {
-            "http://www.w3.org/Consortium/Process":             "W3C Process"
-        ,   "http://www.w3.org/Consortium/Prospectus/Joining":  "W3C Membership"
-        ,   "http://www.w3.org/Consortium/Patent-Policy-20030520.html#sec-submissions":  "section 3.3 of the W3C Patent Policy"
-        ,   "http://www.w3.org/Submission":  "list of acknowledged W3C Member Submissions"
-        };
-        for (var href in links) {
-            if (!$st.find("a[href='" + href + "']:contains('" + links[href] + "')").length)
-                sr.error(self, "link-text", { href: href, text: links[href] });
-        }
-        var $sm = $st.find("a:contains('Submitting Members')")
-        ,   $tc = $st.find("a:contains('W3C Team Comment')")
+        var w3cProcess = "https://www.w3.org/Consortium/Process"
+        ,   w3cMembership = "https://www.w3.org/Consortium/Prospectus/Joining"
+        ,   w3cPP = "https://www.w3.org/Consortium/Patent-Policy-20030520.html#sec-submissions"
+        ,   w3cSubm = "https://www.w3.org/Submission"
+        ,   foundW3Cprocess = false
+        ,   foundW3Cmembership = false
+        ,   foundPP = false
+        ,   foundSubm = false
+        ,   foundSubmMembers = false
+        ,   foundComment = false
         ;
-        if (!$sm.length || !$sm.attr("href") ||
-            $sm.attr("href").indexOf("http://www.w3.org/Submission/") !== 0)
-                sr.error(self, "no-sm-link");
-        if (!$tc.length || !$tc.attr("href") ||
-            $tc.attr("href").indexOf("http://www.w3.org/Submission/") !== 0)
-                sr.error(self, "no-tc-link");
+        $st.find("a[href]").each(function () {
+            var $a = sr.$(this)
+            ,   href = $a.attr("href")
+            ,   text = sr.norm($a.text())
+            ;
+            if (href === w3cProcess && text === "W3C Process") {
+                foundW3Cprocess = true;
+                return;
+            }
+            if (href === w3cMembership && text === "W3C Membership") {
+                foundW3Cmembership = true;
+                return;
+            }
+            if (href === w3cPP && text === "section 3.3 of the W3C Patent Policy") {
+                foundPP = true;
+                return;
+            }
+            if (href === w3cSubm && text === "list of acknowledged W3C Member Submissions") {
+                foundSubm = true;
+                return;
+            }
+            if (href.indexOf(w3cSubm + '/') !== 0 && text === "Submitting Members") {
+                foundSubmMembers = true;
+                return;
+            }
+            if (href.indexOf(w3cSubm + '/') !== 0 && text === "W3C Team Comment") {
+                foundComment = true;
+                return;
+            }
+        });
+        if (!foundW3Cprocess) sr.error(self, "link-text", { href: w3cProcess, text: "W3C Process" });
+        if (!foundW3Cmembership) sr.error(self, "link-text", { href: w3cMembership, text: "W3C Membership" });
+        if (!foundPP) sr.error(self, "link-text", { href: w3cPP, text: "section 3.3 of the W3C Patent Policy" });
+        if (!foundSubm) sr.error(self, "link-text", { href: w3cSubm, text: "list of acknowledged W3C Member Submissions" });
+        if (!foundSubmMembers) sr.error(self, "no-sm-link");
+        if (!foundComment) sr.error(self, "no-tc-link");
     }
     done();
 };

lib/rules/sotd/supersedable.js

@@ -22,4 +22,5 @@ // SotD
                      "publication. Other documents may supersede this document. A list of current " +
-                     "W3C publications and the latest revision of this technical report can be found " +
-                     "in the W3C technical reports index at https://www.w3.org/TR/."
+                     "W3C publications " +
+                     ((sr.config.status === "SUBM") ? "" : "and the latest revision of this technical report ") +
+                     "can be found in the W3C technical reports index at https://www.w3.org/TR/."
         ,   $a = $em.find("a[href='https://www.w3.org/TR/']")
@@ -26,0 +27,0 @@ ;

package.json

 {
   "name": "specberus",
-  "version": "3.4.3",
+  "version": "3.5.0",
   "description": "Specberus is a checker used at W3C to validate the compliance of Technical Reports with publication rules.",
@@ -21,3 +21,3 @@ "license": "MIT",
     "socket.io": "2.0.4",
-    "superagent": "3.8.1",
+    "superagent": "3.8.2",
     "whacko": "0.19"
@@ -24,0 +24,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2123326

increased by188.5%

Number of package files

229

increased by55.78%

Lines of code

7691

increased by19.37%

Worsened metrics

Number of low supply chain risk alerts

22

increased by15.79%

Number of medium supply chain risk alerts

9

increased by12.5%

Dependency changes

• + Addedsuperagent@3.8.2(transitive)

• - Removedsuperagent@3.8.1(transitive)

• Updatedsuperagent@3.8.2