sql-ddl-sync - npm Package Compare versions

Comparing version 0.1.3 to 0.1.4

lib/Dialects/mysql.js

@@ -132,2 +132,8 @@ var SQL  = require("../SQL");
 
+exports.dropCollection = function (db, name, cb) {
+	return db.query(SQL.DROP_TABLE({
+		name    : name
+	}, exports), cb);
+};
+
 exports.addCollectionColumn = function (db, name, column, after_column, cb) {
@@ -134,0 +140,0 @@ return db.query(SQL.ALTER_TABLE_ADD_COLUMN({

lib/Dialects/postgresql.js

@@ -106,2 +106,8 @@ var util        = require("util");
 
+exports.dropCollection = function (db, name, cb) {
+	return db.query(SQL.DROP_TABLE({
+		name    : name
+	}, exports), cb);
+};
+
 exports.addCollectionColumn = function (db, name, column, after_column, cb) {
@@ -108,0 +114,0 @@ var sql = "ALTER TABLE " + exports.escapeId(name) + " ADD " + column;

lib/Dialects/sqlite.js

@@ -80,2 +80,8 @@ var Queue = require("../Queue").Queue;
 
+exports.dropCollection = function (db, name, cb) {
+	return db.query(SQL.DROP_TABLE({
+		name    : name
+	}, exports), cb);
+};
+
 exports.addCollectionColumn = function (db, name, column, after_column, cb) {
@@ -112,2 +118,6 @@ return db.all(SQL.ALTER_TABLE_ADD_COLUMN({
 		for (var k in indexes) {
+			if (k.match(/^sqlite_autoindex/)) {
+				delete indexes[k];
+				continue;
+			}
 			queue.add(k, function (k, next) {
@@ -140,11 +150,11 @@ db.all("PRAGMA index_info(" + exports.escapeVal(k) + ")", function (err, rows) {
 exports.removeIndex = function (db, name, collection, cb) {
-	return db.all(SQL.DROP_INDEX({
-		name       : name,
-		collection : collection
-	}, exports), cb);
+	return db.all("DROP INDEX IF EXISTS " + exports.escapeId(name), cb);
 };
 
 exports.checkPrimary = function (primary) {
-	// primary keys should be in the property
-	return [];
+	if (primary.length === 1) {
+		return [];
+	}
+
+	return primary;
 };
@@ -208,3 +218,5 @@
 		}
-		type += " PRIMARY KEY";
+		if (property.serial) {
+			type += " PRIMARY KEY";
+		}
 	}
@@ -211,0 +223,0 @@ if (property.serial) {

lib/SQL.js

@@ -15,2 +15,8 @@ exports.CREATE_TABLE = function (options, dialect) {
 
+exports.DROP_TABLE = function (options, dialect) {
+	var sql = "DROP TABLE " + dialect.escapeId(options.name);
+
+	return sql;
+};
+
 exports.ALTER_TABLE_ADD_COLUMN = function (options, dialect) {
@@ -17,0 +23,0 @@ var sql = "ALTER TABLE " + dialect.escapeId(options.name) +

lib/Sync.js

@@ -311,2 +311,5 @@ var Queue = require("./Queue").Queue;
 	var needToSync = function (property, column) {
+		if (property.serial && property.type == "number") {
+			property.type = "serial";
+		}
 		if (property.type != column.type) {
@@ -313,0 +316,0 @@ if (typeof Dialect.supportsType != "function") {

package.json

@@ -6,3 +6,3 @@ {
 	"keywords"        : [ "sql", "ddl", "sync", "mysql", "postgres", "sqlite" ],
-	"version"         : "0.1.3",
+	"version"         : "0.1.4",
 	"license"         : "MIT",
@@ -15,3 +15,3 @@ "repository"      : "http://github.com/dresende/node-sql-ddl-sync.git",
 	"dependencies"    : {
-		"lodash"        : "2.2.1"
+		"lodash"        : "2.4.1"
 	},
@@ -18,0 +18,0 @@ "devDependencies" : {

README.md

@@ -43,3 +43,3 @@ ## NodeJS SQL DDL Synchronization
 
-sync.define("ddl_sync_test", {
+sync.defineCollection("ddl_sync_test", {
 	id     : { type : "number", primary: true, serial: true },
@@ -46,0 +46,0 @@ name   : { type : "text", required: true },

test/integration/sql.js

@@ -32,2 +32,13 @@ var common  = require("../common");
 
+describe("SQL.DROP_TABLE", function () {
+	it("should return a DROP TABLE", function (done) {
+		SQL.DROP_TABLE({
+			name    : "fake_table"
+		}, Dialect).should.equal("DROP TABLE $$fake_table$$");
+
+		return done();
+	});
+});
+
+
 describe("SQL.ALTER_TABLE_ADD_COLUMN", function () {
@@ -34,0 +45,0 @@ it("should return an ALTER TABLE", function (done) {

No alert changes

Improved metrics

Lines of code

2013

increased by1.77%

Worsened metrics

Total package byte prevSize

65101

decreased by-14.87%

Number of package files

20

decreased by-4.76%

Dependency changes

• + Addedlodash@2.4.1(transitive)

• - Removedlodash@2.2.1(transitive)

• Updatedlodash@2.4.1