stump-cycle-dom - npm Package Compare versions

Comparing version 0.0.12 to 0.0.13

lib/cjs/EventDelegator.js

@@ -21,2 +21,3 @@ "use strict";
 var PriorityQueue_1 = require("./PriorityQueue");
+var whenComplete_1 = require("./whenComplete");
 var fromEvent_1 = require("./fromEvent");
@@ -113,14 +114,6 @@ var non_bubbling_id = 0;
                 var input_1;
-                var new_subject_1 = xstream_1.default.never();
-                var listener_1 = {
-                    next: function (x) { return subject.shamefullySendNext(x); },
-                    error: function (e) { return subject.shamefullySendError(e); },
-                    complete: function () {
-                        subject.shamefullySendComplete();
-                        self_1.nonBubblingListenersToAdd.delete(input_1);
-                        new_subject_1.removeListener(listener_1);
-                    }
-                };
-                new_subject_1.addListener(listener_1);
-                dest = this.insertListener(new_subject_1, scopeChecker, eventType, options);
+                subject = subject.compose(whenComplete_1.default(function () {
+                    self_1.nonBubblingListenersToAdd.delete(input_1);
+                }));
+                dest = this.insertListener(subject, scopeChecker, eventType, options);
                 input_1 = [subject, eventType, finder, dest];
@@ -131,3 +124,3 @@ this.setupNonBubblingListener(input_1);
             else {
-                var sub = found[0], _ = found[1];
+                var sub = found[0];
                 return sub;
@@ -134,0 +127,0 @@ }

lib/es6/EventDelegator.js

@@ -19,2 +19,3 @@ var __assign = (this && this.__assign) || function () {
 import PriorityQueue from './PriorityQueue';
+import whenComplete from './whenComplete';
 import { fromEvent, preventDefaultConditional, } from './fromEvent';
@@ -111,14 +112,6 @@ var non_bubbling_id = 0;
                 var input_1;
-                var new_subject_1 = xs.never();
-                var listener_1 = {
-                    next: function (x) { return subject.shamefullySendNext(x); },
-                    error: function (e) { return subject.shamefullySendError(e); },
-                    complete: function () {
-                        subject.shamefullySendComplete();
-                        self_1.nonBubblingListenersToAdd.delete(input_1);
-                        new_subject_1.removeListener(listener_1);
-                    }
-                };
-                new_subject_1.addListener(listener_1);
-                dest = this.insertListener(new_subject_1, scopeChecker, eventType, options);
+                subject = subject.compose(whenComplete(function () {
+                    self_1.nonBubblingListenersToAdd.delete(input_1);
+                }));
+                dest = this.insertListener(subject, scopeChecker, eventType, options);
                 input_1 = [subject, eventType, finder, dest];
@@ -129,3 +122,3 @@ this.setupNonBubblingListener(input_1);
             else {
-                var sub = found[0], _ = found[1];
+                var sub = found[0];
                 return sub;
@@ -132,0 +125,0 @@ }

package.json

 {
   "name": "stump-cycle-dom",
-  "version": "0.0.12",
+  "version": "0.0.13",
   "description": "The standard DOM Driver for Cycle.js, based on Snabbdom",
@@ -5,0 +5,0 @@ "license": "MIT",

src/EventDelegator.ts

@@ -11,2 +11,3 @@ import xs, {Stream, Subscription} from 'xstream';
 import PriorityQueue from './PriorityQueue';
+import whenComplete from './whenComplete'
 import {
@@ -161,16 +162,7 @@ fromEvent,
         let input: any
-        const new_subject = xs.never()
-        const listener = {
-          next: (x: any) => subject.shamefullySendNext(x),
-          error: (e: any) => subject.shamefullySendError(e),
-          complete: () => {
-            subject.shamefullySendComplete()
-            self.nonBubblingListenersToAdd.delete(input);
-            new_subject.removeListener(listener)
-          }
-        }
-  
-        new_subject.addListener(listener)
-  
-        dest = this.insertListener(new_subject, scopeChecker, eventType, options);
+        subject = subject.compose(whenComplete(() => { 
+          self.nonBubblingListenersToAdd.delete(input); 
+        }))
+
+        dest = this.insertListener(subject, scopeChecker, eventType, options);
         input = [subject, eventType, finder, dest];
@@ -182,3 +174,3 @@
       } else {
-        const [sub, _] = found
+        const [sub] = found
         return sub
@@ -185,0 +177,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

538422

increased by1.47%

Number of package files

183

increased by3.98%

Lines of code

12189

increased by2.45%

No dependency changes