terra-form-fieldset - npm Package Compare versions

Comparing version 2.67.0 to 2.68.0

CHANGELOG.md

@@ -5,2 +5,10 @@ # Changelog
 
+## 2.68.0 - (February 15, 2023)
+
+* Changed
+  * Updated wdio screenshots due to functional-testing upgrade.
+
+* Updated
+  * Fixed jest test failures caused by empty children nodes.
+
 ## 2.67.0 - (February 7, 2023)
@@ -7,0 +15,0 @@

lib/Fieldset.js

@@ -90,3 +90,3 @@ "use strict";
     className: cx('fieldset-children')
-  }, addAriaHelpers(children)));
+  }, (help || legend) && children ? addAriaHelpers(children) : children));
 };
@@ -93,0 +93,0 @@ Fieldset.propTypes = propTypes;

package.json

 {
   "name": "terra-form-fieldset",
   "main": "lib/Fieldset.js",
-  "version": "2.67.0",
+  "version": "2.68.0",
   "description": "Generic form fieldset component which handles the layout of a standard form fieldset including help text, legend, value and widget placement.",
@@ -31,4 +31,4 @@ "repository": {
     "prop-types": "^15.5.8",
-    "terra-form-field": "^4.23.0",
-    "terra-form-input": "^4.20.0",
+    "terra-form-field": "^4.24.0",
+    "terra-form-input": "^4.21.0",
     "terra-theme-context": "^1.0.0",
@@ -50,3 +50,3 @@ "uuid": "^3.3.2"
   },
-  "gitHead": "5baec333cd23f0e17bbd3ced48e1dbf74ba6cc9e"
+  "gitHead": "632d9cecc4c480d250ddef2ee6999349eda97641"
 }

src/Fieldset.jsx

@@ -81,3 +81,3 @@ /* eslint-disable react/jsx-boolean-value, jsx-a11y/label-has-for */
       <div className={cx('fieldset-children')}>
-        {addAriaHelpers(children)}
+        {(help || legend) && children ? addAriaHelpers(children) : children}
       </div>
@@ -84,0 +84,0 @@ </fieldset>

tests/jest/FormFieldset.test.jsx

@@ -32,2 +32,17 @@ /* eslint-disable react/jsx-boolean-value */
 
+it('should render a Fieldset without legend and helptext', () => {
+  const input = (
+    <Fieldset
+      className="fieldset-custom"
+      legendAttrs={{ className: 'healtheintent-legend' }}
+      required
+    >
+      <input type="radio" value="Test" />
+    </Fieldset>
+  );
+
+  const wrapper = shallow(input);
+  expect(wrapper).toMatchSnapshot();
+});
+
 it('correctly applies the theme context className', () => {
@@ -34,0 +49,0 @@ const wrapper = mount(

tests/wdio/fieldset-spec.js

@@ -13,2 +13,8 @@ Terra.describeViewports('Fieldset', ['tiny', 'medium'], () => {
   });
+
+  it('should display populated Fieldset without legend and helptext', () => {
+    browser.url('/raw/tests/cerner-terra-core-docs/form-fieldset/fieldset-without-legend-and-helptext');
+
+    Terra.validates.accessibility();
+  });
 });

No alert changes

Improved metrics

Total package byte prevSize

38860

increased by2.22%

Lines of code

236

increased by7.76%

Dependency changes

• Updatedterra-form-field@^4.24.0

• Updatedterra-form-input@^4.21.0