terra-popup - npm Package Compare versions

Comparing version 6.42.0 to 6.43.0

CHANGELOG.md

@@ -5,2 +5,7 @@ # Changelog
 
+## 6.43.0 - (November 10, 2020)
+
+* Fixed
+  * Fixed build failures due to the react/sort-comp rule
+
 ## 6.42.0 - (October 20, 2020)
@@ -7,0 +12,0 @@

lib/Popup.js

@@ -190,27 +190,2 @@ "use strict";
   }, {
-    key: "setArrowPosition",
-    value: function setArrowPosition(contentPosition, targetPosition) {
-      var arrowPosition = _PopupUtils.default.getArrowPosition(contentPosition, targetPosition, _PopupArrow.default.Opts.arrowSize, _PopupContent.cornerSize);
-
-      if (!arrowPosition) {
-        this.arrowNode.removeAttribute(_PopupArrow.default.Opts.positionAttr);
-        return;
-      }
-
-      this.arrowNode.setAttribute(_PopupArrow.default.Opts.positionAttr, arrowPosition);
-
-      if (arrowPosition === 'top' || arrowPosition === 'bottom') {
-        this.arrowNode.style.left = _PopupUtils.default.leftOffset(contentPosition, targetPosition, _PopupArrow.default.Opts.arrowSize, _PopupContent.cornerSize);
-        this.arrowNode.style.top = '';
-      } else {
-        this.arrowNode.style.left = '';
-        this.arrowNode.style.top = _PopupUtils.default.topOffset(contentPosition, targetPosition, _PopupArrow.default.Opts.arrowSize, _PopupContent.cornerSize);
-      }
-    }
-  }, {
-    key: "setArrowNode",
-    value: function setArrowNode(node) {
-      this.arrowNode = node;
-    }
-  }, {
     key: "handleOnPosition",
@@ -245,2 +220,27 @@ value: function handleOnPosition(event, positions) {
   }, {
+    key: "setArrowPosition",
+    value: function setArrowPosition(contentPosition, targetPosition) {
+      var arrowPosition = _PopupUtils.default.getArrowPosition(contentPosition, targetPosition, _PopupArrow.default.Opts.arrowSize, _PopupContent.cornerSize);
+
+      if (!arrowPosition) {
+        this.arrowNode.removeAttribute(_PopupArrow.default.Opts.positionAttr);
+        return;
+      }
+
+      this.arrowNode.setAttribute(_PopupArrow.default.Opts.positionAttr, arrowPosition);
+
+      if (arrowPosition === 'top' || arrowPosition === 'bottom') {
+        this.arrowNode.style.left = _PopupUtils.default.leftOffset(contentPosition, targetPosition, _PopupArrow.default.Opts.arrowSize, _PopupContent.cornerSize);
+        this.arrowNode.style.top = '';
+      } else {
+        this.arrowNode.style.left = '';
+        this.arrowNode.style.top = _PopupUtils.default.topOffset(contentPosition, targetPosition, _PopupArrow.default.Opts.arrowSize, _PopupContent.cornerSize);
+      }
+    }
+  }, {
+    key: "setArrowNode",
+    value: function setArrowNode(node) {
+      this.arrowNode = node;
+    }
+  }, {
     key: "validateContentNode",
@@ -247,0 +247,0 @@ value: function validateContentNode(node) {

lib/terra-dev-site/test/popup/ArrowHorizontalAttachmentsPopup.test.js

@@ -61,22 +61,2 @@ "use strict";
   (0, _createClass2.default)(AlignmentPopup, [{
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
-    key: "setParentNode",
-    value: function setParentNode(node) {
-      this.parentNode = node;
-    }
-  }, {
-    key: "getParentNode",
-    value: function getParentNode() {
-      return this.parentNode;
-    }
-  }, {
     key: "handleAttachment",
@@ -104,2 +84,22 @@ value: function handleAttachment(event) {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
+    key: "setParentNode",
+    value: function setParentNode(node) {
+      this.parentNode = node;
+    }
+  }, {
+    key: "getParentNode",
+    value: function getParentNode() {
+      return this.parentNode;
+    }
+  }, {
     key: "render",
@@ -106,0 +106,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ArrowPopup.test.js

@@ -62,12 +62,2 @@ "use strict";
   }, {
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
     key: "handleButtonClick",
@@ -87,2 +77,12 @@ value: function handleButtonClick() {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
     key: "render",
@@ -89,0 +89,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ArrowSmallTargetLeftPopup.test.js

@@ -65,2 +65,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -86,16 +100,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -102,0 +102,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ArrowSmallTargetRightPopup.test.js

@@ -65,2 +65,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -86,16 +100,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -102,0 +102,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ArrowVerticalAttachmentsPopup.test.js

@@ -61,22 +61,2 @@ "use strict";
   (0, _createClass2.default)(AlignmentPopup, [{
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
-    key: "setParentNode",
-    value: function setParentNode(node) {
-      this.parentNode = node;
-    }
-  }, {
-    key: "getParentNode",
-    value: function getParentNode() {
-      return this.parentNode;
-    }
-  }, {
     key: "handleAttachment",
@@ -104,2 +84,22 @@ value: function handleAttachment(event) {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
+    key: "setParentNode",
+    value: function setParentNode(node) {
+      this.parentNode = node;
+    }
+  }, {
+    key: "getParentNode",
+    value: function getParentNode() {
+      return this.parentNode;
+    }
+  }, {
     key: "render",
@@ -106,0 +106,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ArrowVerticalLeftAdjustmentPopup.test.js

@@ -65,2 +65,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -86,16 +100,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -102,0 +102,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ArrowVerticalRightAdjustmentPopup.test.js

@@ -65,2 +65,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -86,16 +100,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -102,0 +102,0 @@ value: function render() {

lib/terra-dev-site/test/popup/AutomaticHeightBoundedPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/AutomaticHeightPopup.test.js

@@ -62,12 +62,2 @@ "use strict";
   }, {
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
     key: "handleButtonClick",
@@ -87,2 +77,12 @@ value: function handleButtonClick() {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
     key: "render",
@@ -89,0 +89,0 @@ value: function render() {

lib/terra-dev-site/test/popup/AutomaticWidthBoundedPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/AutomaticWidthPopup.test.js

@@ -62,12 +62,2 @@ "use strict";
   }, {
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
     key: "handleButtonClick",
@@ -87,2 +77,12 @@ value: function handleButtonClick() {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
     key: "render",
@@ -89,0 +89,0 @@ value: function render() {

lib/terra-dev-site/test/popup/BoundedHeightPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/BoundedNoHeaderPopup.test.js

@@ -66,2 +66,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -87,16 +101,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -103,0 +103,0 @@ value: function render() {

lib/terra-dev-site/test/popup/BoundedPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/BoundedWidthPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/DefaultPopup.test.js

@@ -62,12 +62,2 @@ "use strict";
   }, {
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
     key: "handleButtonClick",
@@ -87,2 +77,12 @@ value: function handleButtonClick() {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
     key: "render",
@@ -89,0 +89,0 @@ value: function render() {

lib/terra-dev-site/test/popup/DifferentAttachmentsPopup.test.js

@@ -67,22 +67,2 @@ "use strict";
   (0, _createClass2.default)(AlignmentPopup, [{
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
-    key: "setParentNode",
-    value: function setParentNode(node) {
-      this.parentNode = node;
-    }
-  }, {
-    key: "getParentNode",
-    value: function getParentNode() {
-      return this.parentNode;
-    }
-  }, {
     key: "handleAttachment",
@@ -111,2 +91,22 @@ value: function handleAttachment(event) {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
+    key: "setParentNode",
+    value: function setParentNode(node) {
+      this.parentNode = node;
+    }
+  }, {
+    key: "getParentNode",
+    value: function getParentNode() {
+      return this.parentNode;
+    }
+  }, {
     key: "render",
@@ -113,0 +113,0 @@ value: function render() {

lib/terra-dev-site/test/popup/FocusTrapPopup.test.js

@@ -62,12 +62,2 @@ "use strict";
   }, {
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
     key: "handleButtonClick",
@@ -87,2 +77,12 @@ value: function handleButtonClick() {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
     key: "render",
@@ -89,0 +89,0 @@ value: function render() {

lib/terra-dev-site/test/popup/ResizedContentPopup.test.js

@@ -65,12 +65,2 @@ "use strict";
   }, {
-    key: "setButtonNode",
-    value: function setButtonNode(node) {
-      this.buttonNode = node;
-    }
-  }, {
-    key: "getButtonNode",
-    value: function getButtonNode() {
-      return this.buttonNode;
-    }
-  }, {
     key: "handleButtonClick",
@@ -90,2 +80,12 @@ value: function handleButtonClick() {
   }, {
+    key: "setButtonNode",
+    value: function setButtonNode(node) {
+      this.buttonNode = node;
+    }
+  }, {
+    key: "getButtonNode",
+    value: function getButtonNode() {
+      return this.buttonNode;
+    }
+  }, {
     key: "render",
@@ -92,0 +92,0 @@ value: function render() {

lib/terra-dev-site/test/popup/SizeInvalidPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/SizeLargePopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/SizeMediumPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

lib/terra-dev-site/test/popup/SizeSmallPopup.test.js

@@ -64,2 +64,16 @@ "use strict";
   }, {
+    key: "handleButtonClick",
+    value: function handleButtonClick() {
+      this.setState({
+        open: true
+      });
+    }
+  }, {
+    key: "handleRequestClose",
+    value: function handleRequestClose() {
+      this.setState({
+        open: false
+      });
+    }
+  }, {
     key: "setButtonNode",
@@ -85,16 +99,2 @@ value: function setButtonNode(node) {
   }, {
-    key: "handleButtonClick",
-    value: function handleButtonClick() {
-      this.setState({
-        open: true
-      });
-    }
-  }, {
-    key: "handleRequestClose",
-    value: function handleRequestClose() {
-      this.setState({
-        open: false
-      });
-    }
-  }, {
     key: "render",
@@ -101,0 +101,0 @@ value: function render() {

package.json

 {
   "name": "terra-popup",
   "main": "lib/Popup.js",
-  "version": "6.42.0",
+  "version": "6.43.0",
   "description": "The Terra Popup is higher order component that launches terra-hookshot positioned content with the ability to display a dynamic arrow.",
@@ -37,3 +37,3 @@ "repository": {
     "terra-content-container": "^3.0.0",
-    "terra-hookshot": "^5.30.0",
+    "terra-hookshot": "^5.31.0",
     "terra-mixins": "^1.0.0",
@@ -43,4 +43,4 @@ "terra-theme-context": "^1.4.0"
   "devDependencies": {
-    "terra-disclosure-manager": "^4.36.0",
-    "terra-modal-manager": "^6.42.0"
+    "terra-disclosure-manager": "^4.37.0",
+    "terra-modal-manager": "^6.43.0"
   },
@@ -60,3 +60,3 @@ "scripts": {
   },
-  "gitHead": "2585244f485f88093d63e4814f2edb5fb18a35f4"
+  "gitHead": "88d3580c37b3965d3b563623e6a8d4843a913d85"
 }

src/Popup.jsx

@@ -138,23 +138,2 @@ import React from 'react';
 
-  setArrowPosition(contentPosition, targetPosition) {
-    const arrowPosition = PopupUtils.getArrowPosition(contentPosition, targetPosition, PopupArrow.Opts.arrowSize, cornerSize);
-    if (!arrowPosition) {
-      this.arrowNode.removeAttribute(PopupArrow.Opts.positionAttr);
-      return;
-    }
-    this.arrowNode.setAttribute(PopupArrow.Opts.positionAttr, arrowPosition);
-
-    if (arrowPosition === 'top' || arrowPosition === 'bottom') {
-      this.arrowNode.style.left = PopupUtils.leftOffset(contentPosition, targetPosition, PopupArrow.Opts.arrowSize, cornerSize);
-      this.arrowNode.style.top = '';
-    } else {
-      this.arrowNode.style.left = '';
-      this.arrowNode.style.top = PopupUtils.topOffset(contentPosition, targetPosition, PopupArrow.Opts.arrowSize, cornerSize);
-    }
-  }
-
-  setArrowNode(node) {
-    this.arrowNode = node;
-  }
-
   handleOnPosition(event, positions) {
@@ -186,2 +165,23 @@ if (this.arrowNode) {
 
+  setArrowPosition(contentPosition, targetPosition) {
+    const arrowPosition = PopupUtils.getArrowPosition(contentPosition, targetPosition, PopupArrow.Opts.arrowSize, cornerSize);
+    if (!arrowPosition) {
+      this.arrowNode.removeAttribute(PopupArrow.Opts.positionAttr);
+      return;
+    }
+    this.arrowNode.setAttribute(PopupArrow.Opts.positionAttr, arrowPosition);
+
+    if (arrowPosition === 'top' || arrowPosition === 'bottom') {
+      this.arrowNode.style.left = PopupUtils.leftOffset(contentPosition, targetPosition, PopupArrow.Opts.arrowSize, cornerSize);
+      this.arrowNode.style.top = '';
+    } else {
+      this.arrowNode.style.left = '';
+      this.arrowNode.style.top = PopupUtils.topOffset(contentPosition, targetPosition, PopupArrow.Opts.arrowSize, cornerSize);
+    }
+  }
+
+  setArrowNode(node) {
+    this.arrowNode = node;
+  }
+
   validateContentNode(node) {
@@ -188,0 +188,0 @@ if (node) {

src/terra-dev-site/test/popup/ArrowHorizontalAttachmentsPopup.test.jsx

@@ -21,2 +21,14 @@ import React from 'react';
 
+  handleAttachment(event) {
+    this.setState({ attachment: event.target.value, open: true });
+  }
+
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -38,14 +50,2 @@ this.buttonNode = node;
 
-  handleAttachment(event) {
-    this.setState({ attachment: event.target.value, open: true });
-  }
-
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -52,0 +52,0 @@ return (

src/terra-dev-site/test/popup/ArrowPopup.test.jsx

@@ -22,2 +22,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -31,10 +39,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -41,0 +41,0 @@ return (

src/terra-dev-site/test/popup/ArrowSmallTargetLeftPopup.test.jsx

@@ -26,2 +26,10 @@ /* eslint-disable react/jsx-curly-brace-presence */
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -43,10 +51,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -53,0 +53,0 @@ return (

src/terra-dev-site/test/popup/ArrowSmallTargetRightPopup.test.jsx

@@ -26,2 +26,10 @@ /* eslint-disable react/jsx-curly-brace-presence */
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -43,10 +51,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -53,0 +53,0 @@ return (

src/terra-dev-site/test/popup/ArrowVerticalAttachmentsPopup.test.jsx

@@ -22,2 +22,14 @@ /* eslint-disable react/jsx-curly-brace-presence */
 
+  handleAttachment(event) {
+    this.setState({ attachment: event.target.value, open: true });
+  }
+
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -39,14 +51,2 @@ this.buttonNode = node;
 
-  handleAttachment(event) {
-    this.setState({ attachment: event.target.value, open: true });
-  }
-
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -53,0 +53,0 @@ return (

src/terra-dev-site/test/popup/ArrowVerticalLeftAdjustmentPopup.test.jsx

@@ -26,2 +26,10 @@ /* eslint-disable react/jsx-curly-brace-presence */
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -43,10 +51,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -53,0 +53,0 @@ return (

src/terra-dev-site/test/popup/ArrowVerticalRightAdjustmentPopup.test.jsx

@@ -26,2 +26,10 @@ /* eslint-disable react/jsx-curly-brace-presence */
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -43,10 +51,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -53,0 +53,0 @@ return (

src/terra-dev-site/test/popup/AutomaticHeightBoundedPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/AutomaticHeightPopup.test.jsx

@@ -22,2 +22,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -31,10 +39,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -41,0 +41,0 @@ return (

src/terra-dev-site/test/popup/AutomaticWidthBoundedPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/AutomaticWidthPopup.test.jsx

@@ -22,2 +22,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -31,10 +39,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -41,0 +41,0 @@ return (

src/terra-dev-site/test/popup/BoundedHeightPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/BoundedNoHeaderPopup.test.jsx

@@ -25,2 +25,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -42,10 +50,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -52,0 +52,0 @@ return (

src/terra-dev-site/test/popup/BoundedPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/BoundedWidthPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/DefaultPopup.test.jsx

@@ -22,2 +22,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -31,10 +39,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -41,0 +41,0 @@ return (

src/terra-dev-site/test/popup/DifferentAttachmentsPopup.test.jsx

@@ -28,2 +28,14 @@ /* eslint-disable react/jsx-curly-brace-presence */
 
+  handleAttachment(event) {
+    this.setState({ contentAttachment: event.target.value, targetAttachment: targetOptions[event.target.value], open: true });
+  }
+
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -45,14 +57,2 @@ this.buttonNode = node;
 
-  handleAttachment(event) {
-    this.setState({ contentAttachment: event.target.value, targetAttachment: targetOptions[event.target.value], open: true });
-  }
-
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -59,0 +59,0 @@ return (

src/terra-dev-site/test/popup/FocusTrapPopup.test.jsx

@@ -22,2 +22,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -31,10 +39,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -41,0 +41,0 @@ return (

src/terra-dev-site/test/popup/ResizedContentPopup.test.jsx

@@ -23,2 +23,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -32,10 +40,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -42,0 +42,0 @@ return (

src/terra-dev-site/test/popup/SizeInvalidPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/SizeLargePopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/SizeMediumPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

src/terra-dev-site/test/popup/SizeSmallPopup.test.jsx

@@ -24,2 +24,10 @@ import React from 'react';
 
+  handleButtonClick() {
+    this.setState({ open: true });
+  }
+
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -41,10 +49,2 @@ this.buttonNode = node;
 
-  handleButtonClick() {
-    this.setState({ open: true });
-  }
-
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -51,0 +51,0 @@ return (

tests/jest/PopupDefaultExample.jsx

@@ -14,2 +14,6 @@ import React from 'react';
 
+  handleRequestClose() {
+    this.setState({ open: false });
+  }
+
   setButtonNode(node) {
@@ -23,6 +27,2 @@ this.buttonNode = node;
 
-  handleRequestClose() {
-    this.setState({ open: false });
-  }
-
   render() {
@@ -29,0 +29,0 @@ return (

No alert changes

Improved metrics

Total package byte prevSize

387058

increased by0.03%

Dependency changes

• Updatedterra-hookshot@^5.31.0