terra-popup - npm Package Compare versions

Comparing version 6.43.0 to 6.44.0

CHANGELOG.md

@@ -5,2 +5,7 @@ # Changelog
 
+## 6.44.0 - (November 24, 2020)
+
+* Changed
+  * Update wdio tests to remove deprecated Terra.it helpers
+
 ## 6.43.0 - (November 10, 2020)
@@ -7,0 +12,0 @@

package.json

 {
   "name": "terra-popup",
   "main": "lib/Popup.js",
-  "version": "6.43.0",
+  "version": "6.44.0",
   "description": "The Terra Popup is higher order component that launches terra-hookshot positioned content with the ability to display a dynamic arrow.",
@@ -43,3 +43,3 @@ "repository": {
     "terra-disclosure-manager": "^4.37.0",
-    "terra-modal-manager": "^6.43.0"
+    "terra-modal-manager": "^6.44.0"
   },
@@ -59,3 +59,3 @@ "scripts": {
   },
-  "gitHead": "88d3580c37b3965d3b563623e6a8d4843a913d85"
+  "gitHead": "d0ee0429f344f88e18510d71dac0e4797eafd465"
 }

tests/wdio/popup-spec.js

@@ -11,6 +11,6 @@ const selector = '#test-popup-area';
     it('validates popup does not have an arrow', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/default-popup');
+      browser.url('/raw/tests/terra-popup/popup/default-popup');
       browser.waitForVisible('.test-content');
       expect(browser.isExisting('.test-arrow')).to.be.false;
-      Terra.validates.screenshot({ selector });
+      Terra.validates.screenshot('default', { selector });
     });
@@ -53,3 +53,3 @@
     it('validates popup has an arrow', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/arrow-popup');
+      browser.url('/raw/tests/terra-popup/popup/arrow-popup');
       browser.waitForVisible('.test-content');
@@ -67,3 +67,3 @@ expect(browser.isExisting('.test-arrow')).to.be.true;
     it('validates popup with a header', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/bounded-popup');
+      browser.url('/raw/tests/terra-popup/popup/bounded-popup');
       browser.waitForVisible('.test-content');
@@ -74,3 +74,3 @@ Terra.validates.element('with header', { selector });
     it('validates popup without a header', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/bounded-no-header-popup');
+      browser.url('/raw/tests/terra-popup/popup/bounded-no-header-popup');
       browser.waitForVisible('.test-content');
@@ -81,3 +81,3 @@ Terra.validates.screenshot('without header', { selector });
     it('validates height bounded popup', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/bounded-height-popup');
+      browser.url('/raw/tests/terra-popup/popup/bounded-height-popup');
       browser.waitForVisible('.test-content');
@@ -88,3 +88,3 @@ Terra.validates.screenshot('bounded height', { selector });
     it('validates width bounded popup', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/bounded-width-popup');
+      browser.url('/raw/tests/terra-popup/popup/bounded-width-popup');
       browser.waitForVisible('.test-content');
@@ -97,3 +97,3 @@ Terra.validates.screenshot('bounded width', { selector });
     it('opens modal', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/popup-inside-modal');
+      browser.url('/raw/tests/terra-popup/popup/popup-inside-modal');
       browser.click('.disclose');
@@ -106,3 +106,3 @@ browser.waitForVisible('#test-popup-area');
       browser.waitForVisible('.test-content');
-      Terra.validates.screenshot({ selector });
+      Terra.validates.screenshot('popup open', { selector });
     });
@@ -147,5 +147,4 @@
   describe('Vertical Attachments', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/arrow-vertical-attachments-popup'));
-
     it('positions the arrow for vertical-left attachment', () => {
+      browser.url('/raw/tests/terra-popup/popup/arrow-vertical-attachments-popup');
       browser.click('#attach-Left');
@@ -172,3 +171,3 @@ browser.waitForVisible('.test-content');
     it('adjusts the arrow for vertical-left attachment when arrow would be offscreen', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/arrow-vertical-left-adjustment-popup');
+      browser.url('/raw/tests/terra-popup/popup/arrow-vertical-left-adjustment-popup');
       browser.waitForVisible('.test-content');
@@ -179,3 +178,3 @@ Terra.validates.screenshot('adjusted vertical-left', { selector });
     it('adjusts the arrow for vertical-right attachment when arrow would be offscreen', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/arrow-vertical-right-adjustment-popup');
+      browser.url('/raw/tests/terra-popup/popup/arrow-vertical-right-adjustment-popup');
       browser.waitForVisible('.test-content');
@@ -187,5 +186,4 @@ Terra.validates.screenshot('adjusted vertical-right', { selector });
   describe('Content offset', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/different-attachments-popup'));
-
     it('applies content offset when target has vertical-right when content vertical-left attachment', () => {
+      browser.url('/raw/tests/terra-popup/popup/different-attachments-popup');
       browser.click('#attach-Left');
@@ -207,3 +205,3 @@ browser.waitForVisible('.test-content');
     it('applies content offset when target is smaller than the arrow for vertical-left attachment', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/arrow-small-target-left-popup');
+      browser.url('/raw/tests/terra-popup/popup/arrow-small-target-left-popup');
       browser.waitForVisible('.test-content');
@@ -214,3 +212,3 @@ Terra.validates.screenshot('vertical-left', { selector });
     it('applies content offset when target is smaller than the arrow for vertical-right attachment', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/arrow-small-target-right-popup');
+      browser.url('/raw/tests/terra-popup/popup/arrow-small-target-right-popup');
       browser.waitForVisible('.test-content');
@@ -222,5 +220,4 @@ Terra.validates.screenshot('vertical-right', { selector });
   describe('Horizontal Attachments', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/arrow-horizontal-attachments-popup'));
-
     it('positions the arrow for horizontal-top attachment', () => {
+      browser.url('/raw/tests/terra-popup/popup/arrow-horizontal-attachments-popup');
       browser.click('#attach-Top');
@@ -247,33 +244,23 @@ browser.waitForVisible('.test-content');
 
-  describe('Displays a small-sized popup correctly', () => {
-    before(() => {
-      browser.url('/#/raw/tests/terra-popup/popup/size-small-popup');
-      browser.waitForVisible('.test-content');
-    });
-
-    Terra.it.matchesScreenshot({ selector });
+  it('Displays a small-sized popup correctly', () => {
+    browser.url('/raw/tests/terra-popup/popup/size-small-popup');
+    browser.waitForVisible('.test-content');
+    Terra.validates.element('small sized', { selector });
   });
 
-  describe('Displays a medium-sized popup correctly', () => {
-    before(() => {
-      browser.url('/#/raw/tests/terra-popup/popup/size-medium-popup');
-      browser.waitForVisible('.test-content');
-    });
-
-    Terra.it.matchesScreenshot({ selector });
+  it('Displays a medium-sized popup correctly', () => {
+    browser.url('/raw/tests/terra-popup/popup/size-medium-popup');
+    browser.waitForVisible('.test-content');
+    Terra.validates.element('medium sized', { selector });
   });
 
-  describe('[Fallback-sized Popup] when invalid sizes are provided', () => {
-    before(() => {
-      browser.url('/#/raw/tests/terra-popup/popup/size-invalid-popup');
-      browser.waitForVisible('.test-content');
-    });
-
-    Terra.it.matchesScreenshot({ selector });
+  it('[Fallback-sized Popup] when invalid sizes are provided', () => {
+    browser.url('/raw/tests/terra-popup/popup/size-invalid-popup');
+    browser.waitForVisible('.test-content');
+    Terra.validates.element('invalid size', { selector });
   });
 
   describe('Automatic Height Popup', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/automatic-height-popup'));
-
     it('displays a popup with automatic height correctly', () => {
+      browser.url('/raw/tests/terra-popup/popup/automatic-height-popup');
       browser.waitForVisible('.test-content');
@@ -296,15 +283,11 @@ Terra.validates.screenshot({ selector });
 
-  describe('Bounded Automatic Height Popup', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/automatic-height-bounded-popup'));
-
-    it('displays a popup with automatic height correctly when bounded', () => {
-      browser.waitForVisible('.test-content');
-      Terra.validates.screenshot({ selector });
-    });
+  it('displays a popup with automatic height correctly when bounded', () => {
+    browser.url('/raw/tests/terra-popup/popup/automatic-height-bounded-popup');
+    browser.waitForVisible('.test-content');
+    Terra.validates.screenshot({ selector });
   });
 
   describe('Automatic Width Popup', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/automatic-width-popup'));
-
     it('displays a popup with automatic width correctly', () => {
+      browser.url('/raw/tests/terra-popup/popup/automatic-width-popup');
       browser.waitForVisible('.test-content');
@@ -327,9 +310,6 @@ Terra.validates.screenshot({ selector });
 
-  describe('Bounded Automatic Width Popup', () => {
-    before(() => browser.url('/#/raw/tests/terra-popup/popup/automatic-width-bounded-popup'));
-
-    it('displays a popup with automatic width correctly when bounded', () => {
-      browser.waitForVisible('.test-content');
-      Terra.validates.screenshot({ selector });
-    });
+  it('displays a popup with automatic width correctly when bounded', () => {
+    browser.url('/raw/tests/terra-popup/popup/automatic-width-bounded-popup');
+    browser.waitForVisible('.test-content');
+    Terra.validates.screenshot('bounded automatic width', { selector });
   });
@@ -339,3 +319,3 @@
     it('validates original content size', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/resized-content-popup');
+      browser.url('/raw/tests/terra-popup/popup/resized-content-popup');
       browser.waitForVisible('.test-content');
@@ -354,3 +334,3 @@ Terra.validates.screenshot({ selector });
     it('validates focus is moved to popup when open', () => {
-      browser.url('/#/raw/tests/terra-popup/popup/focus-trap-popup');
+      browser.url('/raw/tests/terra-popup/popup/focus-trap-popup');
       browser.waitForVisible('.test-content');
@@ -376,8 +356,8 @@ expect(browser.hasFocus('[data-terra-popup-content]')).to.be.true;
 Terra.describeViewports('Displays a large-sized popup correctly', ['large'], () => {
-  before(() => {
-    browser.url('/#/raw/tests/terra-popup/popup/size-large-popup');
+  it('displays a large sized popup', () => {
+    browser.url('/raw/tests/terra-popup/popup/size-large-popup');
     browser.waitForVisible('.test-content');
+
+    Terra.validates.element('large sized', { selector });
   });
-
-  Terra.it.matchesScreenshot({ selector });
 });

No alert changes

Worsened metrics

Total package byte prevSize

386904

decreased by-0.04%

Lines of code

7769

decreased by-0.13%

No dependency changes