terra-slide-panel-manager - npm Package Compare versions

Comparing version 4.13.0 to 5.0.0

CHANGELOG.md

@@ -7,2 +7,8 @@ Changelog
 
+5.0.0 - (May 13, 2019)
+------------------
+### Breaking Change
+* Removed terra-disclosure-manager dependency
+* Added terra-disclosure-manager peer-dependency
+
 4.13.0 - (May 7, 2019)
@@ -16,2 +22,3 @@ ------------------
 ### Changed
+* Removed usage of `requestFocus` and `releaseFocus` from Slide Panel Manager test files
 * Moved packages we use solely in doc examples and tests to devDependencies
@@ -18,0 +25,0 @@

lib/terra-dev-site/test/slide-panel-manager/DisclosureComponent.js

@@ -50,4 +50,2 @@ 'use strict';
     _this.minimize = _this.minimize.bind(_this);
-    _this.requestFocus = _this.requestFocus.bind(_this);
-    _this.releaseFocus = _this.releaseFocus.bind(_this);
 
@@ -136,12 +134,2 @@ _this.generateOptions = _this.generateOptions.bind(_this);
   }, {
-    key: 'requestFocus',
-    value: function requestFocus() {
-      this.props.disclosureManager.requestFocus();
-    }
-  }, {
-    key: 'releaseFocus',
-    value: function releaseFocus() {
-      this.props.disclosureManager.releaseFocus();
-    }
-  }, {
     key: 'renderFormButton',
@@ -215,12 +203,2 @@ value: function renderFormButton() {
         ),
-        disclosureManager && disclosureManager.releaseFocus ? _react2.default.createElement(
-          'p',
-          null,
-          'Modal has lost focus!'
-        ) : null,
-        disclosureManager && disclosureManager.requestFocus ? _react2.default.createElement(
-          'p',
-          null,
-          'Modal has gained focus!'
-        ) : null,
         _react2.default.createElement(
@@ -291,12 +269,2 @@ 'button',
           'Minimize'
-        ) : null,
-        disclosureManager && disclosureManager.requestFocus ? _react2.default.createElement(
-          'button',
-          { type: 'button', className: 'requestFocus', onClick: this.requestFocus },
-          'Request Focus'
-        ) : null,
-        disclosureManager && disclosureManager.releaseFocus ? _react2.default.createElement(
-          'button',
-          { type: 'button', className: 'releaseFocus', onClick: this.releaseFocus },
-          'Release Focus'
         ) : null
@@ -303,0 +271,0 @@ );

package.json

 {
   "name": "terra-slide-panel-manager",
   "main": "lib/SlidePanelManager.js",
-  "version": "4.13.0",
+  "version": "5.0.0",
   "description": "A DisclosureManager implementation that presents disclosed content using a SlidePanel.",
@@ -27,3 +27,4 @@ "repository": {
     "react": "^16.8.5",
-    "react-dom": "^16.8.5"
+    "react-dom": "^16.8.5",
+    "terra-disclosure-manager": "^4.9.0"
   },
@@ -33,4 +34,3 @@ "dependencies": {
     "prop-types": "^15.5.8",
-    "terra-disclosure-manager": "^4.10.0",
-    "terra-slide-group": "^3.3.0",
+    "terra-slide-group": "^4.0.0",
     "terra-slide-panel": "^3.5.0"
@@ -37,0 +37,0 @@ },

src/terra-dev-site/test/slide-panel-manager/DisclosureComponent.jsx

@@ -21,4 +21,2 @@ import React from 'react';
     this.minimize = this.minimize.bind(this);
-    this.requestFocus = this.requestFocus.bind(this);
-    this.releaseFocus = this.releaseFocus.bind(this);
 
@@ -85,10 +83,2 @@ this.generateOptions = this.generateOptions.bind(this);
 
-  requestFocus() {
-    this.props.disclosureManager.requestFocus();
-  }
-
-  releaseFocus() {
-    this.props.disclosureManager.releaseFocus();
-  }
-
   renderFormButton() {
@@ -137,4 +127,2 @@ const name = `Disclose (${this.state.disclosureHeight}) x (${this.state.disclosureWidth})`;
         </p>
-        {disclosureManager && disclosureManager.releaseFocus ? <p>Modal has lost focus!</p> : null }
-        {disclosureManager && disclosureManager.requestFocus ? <p>Modal has gained focus!</p> : null }
         <button type="button" className="disclose" onClick={this.disclose()}>Disclose</button>
@@ -156,4 +144,2 @@ <button type="button" className="disclose-tiny" onClick={this.disclose('tiny')}>Disclose Tiny</button>
         {disclosureManager && disclosureManager.minimize ? <button type="button" className="minimize" onClick={this.minimize}>Minimize</button> : null }
-        {disclosureManager && disclosureManager.requestFocus ? <button type="button" className="requestFocus" onClick={this.requestFocus}>Request Focus</button> : null }
-        {disclosureManager && disclosureManager.releaseFocus ? <button type="button" className="releaseFocus" onClick={this.releaseFocus}>Release Focus</button> : null }
       </ContentContainer>
@@ -160,0 +146,0 @@ );

tests/wdio/slide-panel-manager-spec.js

@@ -262,33 +262,2 @@ const viewports = Terra.viewports('tiny', 'large');
   });
-
-  describe('Disclosure - RequestFocus', () => {
-    beforeEach(() => {
-      browser.url('/#/raw/tests/terra-slide-panel-manager/slide-panel-manager/slide-panel-manager-default');
-
-      browser.click('#root-component .disclose-large');
-
-      browser.waitForVisible('[class*="slide-group"] #DemoContainer-1 .requestFocus', 1000);
-      browser.click('[class*="slide-group"] #DemoContainer-1 .requestFocus');
-    });
-
-    Terra.should.matchScreenshot({ selector: '#site' });
-  });
-
-  describe('Disclosure - ReleaseFocus', () => {
-    beforeEach(() => {
-      browser.url('/#/raw/tests/terra-slide-panel-manager/slide-panel-manager/slide-panel-manager-default');
-
-      browser.click('#root-component .disclose-large');
-
-      browser.waitForVisible('[class*="slide-group"] #DemoContainer-1 .requestFocus', 1000);
-      browser.click('[class*="slide-group"] #DemoContainer-1 .requestFocus');
-
-      browser.waitForVisible('[class*="slide-group"] #DemoContainer-1 .releaseFocus', 1000);
-      browser.click('[class*="slide-group"] #DemoContainer-1 .releaseFocus');
-
-      browser.waitForVisible('[class*="slide-group"] #DemoContainer-1 .requestFocus', 1000);
-    });
-
-    Terra.should.matchScreenshot({ selector: '#site' });
-  });
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

97022

decreased by-2.99%

Lines of code

1653

decreased by-3.78%

Dependency changes

• + Addeddom-helpers@5.2.1(transitive)

• + Addedreact-transition-group@4.4.5(transitive)

• + Addedterra-slide-group@4.36.1(transitive)

• - Removedterra-disclosure-manager@^4.10.0

• - Removeddom-helpers@3.4.0(transitive)

• - Removedreact-lifecycles-compat@3.0.4(transitive)

• - Removedreact-transition-group@2.9.0(transitive)

• - Removedterra-slide-group@3.3.0(transitive)

• Updatedterra-slide-group@^4.0.0