test-agent - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

HISTORY.md

@@ -0,1 +1,5 @@
+# 0.4.1
+  - Removed add test env in favor of set test env.
+  - Fixed bugs related to add test env by removing it with set test env.
+
 # 0.4.0
@@ -2,0 +6,0 @@ - Ported all node/mocha/ scripts to test-agent/mocha/ they will now

lib/node/bin/test.js

@@ -62,3 +62,3 @@ var Client = require('../../node/client'),
 
-  client.mirrorServerEvents(['add test env', 'error', 'test data'], true);
+  client.mirrorServerEvents(['set test envs', 'error', 'test data'], true);
   client.send('queue tests', {files: files});
@@ -65,0 +65,0 @@ });

lib/test-agent/browser-worker/multi-domain-driver.js

@@ -27,3 +27,3 @@ (function(window) {
 
-    forwardEvents: ['test data', 'error', 'add test env'],
+    forwardEvents: ['test data', 'error', 'set test envs'],
 
@@ -196,4 +196,4 @@ listenToWorker: 'post-message',
       envs = Object.keys(this.testEnvs);
-      this.worker.emit('add test env', envs);
-      this.worker.send('add test env', envs);
+      this.worker.emit('set test envs', envs);
+      this.worker.send('set test envs', envs);
       this._loadNextDomain();
@@ -200,0 +200,0 @@ }

lib/test-agent/common/mocha-test-events.js

@@ -85,3 +85,3 @@ (function() {
       server.on('test data', this._onTestData.bind(this));
-      server.on('add test env', this._onAddTestEnv.bind(this));
+      server.on('set test envs', this._onSetTestEnvs.bind(this));
       this.reporter.on('start', this._onRunnerStart.bind(this, server));
@@ -91,4 +91,4 @@ this.reporter.on('end', this._onRunnerEnd.bind(this, server));
 
-    _onAddTestEnv: function _onAddTestEnv(env) {
-      this.reporter.addEnv(env);
+    _onSetTestEnvs: function _onSetTestEnvs(env) {
+      this.reporter.setEnvs(env);
     },
@@ -105,3 +105,2 @@
       this.isRunning = false;
-      this.savedError = undefined;
       server.emit.apply(server, endArgs);
@@ -108,0 +107,0 @@ },

lib/test-agent/mocha/reporter.js

@@ -53,11 +53,11 @@ (function() {
   /**
-   * Adds env to next test run.
+   * Set envs for next test run.
    *
    * @param {String|String[]} env a single env or an array of envs.
    */
-  Reporter.prototype.addEnv = function addEnv(env) {
+  Reporter.prototype.setEnvs = function setEnvs(env) {
     if (env instanceof Array) {
-      this.envs = this.envs.concat(env);
+      this.envs = env;
     } else {
-      this.envs.push(env);
+      this.envs = [env];
     }
@@ -64,0 +64,0 @@ };

package.json

 {
   "name": "test-agent",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "author": "James Lal",
@@ -5,0 +5,0 @@ "description": "execute client side tests from browser report back to cli",

playground/index.js

@@ -40,5 +40,2 @@ (function(window) {
 
-    'add test env': function() {
-    },
-
     'test data': function() {
@@ -45,0 +42,0 @@ },

No alert changes

Improved metrics

Total package byte prevSize

500963

Worsened metrics

Lines of code

17030

decreased by-0.02%

No dependency changes