thesubdb - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

lib/index.js

 'use strict';
 
-var _fs = require('fs');
+var _fsExtra = require('fs-extra');
 
-var _fs2 = _interopRequireDefault(_fs);
+var _fsExtra2 = _interopRequireDefault(_fsExtra);
 
@@ -15,5 +15,5 @@ var _path = require('path');
 
-var _request = require('request');
+var _requestPromise = require('request-promise');
 
-var _request2 = _interopRequireDefault(_request);
+var _requestPromise2 = _interopRequireDefault(_requestPromise);
 
@@ -24,3 +24,3 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
   var readSize = 64 * 1024;
-  var buffer = _fs2.default.readFileSync(file);
+  var buffer = _fsExtra2.default.readFileSync(file);
   var contentLength = buffer.byteLength;
@@ -43,10 +43,10 @@ var start = Buffer.alloc(readSize);
     };
-    (0, _request2.default)(options, function (err, res, body) {
-      if (err) {
-        reject(err);
-      } else if (res.statusCode === 200) {
-        resolve(body.split(','));
+    (0, _requestPromise2.default)(options).then(function (res) {
+      if (res.statusCode === 200) {
+        resolve(res.body.split(','));
       } else {
         reject(new Error('Received status code: ' + res.statusCode));
       }
+    }).catch(function (res) {
+      reject(new Error('Received status code: ' + res.statusCode));
     });
@@ -65,15 +65,10 @@ });
     };
-    (0, _request2.default)(options, function (err, res, body) {
-      if (err) {
-        reject(err);
-      } else if (res.statusCode === 200) {
-        _fs2.default.writeFile(_path2.default.basename(file, _path2.default.extname(file)) + '.srt', body, function (err2) {
-          if (err2) {
-            reject(err2);
-          }
-          resolve();
-        });
+    (0, _requestPromise2.default)(options).then(function (res) {
+      if (res.statusCode === 200) {
+        _fsExtra2.default.writeFile(_path2.default.basename(file, _path2.default.extname(file)) + '.srt', res.body).then(resolve).catch(reject);
       } else {
         reject(new Error('Received status code: ' + res.statusCode));
       }
+    }).catch(function (res) {
+      reject(new Error('Received status code: ' + res.statusCode));
     });
@@ -80,0 +75,0 @@ });

package.json

 {
   "name": "thesubdb",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "A Node.js library for thesubdb",
@@ -24,5 +24,7 @@ "main": "lib/index.js",
   "dependencies": {
+    "fs-extra": "^4.0.2",
     "md5": "^2.2.1",
-    "request": "^2.82.0"
+    "request": "^2.82.0",
+    "request-promise": "^4.2.2"
   }
 }

src/index.js

 // @flow
-import fs from 'fs';
+import fs from 'fs-extra';
 import path from 'path';
 import md5 from 'md5';
-import request from 'request';
+import request from 'request-promise';
 
@@ -18,23 +18,22 @@ const getHash = (file: string): string => {
 
-const availLan = (file: string): Promise<Array<string>> =>
-  new Promise((resolve, reject) => {
-    const hash = getHash(path.resolve(__dirname, file));
-    const options = {
-      url: `http://api.thesubdb.com/?action=search&hash=${hash}`,
-      headers: {
-        'User-Agent': 'SubDB/1.0 (thesubdb/0.1; https://github.com/MaartenRimaux/thesubdb)',
-      },
-    };
-    request(options, (err: Error, res: any, body: any) => {
-      if (err) {
-        reject(err);
-      } else if (res.statusCode === 200) {
-        resolve(body.split(','));
+const availLan = (file: string): Promise<string> => new Promise((resolve, reject) => {
+  const hash = getHash(path.resolve(__dirname, file));
+  const options = {
+    url: `http://api.thesubdb.com/?action=search&hash=${hash}`,
+    headers: {
+      'User-Agent': 'SubDB/1.0 (thesubdb/0.1; https://github.com/MaartenRimaux/thesubdb)',
+    },
+  };
+  request(options)
+    .then((res: any) => {
+      if (res.statusCode === 200) {
+        resolve(res.body.split(','));
       } else {
         reject(new Error(`Received status code: ${res.statusCode}`));
       }
-    });
-  });
+    })
+    .catch((res: any) => { reject(new Error(`Received status code: ${res.statusCode}`)); });
+});
 
-const downSub = (lang: string, file: string): Promise => new Promise((resolve, reject) => {
+const downSub = (lang: string, file: string): Promise<string> => new Promise((resolve, reject) => {
   const hash = getHash(path.resolve(__dirname, file));
@@ -47,14 +46,13 @@ const options = {
   };
-  request(options, (err: Error, res: any, body: any) => {
-    if (err) {
-      reject(err);
-    } else if (res.statusCode === 200) {
-      fs.writeFile(`${path.basename(file, path.extname(file))}.srt`, body, (err2) => {
-        if (err2) { reject(err2); }
-        resolve();
-      });
-    } else {
-      reject(new Error(`Received status code: ${res.statusCode}`));
-    }
-  });
+  request(options)
+    .then((res: any) => {
+      if (res.statusCode === 200) {
+        fs.writeFile(`${path.basename(file, path.extname(file))}.srt`, res.body)
+          .then(resolve)
+          .catch(reject);
+      } else {
+        reject(new Error(`Received status code: ${res.statusCode}`));
+      }
+    })
+    .catch((res: any) => { reject(new Error(`Received status code: ${res.statusCode}`)); });
 });
@@ -61,0 +59,0 @@

New alerts

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Fixed alerts

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

103700

increased by1.68%

Worsened metrics

Dependency count

4

increased by100%

Lines of code

189

decreased by-3.57%

Dependency changes

• + Addedfs-extra@^4.0.2

• + Addedrequest-promise@^4.2.2

• + Addedbluebird@3.7.2(transitive)

• + Addedfs-extra@4.0.3(transitive)

• + Addedgraceful-fs@4.2.11(transitive)

• + Addedjsonfile@4.0.0(transitive)

• + Addedlodash@4.17.21(transitive)

• + Addedrequest-promise@4.2.6(transitive)

• + Addedrequest-promise-core@1.1.4(transitive)

• + Addedstealthy-require@1.1.1(transitive)

• + Addeduniversalify@0.1.2(transitive)