thriftrw - npm Package Compare versions

Comparing version 2.2.2 to 2.2.3

package.json

 {
   "name": "thriftrw",
-  "version": "2.2.2",
+  "version": "2.2.3",
   "description": "thrift encoding/decoding using bufrw",
@@ -5,0 +5,0 @@ "keywords": [],

service.js

@@ -51,3 +51,3 @@ // Copyright (c) 2015 Uber Technologies, Inc.
     var resultFields = def.throws || [];
-    if (returnType.type === 'BaseType' && returnType.baseType !== 'void') {
+    if (returnType.type !== 'BaseType' || returnType.baseType !== 'void') {
         var successFieldId = new ast.FieldIdentifier(0);
@@ -54,0 +54,0 @@ var successField = new ast.Field(successFieldId, def.returns, 'success');

test/service.js

@@ -50,1 +50,15 @@ // Copyright (c) 2015 Uber Technologies, Inc.
 });
+
+test('returns base-type that is not void', function t(assert) {
+    var result = thrift.getType('Foo::returnsI32_result');
+    assert.deepEqual(Object.keys(result.fieldsById), ['0'], 'success id');
+    assert.deepEquals(Object.keys(result.fieldsByName), ['success'], 'success name');
+    assert.end();
+});
+
+test('returns non-base-type', function t(assert) {
+    var result = thrift.getType('Foo::returnsStruct_result');
+    assert.deepEqual(Object.keys(result.fieldsById), ['0'], 'success id');
+    assert.deepEquals(Object.keys(result.fieldsByName), ['success'], 'success name');
+    assert.end();
+});

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

338228

increased by0.2%

Lines of code

6085

increased by0.2%

No dependency changes