troika-3d-text - npm Package Compare versions

Comparing version 0.28.0 to 0.28.1

CHANGELOG.md

@@ -6,2 +6,14 @@ # Change Log
 
+## [0.28.1](https://github.com/protectwise/troika/compare/v0.28.0...v0.28.1) (2020-06-17)
+
+
+### Bug Fixes
+
+* **troika-3d-text:** don't dispose derived materials on base material switch ([3d88475](https://github.com/protectwise/troika/commit/3d88475d2f3ead6bec92694ff0720d4ab643e872)), closes [#59](https://github.com/protectwise/troika/issues/59)
+* **troika-3d-text:** set correct `object` in TextMesh raycast intersections ([9f3eaa7](https://github.com/protectwise/troika/commit/9f3eaa713d759996aea274d33a0443541482453a)), closes [#62](https://github.com/protectwise/troika/issues/62)
+
+
+
+
+
 # [0.28.0](https://github.com/protectwise/troika/compare/v0.27.1...v0.28.0) (2020-06-09)
@@ -8,0 +20,0 @@

package.json

 {
   "name": "troika-3d-text",
-  "version": "0.28.0",
+  "version": "0.28.1",
   "description": "Troika 3D Text",
@@ -18,4 +18,4 @@ "author": "Jason Johnston <[e-mail]>",
   "dependencies": {
-    "troika-3d": "^0.28.0",
-    "troika-three-utils": "^0.28.0",
+    "troika-3d": "^0.28.1",
+    "troika-three-utils": "^0.28.1",
     "troika-worker-utils": "^0.28.0"
@@ -31,3 +31,3 @@ },
   },
-  "gitHead": "abfdef4be8b700cc817c34991dc7c8604ed8d75b"
+  "gitHead": "96b3c36ff397b784d58a85c3ab29abae0f19bff3"
 }

src/three/TextMesh.js

@@ -24,2 +24,3 @@ import {
 const tempVec3b = new Vector3()
+const tempArray = []
 const origin = new Vector3()
@@ -343,5 +344,2 @@ const defaultOrient = '+x+y'
     if (!derivedMaterial || derivedMaterial.baseMaterial !== baseMaterial) {
-      if (derivedMaterial) {
-        derivedMaterial.dispose()
-      }
       derivedMaterial = this._derivedMaterial = createTextDerivedMaterial(baseMaterial)
@@ -452,3 +450,8 @@ // dispose the derived material when its base material is disposed:
       )
-      raycastMesh.raycast(raycaster, intersects)
+      tempArray.length = 0
+      raycastMesh.raycast(raycaster, tempArray)
+      for (let i = 0; i < tempArray.length; i++) {
+        tempArray[i].object = this
+        intersects.push(tempArray[i])
+      }
     }
@@ -455,0 +458,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2020480

increased by0.06%

Lines of code

35921

increased by0.02%

Number of versions

90

increased by1.12%

Published versions last months

3

increased by50%

Published versions last two months

8

increased by14.29%

Published versions last week

1

increased byInfinity%

Published versions last year

11

increased by10%

Dependency changes

• Updatedtroika-3d@^0.28.1

• Updatedtroika-three-utils@^0.28.1