troika-three-text - npm Package Compare versions

Comparing version 0.38.0 to 0.38.1

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.38.1](https://github.com/protectwise/troika/compare/v0.38.0...v0.38.1) (2021-02-03)
+
+
+### Bug Fixes
+
+* **troika-three-text:** prevent copy() from sharing geometry between instances ([8c3ba2d](https://github.com/protectwise/troika/commit/8c3ba2d8f610c045dadee17a6221ea61ab8d26d4))
+
+
+
+
+
 # [0.38.0](https://github.com/protectwise/troika/compare/v0.37.0...v0.38.0) (2021-01-24)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "troika-three-text",
-  "version": "0.38.0",
+  "version": "0.38.1",
   "description": "SDF-based text rendering for Three.js",
@@ -17,4 +17,4 @@ "author": "Jason Johnston <[e-mail]>",
   "dependencies": {
-    "troika-three-utils": "^0.38.0",
-    "troika-worker-utils": "^0.38.0"
+    "troika-three-utils": "^0.38.1",
+    "troika-worker-utils": "^0.38.1"
   },
@@ -32,3 +32,3 @@ "devDependencies": {
   },
-  "gitHead": "d48144bf99a2eaf2089c0cd2a8065506161dfdf4"
+  "gitHead": "b54fd6f27b4d95190747ff94cf4e101239447fea"
 }

src/Text.js

@@ -653,3 +653,7 @@ import {
     copy(source) {
+      // Prevent copying the geometry reference so we don't end up sharing attributes between instances
+      const geom = this.geometry
       super.copy(source)
+      this.geometry = geom
+
       COPYABLE_PROPS.forEach(prop => {
@@ -656,0 +660,0 @@ this[prop] = source[prop]

src/TextBuilder.js

@@ -87,6 +87,7 @@ import { Color, DataTexture, LinearFilter, LuminanceFormat } from 'three'
  *           equivalent to the dimensions of a block-level text element in CSS.
- * @property {Array<number>} visibleBounds -
+ * @property {Array<number>} visibleBounds - The total [minX, minY, maxX, maxY] rect of the whole text block;
+ *           unlike `blockBounds` this is tightly wrapped to the visible glyph paths.
  * @property {Array<number>} totalBounds - DEPRECATED; use blockBounds instead.
  * @property {Array<number>} totalBlockSize - DEPRECATED; use blockBounds instead
- * @property {Array<number>} chunkedBounds - List of bounding rects for each consecutive set of N glyphs,
+ * @property {Array<object>} chunkedBounds - List of bounding rects for each consecutive set of N glyphs,
  *           in the format `{start:N, end:N, rect:[minX, minY, maxX, maxY]}`.
@@ -93,0 +94,0 @@ * @property {object} timings - Timing info for various parts of the rendering logic including SDF

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1180584

increased by0.11%

Lines of code

8965

increased by0.15%

Dependency changes

• Updatedtroika-three-utils@^0.38.1

• Updatedtroika-worker-utils@^0.38.1