turn-admin-client - npm Package Compare versions

Comparing version 0.0.2 to 0.1.0

index.js

 'use strict';
 
 var carrier = require('carrier');
-var connection = require('./lib/connection');
+var connect = require('./lib/connection');
 var parse = require('./lib/parser');
 
-var conn;
-
 function TurnAdminClient(params) {
@@ -15,6 +13,7 @@ this.port = params.port || 5766;
   this.encoding = params.encoding || 'utf8';
+  this.conn = null;
 }
 
 TurnAdminClient.prototype.init = function () {
-  conn = connection({
+  this.conn = connect({
     port: this.port,
@@ -28,10 +27,10 @@ hostname: this.host,
 
-  conn.write('ps');
+  this.conn.write('ps');
 
   var sessions = [];
 
-  carrier.carry(conn, function carrierCb(rawData) {
+  carrier.carry(this.conn, function carrierCb(rawData) {
 
     if (rawData.indexOf('Total sessions') !== -1) {
-      //when it gets to  "Total sessions <num>" we know we're done; check ther numbers are right!
+      //when it gets to  "Total sessions <num>" we know we're done; check the numbers are right!
       cb(null, sessions);
@@ -54,5 +53,5 @@ return;
 TurnAdminClient.prototype.disconnect = function () {
-  conn.end();
+  this.conn.end();
 };
 
 module.exports = TurnAdminClient;

lib/parser.js

@@ -13,3 +13,3 @@ 'use strict';
 
-var capture = [
+var captureKeys = [
   'recordNumber',
@@ -30,10 +30,10 @@ 'id',
   'SHA256',
-  'SHA_type',
-  'usage_rp',
-  'usage_rb',
-  'usage_sp',
-  'usage_sb',
-  'rate_r',
-  'rate_s',
-  'rate_total',
+  'SHAType',
+  'usageRP',
+  'usageRB',
+  'usageSP',
+  'usageSB',
+  'rateR',
+  'rateS',
+  'rateTotal',
   'peers'//special case, going to be an array
@@ -53,9 +53,9 @@ ];
 
-  capture.forEach(function (key, num) {
+  captureKeys.forEach(function (capture, index) {
 
-    if (key === 'peers') {
+    if (capture === 'peers') {
       //if we're at peers we've still got some work to do
-      results[key] = [];
+      results[capture] = [];
 
-      var ipAddresses = parsed[num].split("\n");
+      var ipAddresses = parsed[index].split("\n");
       ipAddresses.forEach(function getIpAddresses(line) {
@@ -66,3 +66,3 @@
         if (ipAddress && ipAddress[0]) {
-          results[key].push(ipAddress[0]);
+          results[capture].push(ipAddress[0]);
         }
@@ -74,3 +74,3 @@ });
 
-    results[key] = parsed[num];
+    results[capture] = parsed[index];
 
@@ -77,0 +77,0 @@ });

package.json

 {
   "name": "turn-admin-client",
-  "version": "0.0.2",
+  "version": "0.1.0",
   "description": "A tool to access live TURN administrative information",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "mocha spec/**/*.spec.js"
   },
@@ -9,0 +9,0 @@ "keywords": [

spec/api/api.spec.js

@@ -43,10 +43,10 @@ 'use strict';
       sessions[0].SHA256.should.be.equal('OFF');
-      sessions[0].SHA_type.should.be.equal('SHA1');
-      sessions[0].usage_rp.should.be.equal('6');
-      sessions[0].usage_rb.should.be.equal('1204');
-      sessions[0].usage_sp.should.be.equal('5');
-      sessions[0].usage_sb.should.be.equal('508');
-      sessions[0].rate_r.should.be.equal('0');
-      sessions[0].rate_s.should.be.equal('0');
-      sessions[0].rate_total.should.be.equal('0');
+      sessions[0].SHAType.should.be.equal('SHA1');
+      sessions[0].usageRP.should.be.equal('6');
+      sessions[0].usageRB.should.be.equal('1204');
+      sessions[0].usageSP.should.be.equal('5');
+      sessions[0].usageSB.should.be.equal('508');
+      sessions[0].rateR.should.be.equal('0');
+      sessions[0].rateS.should.be.equal('0');
+      sessions[0].rateTotal.should.be.equal('0');
       sessions[0].peers.should.be.instanceof(Array);
@@ -77,10 +77,10 @@ sessions[0].peers.should.be.deep.equal([
       sessions[1].SHA256.should.be.equal('OFF');
-      sessions[1].SHA_type.should.be.equal('SHA1');
-      sessions[1].usage_rp.should.be.equal('6');
-      sessions[1].usage_rb.should.be.equal('1184');
-      sessions[1].usage_sp.should.be.equal('5');
-      sessions[1].usage_sb.should.be.equal('508');
-      sessions[1].rate_r.should.be.equal('0');
-      sessions[1].rate_s.should.be.equal('0');
-      sessions[1].rate_total.should.be.equal('0');
+      sessions[1].SHAType.should.be.equal('SHA1');
+      sessions[1].usageRP.should.be.equal('6');
+      sessions[1].usageRB.should.be.equal('1184');
+      sessions[1].usageSP.should.be.equal('5');
+      sessions[1].usageSB.should.be.equal('508');
+      sessions[1].rateR.should.be.equal('0');
+      sessions[1].rateS.should.be.equal('0');
+      sessions[1].rateTotal.should.be.equal('0');
       sessions[1].peers.should.be.instanceof(Array);
@@ -87,0 +87,0 @@ sessions[1].peers.should.be.deep.equal([

spec/unit/parser.spec.js

@@ -26,10 +26,10 @@ 'use strict';
     results.SHA256.should.be.equal('OFF');
-    results.SHA_type.should.be.equal('SHA1');
-    results.usage_rp.should.be.equal('6');
-    results.usage_rb.should.be.equal('1204');
-    results.usage_sp.should.be.equal('5');
-    results.usage_sb.should.be.equal('508');
-    results.rate_r.should.be.equal('0');
-    results.rate_s.should.be.equal('0');
-    results.rate_total.should.be.equal('0');
+    results.SHAType.should.be.equal('SHA1');
+    results.usageRP.should.be.equal('6');
+    results.usageRB.should.be.equal('1204');
+    results.usageSP.should.be.equal('5');
+    results.usageSB.should.be.equal('508');
+    results.rateR.should.be.equal('0');
+    results.rateS.should.be.equal('0');
+    results.rateTotal.should.be.equal('0');
     results.peers.should.be.instanceof(Array);
@@ -36,0 +36,0 @@ results.peers.should.be.deep.equal([

Fixed alerts

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

20216

increased by1.63%

Number of package files

14

increased by7.69%

Number of low quality alerts

2

decreased by-33.33%

No dependency changes