twreporter-redux - npm Package Compare versions

Comparing version 2.1.4-beta.4 to 2.1.4-beta.5

lib/actions/topics.js

@@ -137,3 +137,3 @@ 'use strict';
     // check if nPerPage number is valid
-    if (!_.isInteger(nPerPage) || !(nPerPage > 0)) {
+    if (!_.isInteger(nPerPage) || nPerPage <= 0) {
       return Promise.resolve().then(function () {
@@ -154,7 +154,7 @@ dispatch({
     // check if page number is valid
-    if (_.isInteger(page) && page > 0 && page <= totalPages) {
+    if (!_.isInteger(page) || page <= 0 || page > totalPages) {
       return Promise.resolve().then(function () {
         return dispatch({
           type: _actionTypes2.default.ERROR_TO_GET_TOPICS,
-          error: 'page value must be an interger between 1 to ' + totalPages + ', but is ' + page
+          error: 'page value must be an interger between 1 and ' + totalPages + ', but is ' + page
         });
@@ -161,0 +161,0 @@ });

package.json

 {
   "name": "twreporter-redux",
-  "version": "2.1.4-beta.4",
+  "version": "2.1.4-beta.5",
   "description": "redux actions and reducers for twreporter website",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/actions/topics.js

@@ -107,3 +107,3 @@ import apiConfig from '../conf/api-config.json'
     // check if nPerPage number is valid
-    if (!_.isInteger(nPerPage) || !(nPerPage > 0)) {
+    if (!_.isInteger(nPerPage) || nPerPage <= 0) {
       return Promise.resolve()
@@ -125,3 +125,3 @@ .then(() => {
     // check if page number is valid
-    if (_.isInteger(page) && page > 0 && page <= totalPages) {
+    if (!_.isInteger(page) || page <= 0 || page > totalPages) {
       return Promise.resolve()
@@ -131,3 +131,3 @@ .then(() => {
             type: types.ERROR_TO_GET_TOPICS,
-            error: `page value must be an interger between 1 to ${totalPages}, but is ${page}`,
+            error: `page value must be an interger between 1 and ${totalPages}, but is ${page}`,
           })
@@ -134,0 +134,0 @@ })

No alert changes

No metric changes

No dependency changes