unfixated - npm Package Compare versions

Comparing version 0.0.2 to 0.0.4

package.json

 {
   "name": "unfixated",
-  "version": "0.0.2",
+  "version": "0.0.4",
   "description": "Stream fixed width files to objects",
@@ -10,8 +10,15 @@ "main": "unfixated.js",
   "dependencies": {
-    "byline": "^4.2.1"
+    "byline": "^4.2.1",
+    "iconv": "^2.1.11"
   },
-  "devDependencies": {},
+  "devDependencies": {
+    "chai": "^3.5.0",
+    "mocha": "^2.4.5"
+  },
   "scripts": {
     "test": "mocha test"
   },
+  "contributors": [
+    { "name": "jobe451", "url": "https://github.com/jobe451"}
+  ],
   "repository": {
@@ -18,0 +25,0 @@ "type": "git",

unfixated.js

@@ -8,3 +8,3 @@ var LineStream = require('byline').LineStream;
 function UnFixated(format, opt) {
-  if (!(this instanceof UnFixated)) {    
+  if (!(this instanceof UnFixated)) {
     return new UnFixated(format, opt);
@@ -29,3 +29,3 @@ }
     var format = self._format;
-    
+
     var obj = {};
@@ -41,17 +41,16 @@
       }
-      
+
       offset += format[key];
     });
-
-    self.push(obj);   
+    self.push(obj);
   }
 
   this.lineStream = new LineStream();
-  
+
   this.lineStream.on('data', lineToObject);
-  var end = this.end.bind(this);
-  this.end = function() {
-    this.lineStream.end();
-    end();
-  };  
+
+  this.on('finish', function() {
+    self.lineStream.end()
+  })
+
 }
@@ -64,7 +63,7 @@
   if (Buffer.isBuffer(value)) {
-    data = value.toString();
     encoding = 'utf8';
+    value = value.toString();
   }
-
-  this.lineStream.write(data, encoding);
+  
+  this.lineStream.write(value, encoding);
   return callback();
@@ -71,0 +70,0 @@ };

No alert changes

Improved metrics

Total package byte prevSize

7521

increased by1.95%

Worsened metrics

Dependency count

2

increased by100%

Dev dependency count

2

increased byInfinity%

Lines of code

159

decreased by-1.24%

Dependency changes

• + Addediconv@^2.1.11

• + Addediconv@2.3.5(transitive)

• + Addednan@2.22.0(transitive)

• + Addedsafer-buffer@2.1.2(transitive)