victory-brush-container - npm Package Compare versions

Comparing version 30.2.0 to 30.3.0

es/brush-helpers.js

@@ -401,5 +401,7 @@ import _mapValues from "lodash/mapValues";
         allowResize = targetProps.allowResize,
-        defaultBrushArea = targetProps.defaultBrushArea; // if the mouse hasn't moved since a mouseDown event, select the whole domain region
+        defaultBrushArea = targetProps.defaultBrushArea; // if the mouse hasn't moved since a mouseDown event, select the default brush area
 
-    if (allowResize && x1 === x2 || y1 === y2) {
+    var defaultBrushHasArea = defaultBrushArea !== undefined && defaultBrushArea !== "none";
+
+    if ((allowResize || defaultBrushHasArea) && (x1 === x2 || y1 === y2)) {
       var cachedDomain = targetProps.cachedCurrentDomain || targetProps.currentDomain;
@@ -406,0 +408,0 @@ var currentDomain = this.getDefaultBrushArea(defaultBrushArea, domain, cachedDomain);

lib/brush-helpers.js

@@ -419,5 +419,7 @@ "use strict";
         allowResize = targetProps.allowResize,
-        defaultBrushArea = targetProps.defaultBrushArea; // if the mouse hasn't moved since a mouseDown event, select the whole domain region
+        defaultBrushArea = targetProps.defaultBrushArea; // if the mouse hasn't moved since a mouseDown event, select the default brush area
 
-    if (allowResize && x1 === x2 || y1 === y2) {
+    var defaultBrushHasArea = defaultBrushArea !== undefined && defaultBrushArea !== "none";
+
+    if ((allowResize || defaultBrushHasArea) && (x1 === x2 || y1 === y2)) {
       var cachedDomain = targetProps.cachedCurrentDomain || targetProps.currentDomain;
@@ -424,0 +426,0 @@ var currentDomain = this.getDefaultBrushArea(defaultBrushArea, domain, cachedDomain);

package.json

 {
   "name": "victory-brush-container",
-  "version": "30.2.0",
+  "version": "30.3.0",
   "description": "Interactive Brush Component for Victory",
@@ -24,3 +24,3 @@ "keywords": [
     "prop-types": "^15.5.8",
-    "victory-core": "^30.2.0"
+    "victory-core": "^30.3.0"
   },
@@ -27,0 +27,0 @@ "scripts": {

src/brush-helpers.js

@@ -249,4 +249,5 @@ import { Selection } from "victory-core";
     } = targetProps;
-    // if the mouse hasn't moved since a mouseDown event, select the whole domain region
-    if (allowResize && x1 === x2 || y1 === y2) {
+    // if the mouse hasn't moved since a mouseDown event, select the default brush area
+    const defaultBrushHasArea = defaultBrushArea !== undefined && defaultBrushArea !== "none";
+    if ((allowResize || defaultBrushHasArea) && (x1 === x2 || y1 === y2)) {
       const cachedDomain = targetProps.cachedCurrentDomain || targetProps.currentDomain;
@@ -253,0 +254,0 @@ const currentDomain = this.getDefaultBrushArea(defaultBrushArea, domain, cachedDomain);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1213823

increased by0.1%

Lines of code

22388

increased by0.06%

Worsened metrics

Number of downloads

104087

decreased by-11.58%

Published versions last months

2

decreased by-33.33%

Dependency changes

• Updatedvictory-core@^30.3.0