victory-chart - npm Package Compare versions

Comparing version 21.1.2 to 21.1.3

CHANGELOG.md

 # VictoryChart Changelog
 
+## 21.1.3 (2017-06-21)
+
+[481](https://github.com/FormidableLabs/victory-chart/pull/481) Conditional `preventDefault` for `VictoryZoomContainer`
+
 ## 21.1.2 (2017-06-15)
@@ -4,0 +8,0 @@

lib/components/containers/victory-zoom-container.js

@@ -69,2 +69,5 @@ Object.defineProperty(exports,"__esModule",{value:true});exports.zoomContainerMixin=undefined;var _isEqual2=require("lodash/isEqual");var _isEqual3=_interopRequireDefault(_isEqual2);var _defaults2=require("lodash/defaults");var _defaults3=_interopRequireDefault(_defaults2);var _jsxFileName="src/components/containers/victory-zoom-container.js",_this3=this;var _extends=Object.assign||function(target){for(var i=1;i<arguments.length;i++){var source=arguments[i];for(var key in source){if(Object.prototype.hasOwnProperty.call(source,key)){target[key]=source[key];}}}return target;};var _createClass=function(){function defineProperties(target,props){for(var i=0;i<props.length;i++){var descriptor=props[i];descriptor.enumerable=descriptor.enumerable||false;descriptor.configurable=true;if("value"in descriptor)descriptor.writable=true;Object.defineProperty(target,descriptor.key,descriptor);}}return function(Constructor,protoProps,staticProps){if(protoProps)defineProperties(Constructor.prototype,protoProps);if(staticProps)defineProperties(Constructor,staticProps);return Constructor;};}();var _propTypes=require("prop-types");var _propTypes2=_interopRequireDefault(_propTypes);
 
+
+
+
 children,props){var
@@ -150,5 +153,5 @@ scale=props.scale,clipContainerComponent=props.clipContainerComponent,polar=props.polar,origin=props.origin;
 return this.clipDataComponents(children,props);
-}}]);return VictoryZoomContainer;}(base),_class.displayName="VictoryZoomContainer",_class.propTypes=_extends({},_victoryCore.VictoryContainer.propTypes,{allowZoom:_propTypes2.default.bool,clipContainerComponent:_propTypes2.default.element.isRequired,dimension:_propTypes2.default.oneOf(["x","y"]),minimumZoom:_propTypes2.default.shape({x:_propTypes2.default.number,y:_propTypes2.default.number}),onDomainChange:_propTypes2.default.func,zoomDomain:_propTypes2.default.shape({x:_victoryCore.PropTypes.domain,y:_victoryCore.PropTypes.domain})}),_class.defaultProps=_extends({},_victoryCore.VictoryContainer.defaultProps,{clipContainerComponent:_react2.default.createElement(_victoryCore.VictoryClipContainer,{__source:{fileName:_jsxFileName,lineNumber:28}}),allowZoom:true}),_class.defaultEvents=[{target:"parent",eventHandlers:{onMouseDown:function onMouseDown(evt,targetProps){return _zoomHelpers2.default.onMouseDown(evt,targetProps);},onMouseUp:function onMouseUp(evt,targetProps){return _zoomHelpers2.default.onMouseUp(evt,targetProps);},onMouseLeave:function onMouseLeave(evt,targetProps){return _zoomHelpers2.default.onMouseLeave(evt,targetProps);},onMouseMove:function onMouseMove(evt,targetProps,eventKey,ctx){evt.preventDefault();var mutations=_zoomHelpers2.default.onMouseMove(evt,targetProps,eventKey,ctx);if(mutations.id!==_this3.mouseMoveMutationId){_this3.mouseMoveMutationId=mutations.id;return mutations.mutations;}return undefined;},onWheel:function onWheel(evt,targetProps,eventKey,ctx){evt.preventDefault();var mutations=_zoomHelpers2.default.onWheel(evt,targetProps,eventKey,ctx);if(mutations.id!==_this3.wheelMutationId){_this3.wheelMutationId=mutations.id;return mutations.mutations;}return undefined;}}}],_temp;};exports.default=
+}}]);return VictoryZoomContainer;}(base),_class.displayName="VictoryZoomContainer",_class.propTypes=_extends({},_victoryCore.VictoryContainer.propTypes,{allowZoom:_propTypes2.default.bool,clipContainerComponent:_propTypes2.default.element.isRequired,dimension:_propTypes2.default.oneOf(["x","y"]),minimumZoom:_propTypes2.default.shape({x:_propTypes2.default.number,y:_propTypes2.default.number}),onDomainChange:_propTypes2.default.func,zoomDomain:_propTypes2.default.shape({x:_victoryCore.PropTypes.domain,y:_victoryCore.PropTypes.domain})}),_class.defaultProps=_extends({},_victoryCore.VictoryContainer.defaultProps,{clipContainerComponent:_react2.default.createElement(_victoryCore.VictoryClipContainer,{__source:{fileName:_jsxFileName,lineNumber:28}}),allowZoom:true}),_class.defaultEvents=[{target:"parent",eventHandlers:{onMouseDown:function onMouseDown(evt,targetProps){return _zoomHelpers2.default.onMouseDown(evt,targetProps);},onMouseUp:function onMouseUp(evt,targetProps){return _zoomHelpers2.default.onMouseUp(evt,targetProps);},onMouseLeave:function onMouseLeave(evt,targetProps){return _zoomHelpers2.default.onMouseLeave(evt,targetProps);},onMouseMove:function onMouseMove(evt,targetProps,eventKey,ctx){evt.preventDefault();var mutations=_zoomHelpers2.default.onMouseMove(evt,targetProps,eventKey,ctx);if(mutations.id!==_this3.mouseMoveMutationId){_this3.mouseMoveMutationId=mutations.id;return mutations.mutations;}return undefined;},onWheel:function onWheel(evt,targetProps,eventKey,ctx){if(targetProps.allowZoom){evt.preventDefault();}var mutations=_zoomHelpers2.default.onWheel(evt,targetProps,eventKey,ctx);if(mutations.id!==_this3.wheelMutationId){_this3.wheelMutationId=mutations.id;return mutations.mutations;}return undefined;}}}],_temp;};exports.default=
 
 
 zoomContainerMixin(_victoryCore.VictoryContainer);

package.json

 {
   "name": "victory-chart",
-  "version": "21.1.2",
+  "version": "21.1.3",
   "description": "Chart Component for Victory",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/components/containers/victory-zoom-container.js

@@ -56,3 +56,6 @@ import PropTypes from "prop-types";
       onWheel: (evt, targetProps, eventKey, ctx) => { // eslint-disable-line max-params
-        evt.preventDefault();
+        if (targetProps.allowZoom) {
+          evt.preventDefault();
+        }
+
         const mutations = ZoomHelpers.onWheel(evt, targetProps, eventKey, ctx);
@@ -59,0 +62,0 @@

No alert changes

Improved metrics

Total package byte prevSize

1927688

increased by0.01%

Lines of code

34339

increased by0.01%

No dependency changes