victory-core - npm Package Compare versions

Comparing version 13.0.0 to 13.0.1

CHANGELOG.md

 VictoryCore Changelog
 =====================
 
+## 13.0.1 (2017-01-30)
+
+- [193](https://github.com/FormidableLabs/victory-core/pull/193)
+  - Removes the default `standalone: true` from VictoryContainer so that parents can set the value
+
 ## 13.0.0 (2017-01-30)
@@ -8,3 +13,3 @@
   - Adds `VictoryLegend` component
-- [190](https://github.com/FormidableLabs/victory-core/pull/189)
+- [190](https://github.com/FormidableLabs/victory-core/pull/190)
   - Allows `VictoryContainer` to render either `<g>` or `<svg>` depending on the value of the standalone prop
@@ -11,0 +16,0 @@ - Passes a timer down in context for `VictorySharedEvents`

lib/victory-container/victory-container.js

@@ -44,3 +44,2 @@ Object.defineProperty(exports,"__esModule",{value:true});var _omit2=require("lodash/omit");var _omit3=_interopRequireDefault(_omit2);var _assign2=require("lodash/assign");var _assign3=_interopRequireDefault(_assign2);var _extends=Object.assign||function(target){for(var i=1;i<arguments.length;i++){var source=arguments[i];for(var key in source){if(Object.prototype.hasOwnProperty.call(source,key)){target[key]=source[key];}}}return target;};var _createClass=function(){function defineProperties(target,props){for(var i=0;i<props.length;i++){var descriptor=props[i];descriptor.enumerable=descriptor.enumerable||false;descriptor.configurable=true;if("value"in descriptor)descriptor.writable=true;Object.defineProperty(target,descriptor.key,descriptor);}}return function(Constructor,protoProps,staticProps){if(protoProps)defineProperties(Constructor.prototype,protoProps);if(staticProps)defineProperties(Constructor,staticProps);return Constructor;};}();var _react=require("react");var _react2=_interopRequireDefault(_react);
 
-
 function VictoryContainer(props){_classCallCheck(this,VictoryContainer);var _this=_possibleConstructorReturn(this,(VictoryContainer.__proto__||Object.getPrototypeOf(VictoryContainer)).call(this,
@@ -91,3 +90,3 @@ props));
 title=props.title,desc=props.desc,portalComponent=props.portalComponent,className=props.className,standalone=props.standalone;
-return standalone?
+return standalone||standalone===undefined?
 
@@ -114,6 +113,7 @@ _react2.default.createElement("svg",_extends({},svgProps,{style:style,className:className}),
 var style=responsive?this.props.style:(0,_omit3.default)(this.props.style,["height","width"]);
+var useViewBox=responsive?standalone||standalone===undefined:false;
 var svgProps=(0,_assign3.default)(
 {
 "aria-labelledby":"title desc",role:"img",width:width,height:height,
-viewBox:responsive&&standalone?"0 0 "+width+" "+height:undefined},
+viewBox:useViewBox?"0 0 "+width+" "+height:undefined},
 
@@ -123,2 +123,2 @@ events);
 return this.renderContainer(this.props,svgProps,style);
-}}]);return VictoryContainer;}(_react2.default.Component);VictoryContainer.displayName="VictoryContainer";VictoryContainer.propTypes={className:_react.PropTypes.string,style:_react.PropTypes.object,height:_react.PropTypes.number,width:_react.PropTypes.number,events:_react.PropTypes.object,children:_react2.default.PropTypes.oneOfType([_react2.default.PropTypes.arrayOf(_react2.default.PropTypes.node),_react2.default.PropTypes.node]),title:_react.PropTypes.string,desc:_react.PropTypes.string,portalComponent:_react.PropTypes.element,responsive:_react.PropTypes.bool,standalone:_react.PropTypes.bool};VictoryContainer.defaultProps={title:"Victory Chart",desc:"",portalComponent:_react2.default.createElement(_portal2.default,null),responsive:true,standalone:true};VictoryContainer.contextTypes={getTimer:_react2.default.PropTypes.func};VictoryContainer.childContextTypes={portalUpdate:_react2.default.PropTypes.func,portalRegister:_react2.default.PropTypes.func,portalDeregister:_react2.default.PropTypes.func,getTimer:_react2.default.PropTypes.func};exports.default=VictoryContainer;
+}}]);return VictoryContainer;}(_react2.default.Component);VictoryContainer.displayName="VictoryContainer";VictoryContainer.propTypes={className:_react.PropTypes.string,style:_react.PropTypes.object,height:_react.PropTypes.number,width:_react.PropTypes.number,events:_react.PropTypes.object,children:_react2.default.PropTypes.oneOfType([_react2.default.PropTypes.arrayOf(_react2.default.PropTypes.node),_react2.default.PropTypes.node]),title:_react.PropTypes.string,desc:_react.PropTypes.string,portalComponent:_react.PropTypes.element,responsive:_react.PropTypes.bool,standalone:_react.PropTypes.bool};VictoryContainer.defaultProps={title:"Victory Chart",desc:"",portalComponent:_react2.default.createElement(_portal2.default,null),responsive:true};VictoryContainer.contextTypes={getTimer:_react2.default.PropTypes.func};VictoryContainer.childContextTypes={portalUpdate:_react2.default.PropTypes.func,portalRegister:_react2.default.PropTypes.func,portalDeregister:_react2.default.PropTypes.func,getTimer:_react2.default.PropTypes.func};exports.default=VictoryContainer;

package.json

 {
   "name": "victory-core",
-  "version": "13.0.0",
+  "version": "13.0.1",
   "description": "Victory Core",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/victory-container/victory-container.js

@@ -30,4 +30,3 @@ import React, { PropTypes } from "react";
     portalComponent: <Portal/>,
-    responsive: true,
-    standalone: true
+    responsive: true
   }
@@ -91,3 +90,3 @@
     const { title, desc, portalComponent, className, standalone } = props;
-    return standalone ?
+    return standalone || standalone === undefined ?
       (
@@ -114,6 +113,7 @@ <svg {...svgProps} style={style} className={className}>
     const style = responsive ? this.props.style : omit(this.props.style, ["height", "width"]);
+    const useViewBox = responsive ? standalone || standalone === undefined : false;
     const svgProps = assign(
       {
         "aria-labelledby": "title desc", role: "img", width, height,
-        viewBox: responsive && standalone ? `0 0 ${width} ${height}` : undefined
+        viewBox: useViewBox ? `0 0 ${width} ${height}` : undefined
       },
@@ -120,0 +120,0 @@ events

No alert changes

Improved metrics

Total package byte prevSize

1255289

increased by0.03%

Lines of code

24950

increased by0.01%

No dependency changes