victory-errorbar - npm Package Compare versions

Comparing version 36.4.1 to 36.5.0

es/error-bar.js

@@ -12,3 +12,3 @@ import _assign from "lodash/assign";
 import PropTypes from "prop-types";
-import { Helpers, CommonProps, Line } from "victory-core";
+import { Helpers, CommonProps, Line, UserProps } from "victory-core";
 
@@ -27,3 +27,4 @@ var renderBorder = function (props, error, type) {
     y1: vertical ? props.y - props.borderWidth : error[type],
-    y2: vertical ? props.y + props.borderWidth : error[type]
+    y2: vertical ? props.y + props.borderWidth : error[type],
+    "data-type": "border-".concat(type)
   }));
@@ -44,3 +45,4 @@ };
     y1: props.y,
-    y2: vertical ? error[type] : props.y
+    y2: vertical ? error[type] : props.y,
+    "data-type": "cross-".concat(type)
   }));
@@ -109,11 +111,12 @@ };
   props = evaluateProps(props);
+  var userProps = UserProps.getSafeUserProps(props);
   var _props = props,
-      ariaLabel = _props.ariaLabel,
-      tabIndex = _props.tabIndex;
+      tabIndex = _props.tabIndex,
+      ariaLabel = _props.ariaLabel;
   var error = calculateError(props);
   var children = [error.right ? renderBorder(props, error, "right") : null, error.left ? renderBorder(props, error, "left") : null, error.bottom ? renderBorder(props, error, "bottom") : null, error.top ? renderBorder(props, error, "top") : null, error.right ? renderCross(props, error, "right") : null, error.left ? renderCross(props, error, "left") : null, error.bottom ? renderCross(props, error, "bottom") : null, error.top ? renderCross(props, error, "top") : null].filter(Boolean);
-  return /*#__PURE__*/React.cloneElement(props.groupComponent, {
-    "aria-label": ariaLabel,
-    tabIndex: tabIndex
-  }, children);
+  return /*#__PURE__*/React.cloneElement(props.groupComponent, _objectSpread({
+    tabIndex: tabIndex,
+    "aria-label": ariaLabel
+  }, userProps), children);
 };
@@ -120,0 +123,0 @@

es/victory-errorbar.js

@@ -5,2 +5,4 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
 function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
@@ -14,3 +16,3 @@
 
-function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
+function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf ? Object.setPrototypeOf.bind() : function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
 
@@ -25,6 +27,4 @@ function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }
 
-function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
+function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf.bind() : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
 
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
 import PropTypes from "prop-types";
@@ -99,11 +99,7 @@ import React from "react";
 
-_defineProperty(VictoryErrorBar, "animationWhitelist", ["data", "domain", "height", "padding", "samples", "style", "width", "errorX", "errorY", "borderWidth"]);
-
-_defineProperty(VictoryErrorBar, "displayName", "VictoryErrorBar");
-
-_defineProperty(VictoryErrorBar, "role", "errorbar");
-
-_defineProperty(VictoryErrorBar, "defaultTransitions", DefaultTransitions.discreteTransitions());
-
-_defineProperty(VictoryErrorBar, "propTypes", _objectSpread(_objectSpread(_objectSpread({}, CommonProps.baseProps), CommonProps.dataProps), {}, {
+VictoryErrorBar.animationWhitelist = ["data", "domain", "height", "padding", "samples", "style", "width", "errorX", "errorY", "borderWidth"];
+VictoryErrorBar.displayName = "VictoryErrorBar";
+VictoryErrorBar.role = "errorbar";
+VictoryErrorBar.defaultTransitions = DefaultTransitions.discreteTransitions();
+VictoryErrorBar.propTypes = _objectSpread(_objectSpread(_objectSpread({}, CommonProps.baseProps), CommonProps.dataProps), {}, {
   borderWidth: PropTypes.number,
@@ -113,5 +109,4 @@ errorX: PropTypes.oneOfType([PropTypes.func, CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]), PropTypes.string, PropTypes.arrayOf(PropTypes.string)]),
   horizontal: PropTypes.bool
-}));
-
-_defineProperty(VictoryErrorBar, "defaultProps", {
+});
+VictoryErrorBar.defaultProps = {
   containerComponent: /*#__PURE__*/React.createElement(VictoryContainer, null),
@@ -128,14 +123,11 @@ data: defaultData,
   theme: VictoryTheme.grayscale
-});
+};
+VictoryErrorBar.getDomain = getDomain;
+VictoryErrorBar.getData = getData;
 
-_defineProperty(VictoryErrorBar, "getDomain", getDomain);
-
-_defineProperty(VictoryErrorBar, "getData", getData);
-
-_defineProperty(VictoryErrorBar, "getBaseProps", function (props) {
+VictoryErrorBar.getBaseProps = function (props) {
   return getBaseProps(props, fallbackProps);
-});
+};
 
-_defineProperty(VictoryErrorBar, "expectedComponents", ["dataComponent", "labelComponent", "groupComponent", "containerComponent"]);
-
+VictoryErrorBar.expectedComponents = ["dataComponent", "labelComponent", "groupComponent", "containerComponent"];
 export default addEvents(VictoryErrorBar);

lib/error-bar.js

@@ -36,3 +36,4 @@ "use strict";
     y1: vertical ? props.y - props.borderWidth : error[type],
-    y2: vertical ? props.y + props.borderWidth : error[type]
+    y2: vertical ? props.y + props.borderWidth : error[type],
+    "data-type": "border-".concat(type)
   }));
@@ -53,3 +54,4 @@ };
     y1: props.y,
-    y2: vertical ? error[type] : props.y
+    y2: vertical ? error[type] : props.y,
+    "data-type": "cross-".concat(type)
   }));
@@ -122,11 +124,14 @@ };
   props = evaluateProps(props);
+
+  var userProps = _victoryCore.UserProps.getSafeUserProps(props);
+
   var _props = props,
-      ariaLabel = _props.ariaLabel,
-      tabIndex = _props.tabIndex;
+      tabIndex = _props.tabIndex,
+      ariaLabel = _props.ariaLabel;
   var error = calculateError(props);
   var children = [error.right ? renderBorder(props, error, "right") : null, error.left ? renderBorder(props, error, "left") : null, error.bottom ? renderBorder(props, error, "bottom") : null, error.top ? renderBorder(props, error, "top") : null, error.right ? renderCross(props, error, "right") : null, error.left ? renderCross(props, error, "left") : null, error.bottom ? renderCross(props, error, "bottom") : null, error.top ? renderCross(props, error, "top") : null].filter(Boolean);
-  return /*#__PURE__*/_react.default.cloneElement(props.groupComponent, {
-    "aria-label": ariaLabel,
-    tabIndex: tabIndex
-  }, children);
+  return /*#__PURE__*/_react.default.cloneElement(props.groupComponent, _objectSpread({
+    tabIndex: tabIndex,
+    "aria-label": ariaLabel
+  }, userProps), children);
 };
@@ -133,0 +138,0 @@

lib/victory-errorbar.js

@@ -24,2 +24,4 @@ "use strict";
 
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
 function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
@@ -33,3 +35,3 @@
 
-function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
+function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf ? Object.setPrototypeOf.bind() : function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
 
@@ -44,6 +46,4 @@ function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }
 
-function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
+function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf.bind() : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
 
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
 var fallbackProps = {
@@ -114,11 +114,7 @@ width: 450,
 
-_defineProperty(VictoryErrorBar, "animationWhitelist", ["data", "domain", "height", "padding", "samples", "style", "width", "errorX", "errorY", "borderWidth"]);
-
-_defineProperty(VictoryErrorBar, "displayName", "VictoryErrorBar");
-
-_defineProperty(VictoryErrorBar, "role", "errorbar");
-
-_defineProperty(VictoryErrorBar, "defaultTransitions", _victoryCore.DefaultTransitions.discreteTransitions());
-
-_defineProperty(VictoryErrorBar, "propTypes", _objectSpread(_objectSpread(_objectSpread({}, _victoryCore.CommonProps.baseProps), _victoryCore.CommonProps.dataProps), {}, {
+VictoryErrorBar.animationWhitelist = ["data", "domain", "height", "padding", "samples", "style", "width", "errorX", "errorY", "borderWidth"];
+VictoryErrorBar.displayName = "VictoryErrorBar";
+VictoryErrorBar.role = "errorbar";
+VictoryErrorBar.defaultTransitions = _victoryCore.DefaultTransitions.discreteTransitions();
+VictoryErrorBar.propTypes = _objectSpread(_objectSpread(_objectSpread({}, _victoryCore.CommonProps.baseProps), _victoryCore.CommonProps.dataProps), {}, {
   borderWidth: _propTypes.default.number,
@@ -128,5 +124,4 @@ errorX: _propTypes.default.oneOfType([_propTypes.default.func, _victoryCore.PropTypes.allOfType([_victoryCore.PropTypes.integer, _victoryCore.PropTypes.nonNegative]), _propTypes.default.string, _propTypes.default.arrayOf(_propTypes.default.string)]),
   horizontal: _propTypes.default.bool
-}));
-
-_defineProperty(VictoryErrorBar, "defaultProps", {
+});
+VictoryErrorBar.defaultProps = {
   containerComponent: /*#__PURE__*/_react.default.createElement(_victoryCore.VictoryContainer, null),
@@ -143,13 +138,11 @@ data: defaultData,
   theme: _victoryCore.VictoryTheme.grayscale
-});
+};
+VictoryErrorBar.getDomain = _helperMethods.getDomain;
+VictoryErrorBar.getData = _helperMethods.getData;
 
-_defineProperty(VictoryErrorBar, "getDomain", _helperMethods.getDomain);
-
-_defineProperty(VictoryErrorBar, "getData", _helperMethods.getData);
-
-_defineProperty(VictoryErrorBar, "getBaseProps", function (props) {
+VictoryErrorBar.getBaseProps = function (props) {
   return (0, _helperMethods.getBaseProps)(props, fallbackProps);
-});
+};
 
-_defineProperty(VictoryErrorBar, "expectedComponents", ["dataComponent", "labelComponent", "groupComponent", "containerComponent"]);
+VictoryErrorBar.expectedComponents = ["dataComponent", "labelComponent", "groupComponent", "containerComponent"];
 
@@ -156,0 +149,0 @@ var _default = (0, _victoryCore.addEvents)(VictoryErrorBar);

package.json

 {
   "name": "victory-errorbar",
-  "version": "36.4.1",
+  "version": "36.5.0",
   "description": "Error Bar Component for Victory",
@@ -24,6 +24,6 @@ "keywords": [
     "prop-types": "^15.8.1",
-    "victory-core": "^36.4.1"
+    "victory-core": "^36.5.0"
   },
   "peerDependencies": {
-    "react": "^16.6.0 || ^17.0.0"
+    "react": ">=16.6.0"
   },
@@ -34,3 +34,3 @@ "scripts": {
   "sideEffects": false,
-  "gitHead": "aa44a22e5a93989773a560f765f83ac151f44c46"
+  "gitHead": "7cecba921f751c3decc8215f7e866f51d11203c1"
 }

src/error-bar.js

 /* eslint-disable max-statements */
 import React from "react";
 import PropTypes from "prop-types";
-import { Helpers, CommonProps, Line } from "victory-core";
+import { Helpers, CommonProps, Line, UserProps } from "victory-core";
 import { assign } from "lodash";
@@ -20,3 +20,4 @@
     y1: vertical ? props.y - props.borderWidth : error[type],
-    y2: vertical ? props.y + props.borderWidth : error[type]
+    y2: vertical ? props.y + props.borderWidth : error[type],
+    "data-type": `border-${type}`
   });
@@ -38,3 +39,4 @@ };
     y1: props.y,
-    y2: vertical ? error[type] : props.y
+    y2: vertical ? error[type] : props.y,
+    "data-type": `cross-${type}`
   });
@@ -85,3 +87,4 @@ };
   props = evaluateProps(props);
-  const { ariaLabel, tabIndex } = props;
+  const userProps = UserProps.getSafeUserProps(props);
+  const { tabIndex, ariaLabel } = props;
   const error = calculateError(props);
@@ -100,3 +103,3 @@ const children = [
     props.groupComponent,
-    { "aria-label": ariaLabel, tabIndex },
+    { tabIndex, "aria-label": ariaLabel, ...userProps },
     children
@@ -103,0 +106,0 @@ );

No alert changes

Improved metrics

Lines of code

19532

increased by0.18%

Worsened metrics

Total package byte prevSize

1096438

decreased by-0.03%

Dependency changes

• + Addedreact@19.0.0(transitive)

• - Removedreact@17.0.2(transitive)

• Updatedvictory-core@^36.5.0