victory-selection-container - npm Package Compare versions

Comparing version 36.8.2 to 36.8.3

CHANGELOG.md

 # victory-selection-container
 
+## 36.8.3
+
+### Patch Changes
+
+- Refactor param reassignments ([#2724](https://github.com/FormidableLabs/victory/pull/2724))
+
 ## 36.8.2
@@ -4,0 +10,0 @@

es/selection-helpers.js

@@ -217,2 +217,3 @@ import _includes from "lodash/includes";
         var blacklist = props.selectionBlacklist || [];
+        var childElement;
 
@@ -222,5 +223,5 @@ if (!Data.isDataComponent(child) || _includes(blacklist, childName)) {
         } else if (child.type && _isFunction(child.type.getData)) {
-          child = parent ? /*#__PURE__*/React.cloneElement(child, parent.props) : child;
+          childElement = parent ? /*#__PURE__*/React.cloneElement(child, parent.props) : child;
 
-          var _childData = child.props && child.type.getData(child.props);
+          var _childData = childElement.props && childElement.type.getData(childElement.props);
 
@@ -233,3 +234,3 @@ return _childData ? {
 
-        var childData = getData(child.props);
+        var childData = getData(childElement.props);
         return childData ? {
@@ -251,3 +252,3 @@ childName: childName,
 
-        memo = selectedData ? memo.concat({
+        return selectedData ? memo.concat({
           childName: dataset.childName,
@@ -257,3 +258,2 @@ eventKey: selectedData.eventKey,
         }) : memo;
-        return memo;
       }, []);
@@ -260,0 +260,0 @@ return filtered.length ? filtered : null;

lib/selection-helpers.js

@@ -233,2 +233,3 @@ "use strict";
         var blacklist = props.selectionBlacklist || [];
+        var childElement;
 
@@ -238,5 +239,5 @@ if (!_victoryCore.Data.isDataComponent(child) || (0, _includes2.default)(blacklist, childName)) {
         } else if (child.type && (0, _isFunction2.default)(child.type.getData)) {
-          child = parent ? /*#__PURE__*/_react.default.cloneElement(child, parent.props) : child;
+          childElement = parent ? /*#__PURE__*/_react.default.cloneElement(child, parent.props) : child;
 
-          var _childData = child.props && child.type.getData(child.props);
+          var _childData = childElement.props && childElement.type.getData(childElement.props);
 
@@ -249,3 +250,3 @@ return _childData ? {
 
-        var childData = getData(child.props);
+        var childData = getData(childElement.props);
         return childData ? {
@@ -267,3 +268,3 @@ childName: childName,
 
-        memo = selectedData ? memo.concat({
+        return selectedData ? memo.concat({
           childName: dataset.childName,
@@ -273,3 +274,2 @@ eventKey: selectedData.eventKey,
         }) : memo;
-        return memo;
       }, []);
@@ -276,0 +276,0 @@ return filtered.length ? filtered : null;

package.json

 {
   "name": "victory-selection-container",
-  "version": "36.8.2",
+  "version": "36.8.3",
   "description": "Interactive Selection Component for Victory",
@@ -25,3 +25,3 @@ "keywords": [
     "prop-types": "^15.8.1",
-    "victory-core": "^36.8.2"
+    "victory-core": "^36.8.3"
   },
@@ -32,3 +32,3 @@ "peerDependencies": {
   "devDependencies": {
-    "victory-bar": "^36.8.2",
+    "victory-bar": "^36.8.3",
     "victory-selection-container": "*"
@@ -35,0 +35,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

781741

increased by0.12%

Lines of code

14160

increased by0.1%

Dependency changes

• Updatedvictory-core@^36.8.3