videojs-record - npm Package Compare versions

Comparing version 0.3.0 to 0.4.0

bower.json

 {
   "name": "videojs-record",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "homepage": "https://github.com/collab-project/videojs-record",
@@ -5,0 +5,0 @@ "description": "A video.js plugin for recording audio/video files.",

package.json

 {
   "name": "videojs-record",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "A video.js plugin for recording audio/video files.",
@@ -5,0 +5,0 @@ "main": "src/js/videojs.record.js",

src/js/videojs.record.js

@@ -49,4 +49,3 @@ (function(window, videojs) {
                 case this.AUDIO_ONLY:
-                    // XXX: enable videojs-wavesurfer plugin automatically?
-
+                    // reference to videojs-wavesurfer plugin
                     this.surfer = player.waveform;
@@ -76,4 +75,5 @@
                         // videojs automatically hides the controls when no valid 'source'
-                        // element is included in the 'audio' tag. Don't.
+                        // element is included in the 'audio' tag. Don't. Ever again.
                         this.player().controlBar.show();
+                        this.player().controlBar.el().style.display = 'block';
 
@@ -179,6 +179,13 @@ // disable currentTimeDisplay's 'timeupdate' event listener that
             this.player().controlBar.liveDisplay.hide();
-            this.player().controlBar.currentTimeDisplay.show();
-            this.player().controlBar.timeDivider.show();
-            this.player().controlBar.durationDisplay.show();
 
+            // show elements that should never be hidden
+            var uiElements = [this.player().controlBar.currentTimeDisplay,
+                              this.player().controlBar.timeDivider,
+                              this.player().controlBar.durationDisplay];
+            for (var element in uiElements)
+            {
+                uiElements[element].el().style.display = 'block';
+                uiElements[element].show();
+            }
+
             // setup preview
@@ -749,2 +756,3 @@ switch (this.getRecordType())
         });
+        player.recordIndicator.hide();
         player.recorder.el().appendChild(player.recordIndicator.el());
@@ -751,0 +759,0 @@

No alert changes

Improved metrics

Lines of code

1074

increased by0.66%

Worsened metrics

Total package byte prevSize

162401

decreased by-1.37%

No dependency changes