vpaid-html5-client - npm Package Compare versions

Comparing version 0.1.8 to 0.1.9

bin/VPAIDHTML5Client.js

@@ -741,5 +741,8 @@ (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 Subscriber.prototype.trigger = function(eventName, data) {
-    this.get(eventName).forEach(function (subscriber) {
+    var that = this;
+    that.get(eventName).forEach(function (subscriber) {
         setTimeout(function () {
-            subscriber.handler.call(subscriber.context, data);
+            if (that.get(eventName)) {
+                subscriber.handler.call(subscriber.context, data);
+            }
         }, 0);
@@ -746,0 +749,0 @@ });

bower.json

 {
   "name": "VPAIDHTML5Client",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "homepage": "https://github.com/MailOnline/VPAIDHTML5Client",
@@ -5,0 +5,0 @@ "authors": [

js/subscriber.js

@@ -22,5 +22,8 @@ 'use strict';
 Subscriber.prototype.trigger = function(eventName, data) {
-    this.get(eventName).forEach(function (subscriber) {
+    var that = this;
+    that.get(eventName).forEach(function (subscriber) {
         setTimeout(function () {
-            subscriber.handler.call(subscriber.context, data);
+            if (that.get(eventName)) {
+                subscriber.handler.call(subscriber.context, data);
+            }
         }, 0);
@@ -27,0 +30,0 @@ });

package.json

 {
   "name": "vpaid-html5-client",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "description": "VPAID HTML5",
@@ -5,0 +5,0 @@ "main": [

test/fixtures/simpleVPAIDAd.js

@@ -9,3 +9,2 @@ var IVPAIDAdUnit = require('../../js/IVPAIDAdUnit');
     LinearAd.prototype[key] = function () {
-        console.log('method called:', key);
     }
@@ -12,0 +11,0 @@ });

test/integration/VPAIDHTML5Client.spec.js

@@ -108,3 +108,3 @@ 'use strict';
 
-            it.only('must call callback after resizeAd is called', function(done) {
+            it('must call callback after resizeAd is called', function(done) {
                 var callback = sinon.spy(function() {
@@ -111,0 +111,0 @@ done();

test/unit/VPAIDAdUnit.spec.js

@@ -128,3 +128,4 @@ var noop = require('../testHelper').noop;
                 'initAd',
-                'handshakeVersion'
+                'handshakeVersion',
+                'resizeAd'
             ];
@@ -131,0 +132,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

143308

increased by0.16%

Lines of code

3080

increased by0.2%

No dependency changes