vscode-languageclient - npm Package Compare versions

Comparing version 8.1.0-next.1 to 8.1.0-next.2

lib/common/client.d.ts

 import { TextDocument, Disposable, OutputChannel, DiagnosticCollection, Diagnostic as VDiagnostic, Uri, CancellationToken, WorkspaceFolder as VWorkspaceFolder, FileCreateEvent, FileRenameEvent, FileDeleteEvent, FileWillCreateEvent, FileWillRenameEvent, FileWillDeleteEvent, CompletionItemProvider, HoverProvider, SignatureHelpProvider, DefinitionProvider, ReferenceProvider, DocumentHighlightProvider, CodeActionProvider, DocumentFormattingEditProvider, DocumentRangeFormattingEditProvider, OnTypeFormattingEditProvider, RenameProvider, DocumentSymbolProvider, DocumentLinkProvider, DeclarationProvider, FoldingRangeProvider, ImplementationProvider, DocumentColorProvider, SelectionRangeProvider, TypeDefinitionProvider, CallHierarchyProvider, LinkedEditingRangeProvider, TypeHierarchyProvider, WorkspaceSymbolProvider, ProviderResult, TextEdit as VTextEdit } from 'vscode';
-import { Message, MessageSignature, ResponseError, RequestType0, RequestType, NotificationType0, NotificationType, ProtocolRequestType, ProtocolRequestType0, RequestHandler, RequestHandler0, GenericRequestHandler, ProtocolNotificationType, ProtocolNotificationType0, NotificationHandler, NotificationHandler0, GenericNotificationHandler, MessageReader, MessageWriter, Trace, Event, InitializeParams, InitializeResult, DocumentSelector, DidChangeTextDocumentNotification, FileEvent, ProgressType, ProgressToken, ShowDocumentRequest, ShowDocumentParams, ShowDocumentResult, CancellationStrategy, InitializeError, WorkDoneProgressBegin, WorkDoneProgressReport, WorkDoneProgressEnd, DidOpenTextDocumentNotification, WillSaveTextDocumentNotification, WillSaveTextDocumentWaitUntilRequest, DidSaveTextDocumentNotification, DidCloseTextDocumentNotification, DidCreateFilesNotification, DidRenameFilesNotification, DidDeleteFilesNotification, WillRenameFilesRequest, WillCreateFilesRequest, WillDeleteFilesRequest, CompletionRequest, HoverRequest, SignatureHelpRequest, DefinitionRequest, ReferencesRequest, DocumentHighlightRequest, CodeActionRequest, CodeLensRequest, DocumentFormattingRequest, DocumentRangeFormattingRequest, DocumentOnTypeFormattingRequest, RenameRequest, DocumentSymbolRequest, DocumentLinkRequest, DocumentColorRequest, DeclarationRequest, FoldingRangeRequest, ImplementationRequest, SelectionRangeRequest, TypeDefinitionRequest, CallHierarchyPrepareRequest, SemanticTokensRegistrationType, LinkedEditingRangeRequest, TypeHierarchyPrepareRequest, InlineValueRequest, InlayHintRequest, WorkspaceSymbolRequest, TextDocumentRegistrationOptions, FileOperationRegistrationOptions, DocumentDiagnosticRequest, NotebookDocumentSyncRegistrationType, NotebookDocumentSyncRegistrationOptions } from 'vscode-languageserver-protocol';
+import { Message, MessageSignature, ResponseError, RequestType0, RequestType, NotificationType0, NotificationType, ProtocolRequestType, ProtocolRequestType0, RequestHandler, RequestHandler0, GenericRequestHandler, ProtocolNotificationType, ProtocolNotificationType0, NotificationHandler, NotificationHandler0, GenericNotificationHandler, MessageReader, MessageWriter, Trace, Event, InitializeParams, InitializeResult, DocumentSelector, DidChangeTextDocumentNotification, FileEvent, ProgressType, ProgressToken, ShowDocumentRequest, ShowDocumentParams, ShowDocumentResult, CancellationStrategy, InitializeError, WorkDoneProgressBegin, WorkDoneProgressReport, WorkDoneProgressEnd, DidOpenTextDocumentNotification, WillSaveTextDocumentNotification, WillSaveTextDocumentWaitUntilRequest, DidSaveTextDocumentNotification, DidCloseTextDocumentNotification, DidCreateFilesNotification, DidRenameFilesNotification, DidDeleteFilesNotification, WillRenameFilesRequest, WillCreateFilesRequest, WillDeleteFilesRequest, CompletionRequest, HoverRequest, SignatureHelpRequest, DefinitionRequest, ReferencesRequest, DocumentHighlightRequest, CodeActionRequest, CodeLensRequest, DocumentFormattingRequest, DocumentRangeFormattingRequest, DocumentOnTypeFormattingRequest, RenameRequest, DocumentSymbolRequest, DocumentLinkRequest, DocumentColorRequest, DeclarationRequest, FoldingRangeRequest, ImplementationRequest, SelectionRangeRequest, TypeDefinitionRequest, CallHierarchyPrepareRequest, SemanticTokensRegistrationType, LinkedEditingRangeRequest, TypeHierarchyPrepareRequest, InlineValueRequest, InlayHintRequest, WorkspaceSymbolRequest, TextDocumentRegistrationOptions, FileOperationRegistrationOptions, DocumentDiagnosticRequest, NotebookDocumentSyncRegistrationType, NotebookDocumentSyncRegistrationOptions, MessageStrategy } from 'vscode-languageserver-protocol';
 import * as c2p from './codeConverter';
@@ -233,3 +233,4 @@ import * as p2c from './protocolConverter';
     connectionOptions?: {
-        cancellationStrategy: CancellationStrategy;
+        cancellationStrategy?: CancellationStrategy;
+        messageStrategy?: MessageStrategy;
         maxRestartCount?: number;
@@ -236,0 +237,0 @@ };

lib/common/configuration.d.ts

@@ -56,2 +56,3 @@ import { FileSystemWatcher as VFileSystemWatcher, WorkspaceFolder as VWorkspaceFolder } from 'vscode';
     private _client;
+    private isDisposed;
     private readonly _listeners;
@@ -58,0 +59,0 @@ constructor(_client: FeatureClient<DidChangeConfigurationWorkspaceMiddleware, $ConfigurationOptions>);

lib/common/configuration.js

@@ -97,2 +97,3 @@ "use strict";
         this._client = _client;
+        this.isDisposed = false;
         this._listeners = new Map();
@@ -141,4 +142,8 @@ }
         this._listeners.clear();
+        this.isDisposed = true;
     }
     onDidChangeConfiguration(configurationSection, event) {
+        if (this.isDisposed) {
+            return;
+        }
         let sections;
@@ -145,0 +150,0 @@ if (Is.string(configurationSection)) {

lib/common/diagnostic.d.ts

@@ -80,4 +80,7 @@ import { Disposable, CancellationToken, ProviderResult, Diagnostic as VDiagnostic, TextDocument, Event as VEvent, EventEmitter, Uri } from 'vscode';
      *
-     * @param document the document that changed or got saved
-     * @param mode the mode
+     * The document gets filtered if the method returns `true`.
+     *
+     * @param document The document that changed or got saved.
+     * @param mode The pull mode.
+     * @returns whether the document should be filtered (`true`) or not.
      */
@@ -97,4 +100,8 @@ filter?(document: TextDocument, mode: DiagnosticPullMode): boolean;
      *
-     * @param documentSelector the document selector
-     * @param resource the resource
+     * The method should return `true` if the document selector matches the
+     * given resource. See also the `vscode.languages.match` function.
+     *
+     * @param documentSelector The document selector.
+     * @param resource The resource.
+     * @returns whether the resource is matched by the given document selector.
      */
@@ -101,0 +108,0 @@ match?(documentSelector: DocumentSelector, resource: Uri): boolean;

lib/common/features.js

@@ -120,3 +120,3 @@ "use strict";
             const params = this._createParams(data);
-            await this._client.sendNotification(this._type, params).catch();
+            await this._client.sendNotification(this._type, params);
             this.notificationSent(data, this._type, params);
@@ -123,0 +123,0 @@ };

lib/common/textSynchronization.d.ts

@@ -47,3 +47,4 @@ import { TextDocument, TextDocumentChangeEvent, TextDocumentWillSaveEvent, TextEdit as VTextEdit, DocumentSelector as VDocumentSelector, Event } from 'vscode';
     private readonly _onNotificationSent;
-    constructor(client: FeatureClient<TextDocumentSynchronizationMiddleware>);
+    private readonly _syncedDocuments;
+    constructor(client: FeatureClient<TextDocumentSynchronizationMiddleware>, syncedDocuments: Map<string, TextDocument>);
     get registrationType(): RegistrationType<TextDocumentChangeRegistrationOptions>;
@@ -50,0 +51,0 @@ fillClientCapabilities(capabilities: ClientCapabilities): void;

lib/common/textSynchronization.js

@@ -105,3 +105,3 @@ "use strict";
 class DidChangeTextDocumentFeature extends features_1.DynamicDocumentFeature {
-    constructor(client) {
+    constructor(client, syncedDocuments) {
         super(client);
@@ -111,2 +111,3 @@ this._forcingDelivery = false;
         this._onNotificationSent = new vscode_1.EventEmitter();
+        this._syncedDocuments = syncedDocuments;
     }
@@ -230,3 +231,6 @@ get registrationType() {
     async forceDelivery() {
-        if (this._forcingDelivery || !this._changeDelayer) {
+        // See https://github.com/microsoft/vscode-languageserver-node/issues/1105
+        // If we have a change delayer and its URI is not yet synced then the open
+        // event has not been delivered yet. So don't force the sync.
+        if (this._forcingDelivery || !this._changeDelayer || !this._syncedDocuments.has(this._changeDelayer.uri)) {
             return;
@@ -233,0 +237,0 @@ }

lib/common/workspaceFolder.js

@@ -12,3 +12,3 @@ "use strict";
 function access(target, key) {
-    if (target === void 0) {
+    if (target === undefined || target === null) {
         return undefined;
@@ -15,0 +15,0 @@ }

package.json

 {
 	"name": "vscode-languageclient",
 	"description": "VSCode Language client implementation",
-	"version": "8.1.0-next.1",
+	"version": "8.1.0-next.2",
 	"author": "Microsoft Corporation",
@@ -33,7 +33,7 @@ "license": "MIT",
 		"semver": "^7.3.7",
-		"vscode-languageserver-protocol": "3.17.3-next.1"
+		"vscode-languageserver-protocol": "3.17.3-next.2"
 	},
 	"scripts": {
-		"prepublishOnly": "git clean -xfd . && npm install && npm run clean && node ./bin/updateVSCode.js && npm run compile && npm test",
-		"postpublish": "node ../build/npm/post-publish.js",
+		"prepublishOnly": "echo \"⛔ Can only publish from a secure pipeline ⛔\" && node ../build/npm/fail",
+		"prepack": "git clean -xfd . && npm install && node ./bin/updateVSCode.js && npm run all:pack",
 		"compile": "node ../build/bin/tsc -b ./tsconfig.json && shx cp src/node/terminateProcess.sh lib/node/terminateProcess.sh",
@@ -45,2 +45,4 @@ "compile:clean": "git clean -xfd . && npm install && npm run clean && npm run compile",
 		"clean": "node ../node_modules/rimraf/bin.js lib",
+		"all": "npm run clean && npm run compile && npm run lint && npm test",
+		"all:pack": "npm run clean && npm run compile && npm run lint && cd ../client-node-tests && npm run all:pack && cd ..",
 		"preversion": "npm test",
@@ -47,0 +49,0 @@ "updateVSCodeVersion": "node ./bin/updateVSCode.js"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

642385

increased by0.19%

Lines of code

12546

increased by0.15%

Worsened metrics

Number of medium supply chain risk alerts

3

increased by50%

Dependency changes

• + Addedvscode-jsonrpc@8.1.0-next.3(transitive)

• + Addedvscode-languageserver-protocol@3.17.3-next.2(transitive)

• - Removedvscode-jsonrpc@8.1.0-next.1(transitive)

• - Removedvscode-languageserver-protocol@3.17.3-next.1(transitive)

• Updatedvscode-languageserver-protocol@3.17.3-next.2