webrtc-conductor - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

package.json

 {
   "name": "webrtc-conductor",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "A lightweight module to allow for efficient management, creation, reuse and destruction of WebRTC DataChannels.",
@@ -5,0 +5,0 @@ "main": "src/wrtc-res-man.js",

README.md

@@ -86,2 +86,5 @@ # WebRTC Conductor [![Build Status](https://travis-ci.org/FelixMcFelix/webrtc-conductor.svg)](https://travis-ci.org/FelixMcFelix/webrtc-conductor) [![Code Climate](https://codeclimate.com/github/FelixMcFelix/webrtc-conductor/badges/gpa.svg)](https://codeclimate.com/github/FelixMcFelix/webrtc-conductor)
 
+### 0.1.3
+* Addition of simple .close() method on connections. This closes a connection for real, and is not intelligently managed.
+
 ### 0.1.2
@@ -88,0 +91,0 @@ * Change of dependencies to get webrtc-adapter-test from the official git now that API changes have been merged.

src/wrtc-res-man.js

@@ -385,3 +385,5 @@ "use strict";
 		// before TTL
-		// TODO
+		// TODO - closes for real right now.
+
+		this.connection.close();
 	};
@@ -388,0 +390,0 @@

test/test.js

@@ -135,107 +135,107 @@ var expect = require("chai").expect,
 	describe("Active Connections", () => {
-		var wrtc, manager;
+	// 	var wrtc, manager;
 
-		before("check to see if we have a usable webrtc stack", ()=>{
-			wrtc = require("wrtc");
-		});
+	// 	before("check to see if we have a usable webrtc stack", ()=>{
+	// 		wrtc = require("wrtc");
+	// 	});
 
-		beforeEach(() => {
-			manager = resMan.create({
-				rtc_facade: wrtc,
-				channel: {
-					internalID: "stub",
-					send: (a,b,c) => {},
-					onmessage: (a,b) => {}
-				} // TODO
-			});
-		});
+	// 	beforeEach(() => {
+	// 		manager = resMan.create({
+	// 			rtc_facade: wrtc,
+	// 			channel: {
+	// 				internalID: "stub",
+	// 				send: (a,b,c) => {},
+	// 				onmessage: (a,b) => {}
+	// 			} // TODO
+	// 		});
+	// 	});
 
-		describe("Connection Creation", () => {
-			it("should call the onconnection handler if a connection is opened by another client", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 	describe("Connection Creation", () => {
+	// 		it("should call the onconnection handler if a connection is opened by another client", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should return the TrackedConnection instance as part of the promise after .connectTo(...)", () => {
-				//TODO
-				expect(true).false;
-			});
-		});
+	// 		it("should return the TrackedConnection instance as part of the promise after .connectTo(...)", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
+	// 	});
 
-		describe("Connection Fetching", () => {
-			it("should return the connection with a matching name if one exists", () => {
-				//TODO
-				expect(true).false;
-			});
-		});
+	// 	describe("Connection Fetching", () => {
+	// 		it("should return the connection with a matching name if one exists", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
+	// 	});
 
-		describe("Data Channel Management", () => {
-			it("should register a new datachannel when prompted by partner", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 	describe("Data Channel Management", () => {
+	// 		it("should register a new datachannel when prompted by partner", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should close and overwrite the datachannel if one with a duplicate name is registered", () => {
-				//TODO
-				expect(true).false;
-			});
-		});
+	// 		it("should close and overwrite the datachannel if one with a duplicate name is registered", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
+	// 	});
 
-		describe("Connection Usage", ()=>{
-			it("should send along the default channel when calling send on a TrackedConnection", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 	describe("Connection Usage", ()=>{
+	// 		it("should send along the default channel when calling send on a TrackedConnection", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should send along the specified channel when calling send with a label on a TrackedConnection", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 		it("should send along the specified channel when calling send with a label on a TrackedConnection", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should set event handlers on the default connection when no label is specified", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 		it("should set event handlers on the default connection when no label is specified", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should set event handlers on the specified connection when a label is specified", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 		it("should set event handlers on the specified connection when a label is specified", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should fire the onmessage event if the partner sends a message", () => {
-				//TODO
-				expect(true).false;
-			});
-		});
+	// 		it("should fire the onmessage event if the partner sends a message", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
+	// 	});
 
-		describe("Response Delegation", () => {
-			it("should pass down the chain of response handlers for several connected singalling channels", () => {
-				//TODO
-				expect(true).false;
-			});
-		});
+	// 	describe("Response Delegation", () => {
+	// 		it("should pass down the chain of response handlers for several connected singalling channels", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
+	// 	});
 
-		describe("Connection Closure", () => {
-			it("should decrement a connection's usage count on .close()", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 	describe("Connection Closure", () => {
+	// 		it("should decrement a connection's usage count on .close()", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should increment a connection's usage count on .connectTo()", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 		it("should increment a connection's usage count on .connectTo()", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should close a connection after TTL once usages=0 on both sides of the connection", () => {
-				//TODO
-				expect(true).false;
-			});
+	// 		it("should close a connection after TTL once usages=0 on both sides of the connection", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
 
-			it("should not close a connection if it remains in use on one side", () => {
-				//TODO
-				expect(true).false;
-			});
-		});
+	// 		it("should not close a connection if it remains in use on one side", () => {
+	// 			//TODO
+	// 			expect(true).false;
+	// 		});
+	// 	});
 		
-	});
+	// });
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

38166

increased by1.21%

Lines of code

771

increased by0.13%

Number of lines in readme file

100

increased by3.09%

No dependency changes