websocket - npm Package Compare versions

Comparing version 1.0.30 to 1.0.31

CHANGELOG.md

 Changelog
 =========
 
+Version 1.0.31
+--------------
+*Released 2019-12-06*
+
+* Fix [infinite loop in error handling](https://github.com/theturtle32/WebSocket-Node/issues/329) (Thanks, [@apirila](https://github.com/apirila))
+* Fix [memory leak with multiple WebSocket servers on the same HTTP server](https://github.com/theturtle32/WebSocket-Node/pull/339) (Thanks, [@nazar-pc](https://github.com/nazar-pc))
+* [Use es5-ext/global as a more robust way to resolve browser's window object](https://github.com/theturtle32/WebSocket-Node/pull/362) (Thanks, [@michaelsbradleyjr](https://github.com/michaelsbradleyjr))
+* [adding compatibility with V8 release greater than v7.6 (node and electron engines)](https://github.com/theturtle32/WebSocket-Node/pull/376) (Thanks, [@artynet](https://github.com/artynet))
+
 Version 1.0.30
@@ -5,0 +14,0 @@ --------------

lib/browser.js

@@ -1,8 +0,11 @@
-var _global = (function () {
-	if (!this && typeof global !== 'undefined') {
-		return global;
-	}
-	return this;
-})();
-var NativeWebSocket = _global.WebSocket || _global.MozWebSocket;
+var _globalThis;
+try {
+	_globalThis = require('es5-ext/global');
+} catch (error) {
+} finally {
+	if (!_globalThis && typeof window !== 'undefined') { _globalThis = window; }
+	if (!_globalThis) { throw new Error('Could not determine global this'); }
+}
+
+var NativeWebSocket = _globalThis.WebSocket || _globalThis.MozWebSocket;
 var websocket_version = require('./version');
@@ -9,0 +12,0 @@

lib/WebSocketConnection.js

@@ -351,3 +351,3 @@ /************************************************************************
     }
-    this.socket.destroy(error);
+    this.socket.destroy();
     this._debug.printOutput();
@@ -354,0 +354,0 @@ };

lib/WebSocketServer.js

@@ -193,2 +193,3 @@ /************************************************************************
 WebSocketServer.prototype.handleUpgrade = function(request, socket) {
+    var self = this;
     var wsRequest = new WebSocketRequest(socket, request, this.config);
@@ -212,2 +213,5 @@ try {
     wsRequest.once('requestResolved', this._handlers.requestResolved);
+    socket.once('close', function () {
+        self._handlers.requestResolved(wsRequest);
+    });
 
@@ -214,0 +218,0 @@ if (!this.config.autoAcceptConnections && utils.eventEmitterListenerCount(this, 'request') > 0) {

package.json

@@ -20,3 +20,3 @@ {
   ],
-  "version": "1.0.30",
+  "version": "1.0.31",
   "repository": {
@@ -32,2 +32,3 @@ "type": "git",
     "debug": "^2.2.0",
+    "es5-ext": "^0.10.50",
     "nan": "^2.14.0",
@@ -34,0 +35,0 @@ "typedarray-to-buffer": "^3.1.5",

README.md

@@ -8,6 +8,2 @@ WebSocket Client & Server Implementation for Node
 
-[![NPM](https://nodei.co/npm/websocket.png?downloads=true&downloadRank=true&stars=true)](https://nodei.co/npm/websocket/)
-
-[![NPM](https://nodei.co/npm-dl/websocket.png?height=3)](https://nodei.co/npm/websocket/)
-
 [ ![Codeship Status for theturtle32/WebSocket-Node](https://codeship.com/projects/70458270-8ee7-0132-7756-0a0cf4fe8e66/status?branch=master)](https://codeship.com/projects/61106)
@@ -31,5 +27,8 @@
 
-***Current Version: 1.0.30*** — Released 2019-09-12
+***Current Version: 1.0.31*** — Released 2019-12-06
 
-* Moved gulp back to devDependencies
+* Fix [infinite loop in error handling](https://github.com/theturtle32/WebSocket-Node/issues/329) (Thanks, [@apirila](https://github.com/apirila))
+* Fix [memory leak with multiple WebSocket servers on the same HTTP server](https://github.com/theturtle32/WebSocket-Node/pull/339) (Thanks, [@nazar-pc](https://github.com/nazar-pc))
+* [Use es5-ext/global as a more robust way to resolve browser's window object](https://github.com/theturtle32/WebSocket-Node/pull/362) (Thanks, [@michaelsbradleyjr](https://github.com/michaelsbradleyjr))
+* [Adding compatibility with V8 release greater than v7.6 (node and electron engines)](https://github.com/theturtle32/WebSocket-Node/pull/376) (Thanks, [@artynet](https://github.com/artynet))
 
@@ -36,0 +35,0 @@ [View the full changelog](CHANGELOG.md)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

164534

increased by1.16%

Lines of code

2817

increased by0.21%

Worsened metrics

Dependency count

5

increased by25%

Number of lines in readme file

273

decreased by-0.36%

Dependency changes

• + Addedes5-ext@^0.10.50

• + Addedd@1.0.2(transitive)

• + Addedes5-ext@0.10.64(transitive)

• + Addedes6-iterator@2.0.3(transitive)

• + Addedes6-symbol@3.1.4(transitive)

• + Addedesniff@2.0.1(transitive)

• + Addedevent-emitter@0.3.5(transitive)

• + Addedext@1.7.0(transitive)

• + Addednext-tick@1.1.0(transitive)

• + Addedtype@2.7.3(transitive)