webvr-polyfill - npm Package Compare versions

Comparing version 0.9.27 to 0.9.28

package.json

 {
   "name": "webvr-polyfill",
-  "version": "0.9.27",
+  "version": "0.9.28",
   "homepage": "https://github.com/googlevr/webvr-polyfill",
   "authors": [
     "Boris Smus <[e-mail]>",
-    "Brandon Jones <[e-mail]>"
+    "Brandon Jones <[e-mail]>",
+    "Jordan Santell <[e-mail]>"
   ],
@@ -16,5 +17,8 @@ "description": "Use WebVR today, on mobile or desktop, without requiring a special browser build.",
     "browserify": "latest",
+    "chai": "^3.5.0",
     "derequire": "latest",
+    "jsdom": "^9.12.0",
+    "mocha": "^3.2.0",
     "watchify": "latest",
-    "uglifyjs": "latest"
+    "uglify-js": "^3.0.11"
   },
@@ -30,3 +34,4 @@ "main": "build/webvr-polyfill.js",
     "build": "browserify src/main.js --standalone WebVRPolyfill | derequire > build/webvr-polyfill.js",
-    "min": "browserify src/main.js --standalone WebVRPolyfill | derequire | uglifyjs -c > build/webvr-polyfill.min.js"
+    "min": "browserify src/main.js --standalone WebVRPolyfill | derequire | uglifyjs -c > build/webvr-polyfill.min.js",
+    "test": "mocha"
   },
@@ -33,0 +38,0 @@ "repository": "googlevr/webvr-polyfill",

README.md

 # WebVR Polyfill
 
+[![Build Status](http://img.shields.io/travis/googlevr/webvr-polyfill.svg?style=flat-square)](https://travis-ci.org/googlevr/webvr-polyfill)
+[![Build Status](http://img.shields.io/npm/v/webvr-polyfill.svg?style=flat-square)](https://www.npmjs.org/package/webvr-polyfill)
+
+
 A JavaScript implementation of the [WebVR spec][spec]. This project lets you use
@@ -4,0 +8,0 @@ WebVR today, without requiring a [special][moz] [browser][cr] build. It also

src/base.js

@@ -240,3 +240,3 @@ /*
 
-      function onFullscreenChange() {
+      var onFullscreenChange = function() {
         var actualFullscreenElement = Util.getFullscreenElement();
@@ -265,3 +265,3 @@
       }
-      function onFullscreenError() {
+      var onFullscreenError = function() {
         if (!self.waitingForPresent_) {
@@ -287,3 +287,3 @@ return;
         self.waitingForPresent_ = true;
-      } else if (Util.isIOS()) {
+      } else if (Util.isIOS() || Util.isWebViewAndroid()) {
         // *sigh* Just fake it.
@@ -319,2 +319,9 @@ self.wakelock_.request();
 
+      if (Util.isWebViewAndroid()) {
+        self.removeFullscreenWrapper();
+        self.removeFullscreenListeners_();
+        self.endPresent_();
+        self.fireVRDisplayPresentChange_();
+      }
+
       resolve();
@@ -321,0 +328,0 @@ } else {

src/dpdb/dpdb.js

@@ -18,7 +18,8 @@ /*
 // as a fallback in case we can't load the online one).
-var DPDB_CACHE = require('./dpdb-cache.js');
+var DPDB_CACHE = require('./dpdb.json');
 var Util = require('../util.js');
 
 // Online DPDB URL.
-var ONLINE_DPDB_URL = 'https://storage.googleapis.com/cardboard-dpdb/dpdb.json';
+var ONLINE_DPDB_URL =
+  'https://dpdb.webvr.rocks/dpdb.json';
 
@@ -25,0 +26,0 @@ /**

src/touch-panner.js

@@ -48,3 +48,5 @@ /*
   // Only respond if there is exactly one touch.
-  if (e.touches.length != 1) {
+  // Note that the Daydream controller passes in a `touchstart` event with
+  // no `touches` property, so we must check for that case too.
+  if (!e.touches || e.touches.length != 1) {
     return;
@@ -51,0 +53,0 @@ }

src/util.js

@@ -42,2 +42,11 @@ /*
 
+Util.isWebViewAndroid = (function() {
+  var isWebViewAndroid = navigator.userAgent.indexOf('Version') !== -1 &&
+      navigator.userAgent.indexOf('Android') !== -1 &&
+      navigator.userAgent.indexOf('Chrome') !== -1;
+  return function() {
+    return isWebViewAndroid;
+  };
+})();
+
 Util.isSafari = (function() {
@@ -87,2 +96,5 @@ var isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
 Util.requestFullscreen = function(element) {
+  if (Util.isWebViewAndroid()) {
+      return false;
+  }
   if (element.requestFullscreen) {
@@ -89,0 +101,0 @@ element.requestFullscreen();

src/viewer-selector.js

@@ -30,9 +30,14 @@ /*
 function ViewerSelector() {
-  // Try to load the selected key from local storage. If none exists, use the
-  // default key.
+  // Try to load the selected key from local storage.
   try {
-    this.selectedKey = localStorage.getItem(VIEWER_KEY) || DEFAULT_VIEWER;
+    this.selectedKey = localStorage.getItem(VIEWER_KEY);
   } catch (error) {
     console.error('Failed to load viewer profile: %s', error);
   }
+  
+  //If none exists, or if localstorage is unavailable, use the default key.
+  if (!this.selectedKey) {
+    this.selectedKey = DEFAULT_VIEWER; 
+  }
+  
   this.dialog = this.createDialog_(DeviceInfo.Viewers);
@@ -39,0 +44,0 @@ this.root = null;

src/webvr-polyfill.js

@@ -103,3 +103,3 @@ /*
   // Polyfill native VRDisplay.getFrameData
-  if (this.nativeWebVRAvailable && this.isCardboardCompatible() && window.VRFrameData) {
+  if (this.nativeWebVRAvailable && window.VRFrameData) {
     var nativeFrameData = new window.VRFrameData();
@@ -106,0 +106,0 @@ var nativeGetFrameData = window.VRDisplay.prototype.getFrameData;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

668024

increased by2.07%

Number of package files

34

increased by6.25%

Lines of code

12853

increased by10.99%

Number of lines in readme file

137

increased by3.01%

Worsened metrics

Dev dependency count

7

increased by75%

Number of low supply chain risk alerts

12

increased by9.09%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes