windows-build-tools - npm Package Compare versions

Comparing version 2.1.3 to 2.1.4

lib/install/index.js

@@ -18,3 +18,4 @@ 'use strict';
 var _require4 = require('../logging'),
-    log = _require4.log;
+    log = _require4.log,
+    shouldLog = _require4.shouldLog;
 
@@ -56,2 +57,4 @@ var launchInstaller = require('./launch');
 function launchLog() {
+  if (!shouldLog) return;
+
   log('Launched installers, now waiting for them to finish.');
@@ -69,2 +72,4 @@ log('This will likely take some time - please be patient!\n');
 function stopLog() {
+  if (!shouldLog) return;
+
   clearInterval(lastLinesInterval);
@@ -86,3 +91,3 @@ }
       if (result === 'success') {
-        vccLastLines = [chalk.bold.green('ully installed Visual Studio Build Tools.')];
+        vccLastLines = [chalk.bold.green('Successfully installed Visual Studio Build Tools.')];
         debug('Installer: Successfully installed Visual Studio Build Tools according to tailer');
@@ -89,0 +94,0 @@ resolve();

lib/logging.js

 'use strict';
 
+var shouldLog = !process.env.npm_config_disable_logging;
+
 /**
  * Log, unless logging is disabled. Parameters identical with console.log.
  */
-
 function log() {
-  if (!process.env.npm_config_disable_logging) {
+  if (shouldLog) {
     console.log.apply(this, arguments);
@@ -17,3 +18,3 @@ }
 function warn() {
-  if (!process.env.npm_config_disable_logging) {
+  if (shouldLog) {
     console.warn.apply(this, arguments);
@@ -27,3 +28,3 @@ }
 function error() {
-  if (!process.env.npm_config_disable_logging) {
+  if (shouldLog) {
     console.error.apply(this, arguments);
@@ -36,3 +37,4 @@ }
   warn: warn,
-  error: error
+  error: error,
+  shouldLog: shouldLog
 };

package.json

 {
   "name": "windows-build-tools",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "description": "Install C++ Build Tools for Windows using npm",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/install/index.js

@@ -9,3 +9,3 @@ 'use strict'
 const { createSingleLineLogger } = require('../utils/single-line-log')
-const { log } = require('../logging')
+const { log, shouldLog } = require('../logging')
 const launchInstaller = require('./launch')
@@ -46,2 +46,4 @@ const Tailer = require('./tailer')
 function launchLog () {
+  if (!shouldLog) return
+
   log('Launched installers, now waiting for them to finish.')
@@ -59,2 +61,4 @@ log('This will likely take some time - please be patient!\n')
 function stopLog () {
+  if (!shouldLog) return
+
   clearInterval(lastLinesInterval)
@@ -76,3 +80,3 @@ }
       if (result === 'success') {
-        vccLastLines = [ chalk.bold.green('ully installed Visual Studio Build Tools.') ]
+        vccLastLines = [ chalk.bold.green('Successfully installed Visual Studio Build Tools.') ]
         debug('Installer: Successfully installed Visual Studio Build Tools according to tailer')
@@ -79,0 +83,0 @@ resolve()

src/logging.js

 'use strict'
 
+const shouldLog = !process.env.npm_config_disable_logging
+
 /**
@@ -7,3 +9,3 @@ * Log, unless logging is disabled. Parameters identical with console.log.
 function log () {
-  if (!process.env.npm_config_disable_logging) {
+  if (shouldLog) {
     console.log.apply(this, arguments)
@@ -17,3 +19,3 @@ }
 function warn () {
-  if (!process.env.npm_config_disable_logging) {
+  if (shouldLog) {
     console.warn.apply(this, arguments)
@@ -27,3 +29,3 @@ }
 function error () {
-  if (!process.env.npm_config_disable_logging) {
+  if (shouldLog) {
     console.error.apply(this, arguments)
@@ -36,3 +38,4 @@ }
   warn,
-  error
+  error,
+  shouldLog
 }

No alert changes

Improved metrics

Total package byte prevSize

166059

increased by0.09%

Lines of code

1432

increased by0.63%

No dependency changes