worker-factory - npm Package Compare versions

Comparing version 4.0.0 to 4.1.0

build/es2018/helpers/create-message-handler.js

@@ -9,3 +9,5 @@ import { renderMethodNotFoundError, renderMissingResponseError, renderUnexpectedResultError } from './error-renderers';
             }
-            const response = messageHandler(params);
+            const response = (params === undefined) ?
+                messageHandler() :
+                messageHandler(params);
             if (response === undefined) {
@@ -12,0 +14,0 @@ throw renderMissingResponseError({ method });

build/es2018/helpers/extend-worker-implementation.js

@@ -23,5 +23,3 @@ import { generateUniqueNumber } from 'fast-unique-numbers';
             return { result: null };
-        }, 
-        // @todo It should be okay to define a function without a parameter if it doesn't need one.
-        isSupported: async (_) => {
+        }, isSupported: async () => {
             const isSelfSupported = await isSupportingTransferables();
@@ -28,0 +26,0 @@ if (isSelfSupported) {

build/es2018/types/index.d.ts

 export * from './destroy-worker-function';
 export * from './message';
 export * from './message-receiver';
+export * from './message-receiver-with-params';
+export * from './message-receiver-without-params';
 export * from './transferable';
@@ -5,0 +7,0 @@ export * from './typed-array';

build/es2018/types/message-receiver.d.ts

 import { TMessage } from './message';
-export declare type TMessageReceiver<T extends TMessage> = (params: T['params']) => T['response'] | Promise<T['response']>;
+import { TMessageReceiverWithParams } from './message-receiver-with-params';
+import { TMessageReceiverWithoutParams } from './message-receiver-without-params';
+export declare type TMessageReceiver<T extends TMessage> = T['params'] extends undefined ? TMessageReceiverWithoutParams<T['response']> : TMessageReceiverWithParams<T['params'], T['response']>;
 //# sourceMappingURL=/build/es2018/types/message-receiver.d.ts.map

build/es5/bundle.js

@@ -59,3 +59,3 @@ (function (global, factory) {
                   case 5:
-                    response = messageHandler(params);
+                    response = params === undefined ? messageHandler() : messageHandler(params);
 
@@ -207,7 +207,6 @@ if (!(response === undefined)) {
         },
-        // @todo It should be okay to define a function without a parameter if it doesn't need one.
         isSupported: function () {
           var _isSupported = _asyncToGenerator(
           /*#__PURE__*/
-          _regeneratorRuntime.mark(function _callee(_) {
+          _regeneratorRuntime.mark(function _callee() {
             var isSelfSupported, result, synchronousResult;
@@ -266,3 +265,3 @@ return _regeneratorRuntime.wrap(function _callee$(_context) {
 
-          return function isSupported(_x) {
+          return function isSupported() {
             return _isSupported.apply(this, arguments);
@@ -269,0 +268,0 @@ };

package.json

@@ -85,3 +85,3 @@ {
   "types": "build/es2018/module.d.ts",
-  "version": "4.0.0"
+  "version": "4.1.0"
 }

src/helpers/create-message-handler.ts

 import { IAugmentedError } from 'compilerr';
 import { IBrokerEvent, IErrorNotification, IErrorResponse, IReceiver, IRequest, IWorkerDefinition } from '../interfaces';
-import { TWorkerImplementation } from '../types';
+import { TMessageReceiverWithParams, TMessageReceiverWithoutParams, TWorkerImplementation } from '../types';
 import { renderMethodNotFoundError, renderMissingResponseError, renderUnexpectedResultError } from './error-renderers';
@@ -18,3 +18,5 @@
 
-            const response = messageHandler(params);
+            const response = (params === undefined) ?
+                (messageHandler as TMessageReceiverWithoutParams<T[typeof method]['response']>)() :
+                (messageHandler as TMessageReceiverWithParams<T[typeof method]['params'], T[typeof method]['response']>)(params);
 
@@ -21,0 +23,0 @@ if (response === undefined) {

src/helpers/extend-worker-implementation.ts

@@ -42,4 +42,3 @@ import { generateUniqueNumber } from 'fast-unique-numbers';
         },
-        // @todo It should be okay to define a function without a parameter if it doesn't need one.
-        isSupported: async (_) => {
+        isSupported: async () => {
             const isSelfSupported = await isSupportingTransferables();
@@ -46,0 +45,0 @@

src/types/index.ts

 export * from './destroy-worker-function';
 export * from './message';
 export * from './message-receiver';
+export * from './message-receiver-with-params';
+export * from './message-receiver-without-params';
 export * from './transferable';
@@ -5,0 +7,0 @@ export * from './typed-array';

src/types/message-receiver.ts

 import { TMessage } from './message';
+import { TMessageReceiverWithParams } from './message-receiver-with-params';
+import { TMessageReceiverWithoutParams } from './message-receiver-without-params';
 
-export type TMessageReceiver<T extends TMessage> = (params: T['params']) => T['response'] | Promise<T['response']>;
+export type TMessageReceiver<T extends TMessage> = T['params'] extends undefined ?
+    TMessageReceiverWithoutParams<T['response']> :
+    TMessageReceiverWithParams<T['params'], T['response']>;

No alert changes

Improved metrics

Total package byte prevSize

62018

increased by4.95%

Number of package files

165

increased by6.45%

Lines of code

787

increased by2.34%

No dependency changes