xterm - npm Package Compare versions

Comparing version 2.5.0 to 2.6.0

bower.json

 {
   "name": "xterm.js",
-  "version": "2.5.0",
+  "version": "2.6.0",
   "ignore": ["demo", "test", ".gitignore"],
@@ -5,0 +5,0 @@ "main": [

gulpfile.js

@@ -86,2 +86,3 @@ const browserify = require('browserify');
       .pipe(mocha())
+      .once('error', () => process.exit(1))
       .pipe(istanbul.writeReports());
@@ -88,0 +89,0 @@ });

lib/xterm.js

@@ -374,3 +374,3 @@ "use strict";
 };
-Terminal.prototype.open = function (parent) {
+Terminal.prototype.open = function (parent, focus) {
     var self = this, i = 0, div;
@@ -437,3 +437,12 @@ this.parent = parent || this.parent;
     this.initGlobal();
-    this.focus();
+    if (typeof focus == 'undefined') {
+        var message = 'You did not pass the `focus` argument in `Terminal.prototype.open()`.\n';
+        message += 'The `focus` argument now defaults to `true` but starting with xterm.js 3.0 ';
+        message += 'it will default to `false`.';
+        console.warn(message);
+        focus = true;
+    }
+    if (focus) {
+        this.focus();
+    }
     on(this.element, 'click', function () {
@@ -1459,4 +1468,6 @@ var selection = document.getSelection(), collapsed = selection.isCollapsed, isRange = typeof collapsed == 'boolean' ? !collapsed : selection.type == 'Range';
     var customKeydownHandler = this.customKeydownHandler;
+    var cursorBlinkInterval = this.cursorBlinkInterval;
     Terminal.call(this, this.options);
     this.customKeydownHandler = customKeydownHandler;
+    this.cursorBlinkInterval = cursorBlinkInterval;
     this.refresh(0, this.rows - 1);
@@ -1463,0 +1474,0 @@ this.viewport.syncScrollArea();

package.json

 {
   "name": "xterm",
   "description": "Full xterm terminal, in your browser",
-  "version": "2.5.0",
+  "version": "2.6.0",
   "ignore": [
@@ -6,0 +6,0 @@ "demo",

README.md

@@ -35,2 +35,6 @@ # [![xterm.js logo](logo.png)](https://xtermjs.org)
 - [**Cloud Commander**](https://cloudcmd.io "Cloud Commander"): Orthodox web file manager with console and editor.
+- [**Codevolve**](https://www.codevolve.com "Codevolve"): Online platform for interactive coding and web development courses. Live container-backed terminal uses `xterm.js`.
+- [**RStudio**](https://www.rstudio.com/products/RStudio "RStudio"): RStudio is an integrated development environment (IDE) for R.
+- [**Terminal for Atom**](https://github.com/jsmecham/atom-terminal-tab): A simple terminal for the Atom text editor.
+- [**Eclipse Orion**](https://orionhub.org): A modern, open source software development environment that runs in the cloud. Code, deploy and run in the cloud.
 
@@ -37,0 +41,0 @@ Do you use xterm.js in your application as well? Please [open a Pull Request](https://github.com/sourcelair/xterm.js/pulls) to include it here. We would love to have it in our list.

src/xterm.js

@@ -610,4 +610,5 @@ /**
  * @param {HTMLElement} parent The element to create the terminal within.
+ * @param {boolean} focus Focus the terminal, after it gets instantiated in the DOM
  */
-Terminal.prototype.open = function(parent) {
+Terminal.prototype.open = function(parent, focus) {
   var self=this, i=0, div;
@@ -633,3 +634,3 @@
 
-  this.element.style.height
+  this.element.style.height;
   this.element.setAttribute('tabindex', 0);
@@ -701,5 +702,20 @@
 
-  // Ensure there is a Terminal.focus.
-  this.focus();
+  /**
+   * Automatic focus functionality.
+   * TODO: Default to `false` starting with xterm.js 3.0.
+   */
+  if (typeof focus == 'undefined') {
+    let message = 'You did not pass the `focus` argument in `Terminal.prototype.open()`.\n';
 
+    message += 'The `focus` argument now defaults to `true` but starting with xterm.js 3.0 ';
+    message += 'it will default to `false`.';
+
+    console.warn(message);
+    focus = true;
+  }
+
+  if (focus) {
+    this.focus();
+  }
+
   on(this.element, 'click', function() {
@@ -2199,4 +2215,6 @@ var selection = document.getSelection(),
   var customKeydownHandler = this.customKeydownHandler;
+  var cursorBlinkInterval = this.cursorBlinkInterval;
   Terminal.call(this, this.options);
   this.customKeydownHandler = customKeydownHandler;
+  this.cursorBlinkInterval = cursorBlinkInterval;
   this.refresh(0, this.rows - 1);
@@ -2203,0 +2221,0 @@ this.viewport.syncScrollArea();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1303248

increased by0.25%

Lines of code

24548

increased by0.16%

Number of lines in readme file

139

increased by2.96%

No dependency changes