xterm - npm Package Compare versions

Comparing version 3.15.0-beta11 to 3.15.0-beta12

package.json

 {
   "name": "xterm",
   "description": "Full xterm terminal, in your browser",
-  "version": "3.15.0-beta11",
+  "version": "3.15.0-beta12",
   "main": "lib/xterm.js",
@@ -6,0 +6,0 @@ "types": "typings/xterm.d.ts",

src/common/Clone.ts

@@ -9,3 +9,3 @@ /**
  */
-export function clone<T>(val: T, depth: number = 5): T | null {
+export function clone<T>(val: T, depth: number = 5): T {
   if (typeof val !== 'object') {
@@ -15,7 +15,2 @@ return val;
 
-  // cloning null always returns null
-  if (val === null) {
-    return null;
-  }
-
   // If we're cloning an array, use an array as the base, otherwise use an object
@@ -26,3 +21,3 @@ const clonedObject: any = Array.isArray(val) ? [] : {};
     // Recursively clone eack item unless we're at the maximum depth
-    clonedObject[key] = depth <= 1 ? val[key] : clone(val[key], depth - 1);
+    clonedObject[key] = depth <= 1 ? val[key] : (val[key] ? clone(val[key], depth - 1) : val[key]);
   }
@@ -29,0 +24,0 @@

src/public/Terminal.ts

@@ -155,3 +155,3 @@ /**
   public getOption(key: any): any {
-    return this._core.getOption(key);
+    return this._core.optionsService.getOption(key);
   }
@@ -170,3 +170,3 @@ public setOption(key: 'bellSound' | 'fontFamily' | 'termName', value: string): void;
   public setOption(key: any, value: any): void {
-    this._core.setOption(key, value);
+    this._core.optionsService.setOption(key, value);
   }
@@ -173,0 +173,0 @@ public refresh(start: number, end: number): void {

src/renderer/RenderCoordinator.ts

@@ -14,2 +14,3 @@ /**
 import { CharacterJoinerHandler } from '../Types';
+import { IOptionsService } from 'common/options/Types';
 
@@ -37,3 +38,4 @@ export class RenderCoordinator extends Disposable {
     private _rowCount: number,
-    screenElement: HTMLElement
+    screenElement: HTMLElement,
+    optionsService: IOptionsService
   ) {
@@ -48,2 +50,4 @@ super();
 
+    this.register(optionsService.onOptionChange(() => this._renderer.onOptionsChanged()));
+
     // dprchange should handle this case, we need this as well for browsers that don't support the
@@ -150,6 +154,2 @@ // matchMedia query.
 
-  public onOptionsChanged(): void {
-    this._renderer.onOptionsChanged();
-  }
-
   public clear(): void {
@@ -156,0 +156,0 @@ this._renderer.clear();

src/SoundManager.ts

@@ -8,8 +8,2 @@ /**
 
-// Source: https://freesound.org/people/altemark/sounds/45759/
-// This sound is released under the Creative Commons Attribution 3.0 Unported
-// (CC BY 3.0) license. It was created by 'altemark'. No modifications have been
-// made, apart from the conversion to base64.
-export const DEFAULT_BELL_SOUND = 'data:audio/wav;base64,UklGRigBAABXQVZFZm10IBAAAAABAAEARKwAAIhYAQACABAAZGF0YQQBAADpAFgCwAMlBZoG/wdmCcoKRAypDQ8PbRDBEQQTOxRtFYcWlBePGIUZXhoiG88bcBz7HHIdzh0WHlMeZx51HmkeUx4WHs8dah0AHXwc3hs9G4saxRnyGBIYGBcQFv8U4RPAEoYRQBACD70NWwwHC6gJOwjWBloF7gOBAhABkf8b/qv8R/ve+Xf4Ife79W/0JfPZ8Z/wde9N7ijtE+wU6xvqM+lb6H7nw+YX5mrlxuQz5Mzje+Ma49fioeKD4nXiYeJy4pHitOL04j/jn+MN5IPkFOWs5U3mDefM55/ogOl36m7rdOyE7abuyu8D8Unyj/Pg9D/2qfcb+Yn6/vuK/Qj/lAAlAg==';
-
 export class SoundManager implements ISoundManager {
@@ -16,0 +10,0 @@ private static _audioContext: AudioContext;

src/Types.ts

@@ -11,2 +11,3 @@ /**
 import { IColorSet } from 'ui/Types';
+import { IOptionsService } from 'common/options/Types';
 
@@ -76,3 +77,2 @@ export type CustomKeyEventHandler = (event: KeyboardEvent) => boolean;
   error(text: string, data?: any): void;
-  setOption(key: string, value: any): void;
   tabSet(): void;
@@ -209,3 +209,2 @@ handler(data: string): void;
   cursorState: number;
-  options: ITerminalOptions;
   buffer: IBuffer;
@@ -218,2 +217,5 @@ buffers: IBufferSet;
   applicationCursor: boolean;
+  optionsService: IOptionsService;
+  // TODO: We should remove options once components adopt optionsService
+  options: ITerminalOptions;
 
@@ -272,4 +274,2 @@ handler(data: string): void;
   writeUtf8(data: Uint8Array): void;
-  getOption(key: string): any;
-  setOption(key: string, value: any): void;
   refresh(start: number, end: number): void;
@@ -276,0 +276,0 @@ reset(): void;

No alert changes

Improved metrics

Total package byte prevSize

1736772

increased by0.27%

Number of package files

141

increased by1.44%

Lines of code

18817

increased by0.48%

No dependency changes