xterm - npm Package Compare versions

Comparing version 5.3.0-beta.17 to 5.3.0-beta.18

package.json

 {
   "name": "xterm",
   "description": "Full xterm terminal, in your browser",
-  "version": "5.3.0-beta.17",
+  "version": "5.3.0-beta.18",
   "main": "lib/xterm.js",
@@ -6,0 +6,0 @@ "style": "css/xterm.css",

src/browser/services/MouseService.ts

@@ -34,13 +34,7 @@ /**
     const coords = getCoordsRelativeToElement(window, event, element);
-
-    // due to rounding issues in zoom states pixel values might be negative or overflow actual canvas
-    // ignore those events effectively narrowing mouse area a tiny bit at the edges
-    if (!this._charSizeService.hasValidSize
-      || coords[0] < 0
-      || coords[1] < 0
-      || coords[0] >= this._renderService.dimensions.css.canvas.width
-      || coords[1] >= this._renderService.dimensions.css.canvas.height) {
+    if (!this._charSizeService.hasValidSize) {
       return undefined;
     }
-
+    coords[0] = Math.min(Math.max(coords[0], 0), this._renderService.dimensions.css.canvas.width - 1);
+    coords[1] = Math.min(Math.max(coords[1], 0), this._renderService.dimensions.css.canvas.height - 1);
     return {
@@ -47,0 +41,0 @@ col: Math.floor(coords[0] / this._renderService.dimensions.css.cell.width),

src/browser/Terminal.ts

@@ -747,4 +747,6 @@ /**
         this._document!.removeEventListener('mouseup', requestedEvents.mouseup!);
+        el.removeEventListener('mouseup', requestedEvents.mouseup!);
         requestedEvents.mouseup = null;
       } else if (!requestedEvents.mouseup) {
+        el.addEventListener('mouseup', eventListeners.mouseup);
         requestedEvents.mouseup = eventListeners.mouseup;
@@ -751,0 +753,0 @@ }

src/common/services/CoreMouseService.ts

@@ -6,3 +6,3 @@ /**
 import { IBufferService, ICoreService, ICoreMouseService } from 'common/services/Services';
-import { EventEmitter, IEvent } from 'common/EventEmitter';
+import { EventEmitter } from 'common/EventEmitter';
 import { ICoreMouseProtocol, ICoreMouseEvent, CoreMouseEncoding, CoreMouseEventType, CoreMouseButton, CoreMouseAction } from 'common/Types';
@@ -9,0 +9,0 @@ import { Disposable } from 'common/Lifecycle';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2303883

increased by0.01%

Worsened metrics

Lines of code

23957

decreased by-0.01%

No dependency changes