xterm - npm Package Compare versions

Comparing version 5.3.0-beta.34 to 5.3.0-beta.35

package.json

 {
   "name": "xterm",
   "description": "Full xterm terminal, in your browser",
-  "version": "5.3.0-beta.34",
+  "version": "5.3.0-beta.35",
   "main": "lib/xterm.js",
@@ -6,0 +6,0 @@ "style": "css/xterm.css",

src/browser/decorations/BufferDecorationRenderer.ts

@@ -106,2 +106,6 @@ /*---------------------------------------------------------------------------------------------
         this._container.appendChild(element);
+        decoration.onDispose(() => {
+          this._decorationElements.delete(decoration);
+          element!.remove();
+        });
       }
@@ -108,0 +112,0 @@ element.style.top = `${line * this._renderService.dimensions.css.cell.height}px`;

src/common/buffer/Marker.ts

@@ -14,5 +14,5 @@ /**
   public isDisposed: boolean = false;
-  private _disposables: IDisposable[] = [];
+  private readonly _disposables: IDisposable[] = [];
 
-  private _id: number = Marker._nextId++;
+  private readonly _id: number = Marker._nextId++;
   public get id(): number { return this._id; }
@@ -19,0 +19,0 @@

src/common/services/DecorationService.ts

@@ -38,8 +38,3 @@ /**
 
-    this.register(toDisposable(() => {
-      for (const d of this._decorations.values()) {
-        this._onDecorationRemoved.fire(d);
-      }
-      this.reset();
-    }));
+    this.register(toDisposable(() => this.reset()));
   }
@@ -96,9 +91,2 @@
   }
-
-  public dispose(): void {
-    for (const d of this._decorations.values()) {
-      this._onDecorationRemoved.fire(d);
-    }
-    this.reset();
-  }
 }
@@ -105,0 +93,0 @@

src/common/SortedList.ts

@@ -92,3 +92,4 @@ /**
   public values(): IterableIterator<T> {
-    return this._array.values();
+    // Duplicate the array to avoid issues when _array changes while iterating
+    return [...this._array].values();
   }
@@ -95,0 +96,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

2341431

decreased by-0.01%

Lines of code

24483

decreased by-0.02%

No dependency changes