@andrewstoliarov/apple-search-ads - npm Package Compare versions

Comparing version 1.4.0 to 1.4.1

package.json

 {
   "name": "@andrewstoliarov/apple-search-ads",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Apple search ads api client.",
@@ -5,0 +5,0 @@ "main": "src/appleSearchAds.js",

src/appleSearchAds.js

@@ -40,3 +40,4 @@ 'use strict';
         return Promise.resolve(false);
-    }this._cookies = this.options.cookies;
+    }
+    this._cookies = this.options.cookies;
 
@@ -57,3 +58,2 @@ try {
         } else {
-            await this.options.errorExternalCookies();
             return Promise.resolve(false);
@@ -72,3 +72,4 @@ }
         },
-        body: JSON.stringify(body)
+        resolveWithFullResponse: true,
+        json: body
     })
@@ -236,9 +237,10 @@ }
                 .then(async (initResp) => {
-                    let proof = await authenticator.getComplete(password, JSON.parse(initResp));
-                    let completeResp = await this.signin("complete", {
+                    let proof = await authenticator.getComplete(password, initResp.toJSON().body);
+                    let completeResp = await this.signin("complete?isRememberMeEnabled=true", {
                         ...proof,
                         rememberMe: true,
-                        trustTokens: []
                     })
-                }).catch((res) => {
+                    return Promise.resolve(completeResp.toJSON());
+                }).catch((resRaw) => {
+                const res = resRaw.response.toJSON();
                 if (res.statusCode === 412) {
@@ -254,4 +256,4 @@ return this.catch412Login(res);
                     'Accept': 'application/json',
-                    'scnt': res.response.headers['scnt'],
-                    'X-Apple-ID-Session-Id': res.response.headers['x-apple-id-session-id'],
+                    'scnt': res.headers['scnt'],
+                    'X-Apple-ID-Session-Id': res.headers['x-apple-id-session-id'],
                     'X-Apple-Widget-Key': this.options.appleWidgetKey,
@@ -264,3 +266,3 @@ 'X-Requested-With': 'XMLHttpRequest',
 
-                const body = res.response.body;
+                const body = res.body;
                 if (body && body.authType === 'hsa2') {
@@ -267,0 +269,0 @@ console.log('hsa2')

test/testGetPopularity.js

@@ -21,3 +21,3 @@ var asa = require('./../src/appleSearchAds.js');
         },
-        cookies: []
+        cookies
     });
@@ -24,0 +24,0 @@ await instance.login(username, password);

No alert changes

Improved metrics

Total package byte prevSize

25607

increased by0.21%

Lines of code

643

increased by0.31%

No dependency changes